From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22C7436F42A; Mon, 9 Feb 2026 11:34:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770636885; cv=none; b=KHLpJwaGEFJMpLD6MBL6MuQKrUaf6s0ReqUKL8luxzh5EVraE9zEHO1oWMg7goUs02fpasHBw6DZVSjW9YC4cfB1B0GXb6jsITaM3robU5e8oR4QnpQblpx0sesoBx5EtV1Fdl/YjAsUDkIj+1iIOYS+bJLcPWHFzBqV1K8g84c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770636885; c=relaxed/simple; bh=4QrS573yngF8n4NJk1Mnael+xbLQy+ZP/mKMuKo0Ysc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lpgaFXstiWhnGYiZMGBu788PPENvzYGmgaqdzEgHcTneIfIzIohOXzpj/pcP9GSn2a/q9ON7t8Yd+czyYRd0JKJO/uE/ud+NbndBbusnSRQ1bAg8nAuDe27IvPLUe8S0pLRnWPZLFJhIKKfPoNS3VGksLefgh0gPP5FxaUgcics= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=WwrKdaXG; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="WwrKdaXG" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1770636883; bh=4QrS573yngF8n4NJk1Mnael+xbLQy+ZP/mKMuKo0Ysc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=WwrKdaXGqV2ja4v3TQhhSZpBckr3H70ZFVczJeL8EUXvlZNRaLuI6fQTTSG0CVVHW 8lPe2ABwjsv3/lAwLiVYsRvnHYowhnbIKcImczfEuW9bQYiPha9vUAgel8vydBNojY MOjhtHgVXRPWHDWMw7/AP1BCtVv7+7RcIXv3oUfJZ9aytAHR+KC+iqdrfneufQf492 2SxvFpjVn/4escftOJgZQO1kESdWPtZLsPBZjZ8PrfO60ABooWv6aPyA66ERArfUlJ qRIsqMwI+pXkBgU5j2WI203EaPGl1C4gYci4Rprc9CsNcN+xs2XDR7awRE/KMEXZ9w tbDXFgwbTrrfw== Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by bali.collaboradmins.com (Postfix) with ESMTPSA id C60BA17E0699; Mon, 9 Feb 2026 12:34:42 +0100 (CET) Message-ID: <3476c51b-9293-40f1-8b5c-9ac9802d7d97@collabora.com> Date: Mon, 9 Feb 2026 12:34:42 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: mfd: syscon: Add mt8516-syscfg To: Krzysztof Kozlowski , Luca Weiss Cc: ~postmarketos/upstreaming@lists.sr.ht, Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , phone-devel@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20260206-mt8516-syscfg-syscon-v1-0-96dcb37acdb4@lucaweiss.eu> <20260206-mt8516-syscfg-syscon-v1-1-96dcb37acdb4@lucaweiss.eu> <20260207-tricky-strange-swan-6f11b0@quoll> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: <20260207-tricky-strange-swan-6f11b0@quoll> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Il 07/02/26 11:51, Krzysztof Kozlowski ha scritto: > On Fri, Feb 06, 2026 at 11:20:48AM +0100, Luca Weiss wrote: >> Document the Mediatek mt8516-syscfg. > > Which is what? What is syscfg block? > Not sure this is really a SYSCFG block. This should be a GPIO controller range, which is split between IOCFG and EINT. Now, the legacy drivers are declaring the EINT iospace in the pinctrl node, and getting the GPIO controller (IOCFG) iospace from a regmap. I don't have any board with MT8516... but well, the really-right-thing to do would be to migrate that SoC off of the legacy driver, to the new-style one that *properly* takes two iospaces: "base" -> (0x10005000) "eint" -> (0x1000b000) Luca, if you've got such a board, could you please try to migrate this SoC out of the improper (but working good) driver and bindings? If not... well, I think this block is IOCFG, not SYSCFG... Cheers, Angelo >> >> Signed-off-by: Luca Weiss >> --- >> Documentation/devicetree/bindings/mfd/syscon.yaml | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml >> index e57add2bacd3..a67699f1faee 100644 >> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml >> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml >> @@ -91,6 +91,7 @@ select: >> - mediatek,mt8135-pctl-b-syscfg >> - mediatek,mt8173-pctl-a-syscfg >> - mediatek,mt8365-syscfg >> + - mediatek,mt8516-syscfg > > Why aren't you placing it with all others mediatek,mt8516 syscons? > > Why this is so generically called "syscfg", completely not looking like > a real name from datasheet unlike the others in this device. > > You have entire commit msg to explain that. > > Best regards, > Krzysztof >