mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: "Robert Święcki" <robert@swiecki.net>,
	LKML <linux-kernel@vger.kernel.org>,
	"Borislav Petkov" <bp@alien8.de>
Subject: Re: NULL-ptr deref in kvm_arch_vcpu_ioctl under AMD CPUs
Date: Sat, 10 Sep 2016 02:43:38 -0400 (EDT)	[thread overview]
Message-ID: <347879531.10009693.1473489818957.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <CACT4Y+aGfVmuoO=fhijbe+GTQBRk=mpofLqDbZCw4EyZS=_DPA@mail.gmail.com>


> 
> Hi Paolo,
> 
> I've noticed that KVM is not actually enabled on my machines. /dev/kvm
> is missing. If I mknod it manually, opens return ENODEV.
> After several hours of debugging I figured that it seems to be caused by:
> 
> commit 91fa0f8e9e2937fd9360f326ad60d51908347afd
> Author: Paolo Bonzini <pbonzini@redhat.com>
> Date:   Wed Jun 15 20:55:08 2016 +0200
>     KVM: x86: always use "acknowledge interrupt on exit"
> 
> If I move VM_EXIT_ACK_INTR_ON_EXIT from min back to opt. /dev/kvm
> become functional again (at least I can open it).
> 
> To make it clear, it all happens inside of qemu instance. I've tried
> using different cpus in qemu, including "host" cpu which is pretty
> capable:
> 
> model name : Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz
> flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov
> pat pse36 clflush mmx fxsr sse sse2 ss syscall nx pdpe1gb rdtscp lm
> constant_tsc arch_perfmon rep_good nopl eagerfpu pni pclmulqdq vmx
> ssse3 fma cx16 pcid sse4_1 sse4_2 x2apic movbe popcnt
> tsc_deadline_timer aes xsave avx f16c rdrand hypervisor lahf_lm abm
> vnmi ept fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid xsaveopt
> 
> So why am I missing VM_EXIT_ACK_INTR_ON_EXIT feature? How does it work
> for other users? And how should I fix it in a proper way?

You need to upgrade your host kernel to 3.16 (or possibly 3.17, but I
think it's 3.16).  This is a virtualization feature, and it is not
provided by the processor (as is the case for "-cpu host" features);
it's provided by the host kernel.

Thanks,

Paolo

      reply	other threads:[~2016-09-10  6:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-19 14:06 Robert Święcki
2016-02-19 16:29 ` Robert Święcki
2016-08-18 11:58 ` Paolo Bonzini
2016-08-19  0:16   ` Dmitry Vyukov
2016-08-29 12:02     ` Paolo Bonzini
2016-08-30 13:08       ` Dmitry Vyukov
2016-08-30 15:03         ` Paolo Bonzini
2016-09-09 23:03           ` Dmitry Vyukov
2016-09-10  6:43             ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=347879531.10009693.1473489818957.JavaMail.zimbra@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=bp@alien8.de \
    --cc=dvyukov@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robert@swiecki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome