mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christopher Covington <cov@codeaurora.org>
To: Peter Hurley <peter@hurleysoftware.com>,
	Russell King <linux@arm.linux.org.uk>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.com>,
	linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Timur Tabi <timur@codeaurora.org>, Jon Masters <jcm@redhat.com>,
	Mark Langsdorf <mlangsdo@redhat.com>,
	Andre Przywara <andre.przywara@arm.com>,
	Dave Martin <dave.martin@arm.com>,
	Aleksey Makarov <aleksey.makarov@linaro.org>
Subject: Re: [PATCH v2] tty: amba-pl011: Use 32-bit accesses for SBSA UART
Date: Sat, 12 Mar 2016 06:38:44 +0700	[thread overview]
Message-ID: <34828481-F042-423A-BCE9-824AAFFA1A13@codeaurora.org> (raw)
In-Reply-To: <56E2DDF6.2000107@hurleysoftware.com>



On March 11, 2016 10:02:14 PM GMT+07:00, Peter Hurley <peter@hurleysoftware.com> wrote:
>Hi Christopher,
>
>On 03/10/2016 10:35 PM, Christopher Covington wrote:
>> Version 2 of the Server Base System Architecture (SBSAv2) describes
>the
>> Generic UART registers as 32 bits wide. At least one implementation,
>found
>> on the Qualcomm Technologies QDF2432, only supports 32 bit accesses.
>> SBSAv3, which describes supported access sizes in greater detail,
>> explicitly requires support for both 16 and 32 bit accesses to all
>> registers (and 8 bit accesses to some but not all). Therefore, for
>broad
>> compatibility, simply use 32 bit accessors for the SBSA UART.
>
>So this eliminates the need to configure SBSA port via ACPI, correct?
>Thus, Aleksey can drop his "serial: pl011: use SPCR to setup 32-bit
>access"?

Yes.

Thanks,
Christopher Covington

-- 
Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Sent from my Snapdragon powered Android device with K-9 Mail. Please excuse my brevity.

  reply	other threads:[~2016-03-11 23:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-08  5:43 [PATCH] " Christopher Covington
2016-03-08 14:51 ` Mark Langsdorf
2016-03-11  6:35 ` Christopher Covington
2016-03-11 15:02   ` Peter Hurley
2016-03-11 23:38     ` Christopher Covington [this message]
2016-03-15 10:08   ` Andre Przywara
2016-03-30 12:30     ` Christopher Covington
2016-03-30 16:55       ` Greg Kroah-Hartman
2016-03-30 17:01         ` Timur Tabi
2016-03-30 18:01           ` Greg Kroah-Hartman
2016-03-30 18:11             ` Timur Tabi
2016-04-01 21:23         ` [PATCH v3] " Christopher Covington

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=34828481-F042-423A-BCE9-824AAFFA1A13@codeaurora.org \
    --to=cov@codeaurora.org \
    --cc=aleksey.makarov@linaro.org \
    --cc=andre.przywara@arm.com \
    --cc=dave.martin@arm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jcm@redhat.com \
    --cc=jslaby@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mlangsdo@redhat.com \
    --cc=peter@hurleysoftware.com \
    --cc=timur@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®