mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Wesley Cheng <quic_wcheng@quicinc.com>,
	srinivas.kandagatla@linaro.org, mathias.nyman@intel.com,
	perex@perex.cz, conor+dt@kernel.org, dmitry.torokhov@gmail.com,
	corbet@lwn.net, broonie@kernel.org, lgirdwood@gmail.com,
	tiwai@suse.com, krzk+dt@kernel.org,
	pierre-louis.bossart@linux.intel.com, Thinh.Nguyen@synopsys.com,
	robh@kernel.org, gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-sound@vger.kernel.org, linux-input@vger.kernel.org,
	linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-doc@vger.kernel.org
Subject: Re: [PATCH v33 24/31] ASoC: qcom: qdsp6: Add USB backend ASoC driver for Q6
Date: Thu, 16 Jan 2025 15:53:13 -0800	[thread overview]
Message-ID: <348416d5-01c7-416d-aecb-75da46f86a80@infradead.org> (raw)
In-Reply-To: <20250116232824.3748438-25-quic_wcheng@quicinc.com>

Hi,

Similar kernel-doc comments here...

On 1/16/25 3:28 PM, Wesley Cheng wrote:
> Create a USB BE component that will register a new USB port to the ASoC USB
> framework.  This will handle determination on if the requested audio
> profile is supported by the USB device currently selected.
> 
> Check for if the PCM format is supported during the hw_params callback.  If
> the profile is not supported then the userspace ALSA entity will receive an
> error, and can take further action.
> 
> Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
> ---
>  include/sound/q6usboffload.h  |  20 +++
>  sound/soc/qcom/Kconfig        |  10 ++
>  sound/soc/qcom/qdsp6/Makefile |   1 +
>  sound/soc/qcom/qdsp6/q6usb.c  | 246 ++++++++++++++++++++++++++++++++++
>  4 files changed, 277 insertions(+)
>  create mode 100644 include/sound/q6usboffload.h
>  create mode 100644 sound/soc/qcom/qdsp6/q6usb.c
> 
> diff --git a/include/sound/q6usboffload.h b/include/sound/q6usboffload.h
> new file mode 100644
> index 000000000000..cca6d353afc3
> --- /dev/null
> +++ b/include/sound/q6usboffload.h
> @@ -0,0 +1,20 @@
> +/* SPDX-License-Identifier: GPL-2.0
> + *
> + * sound/q6usboffload.h -- QDSP6 USB offload
> + *
> + * Copyright (c) 2022-2025 Qualcomm Innovation Center, Inc. All rights reserved.
> + */
> +
> +/**
> + * struct q6usb_offload

Missing short description.

> + * @dev - dev handle to usb be
> + * @domain - allocated iommu domain
> + * @sid - streamID for iommu
> + * @intr_num - usb interrupter number

Wrong separator character.

> + **/
> +struct q6usb_offload {
> +	struct device *dev;
> +	struct iommu_domain *domain;
> +	long long sid;
> +	u16 intr_num;
> +};


-- 
~Randy


  reply	other threads:[~2025-01-16 23:53 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-16 23:27 [PATCH v33 00/31] Introduce QC USB SND audio offloading support Wesley Cheng
2025-01-16 23:27 ` [PATCH v33 01/31] xhci: sideband: add initial api to register a secondary interrupter entity Wesley Cheng
2025-01-16 23:27 ` [PATCH v33 02/31] usb: host: xhci-mem: Cleanup pending secondary event ring events Wesley Cheng
2025-01-16 23:27 ` [PATCH v33 03/31] usb: host: xhci-mem: Allow for interrupter clients to choose specific index Wesley Cheng
2025-01-16 23:27 ` [PATCH v33 04/31] usb: host: xhci-plat: Set XHCI max interrupters if property is present Wesley Cheng
2025-01-16 23:27 ` [PATCH v33 05/31] usb: host: xhci: Notify xHCI sideband on transfer ring free Wesley Cheng
2025-01-16 23:27 ` [PATCH v33 06/31] usb: dwc3: Specify maximum number of XHCI interrupters Wesley Cheng
2025-01-16 23:28 ` [PATCH v33 07/31] ALSA: Add USB audio device jack type Wesley Cheng
2025-01-16 23:28 ` [PATCH v33 08/31] ALSA: usb-audio: Export USB SND APIs for modules Wesley Cheng
2025-01-16 23:28 ` [PATCH v33 09/31] ALSA: usb-audio: Check for support for requested audio format Wesley Cheng
2025-01-16 23:28 ` [PATCH v33 10/31] ALSA: usb-audio: Save UAC sample size information Wesley Cheng
2025-01-16 23:28 ` [PATCH v33 11/31] ALSA: usb-audio: Prevent starting of audio stream if in use Wesley Cheng
2025-01-16 23:28 ` [PATCH v33 12/31] ALSA: usb-audio: Introduce USB SND platform op callbacks Wesley Cheng
2025-01-16 23:28 ` [PATCH v33 13/31] ALSA: usb-audio: Allow for rediscovery of connected USB SND devices Wesley Cheng
2025-01-16 23:28 ` [PATCH v33 14/31] ASoC: Add SoC USB APIs for adding an USB backend Wesley Cheng
2025-01-16 23:37   ` Randy Dunlap
2025-01-16 23:50   ` Randy Dunlap
2025-01-16 23:28 ` [PATCH v33 15/31] ASoC: usb: Add PCM format check API for " Wesley Cheng
2025-01-16 23:28 ` [PATCH v33 16/31] ASoC: usb: Create SOC USB SND jack kcontrol Wesley Cheng
2025-01-16 23:28 ` [PATCH v33 17/31] ASoC: usb: Fetch ASoC card and pcm device information Wesley Cheng
2025-01-16 23:28 ` [PATCH v33 18/31] ASoC: usb: Rediscover USB SND devices on USB port add Wesley Cheng
2025-01-16 23:28 ` [PATCH v33 19/31] ASoC: doc: Add documentation for SOC USB Wesley Cheng
2025-01-16 23:28 ` [PATCH v33 20/31] ASoC: dt-bindings: qcom,q6dsp-lpass-ports: Add USB_RX port Wesley Cheng
2025-01-16 23:28 ` [PATCH v33 21/31] ASoC: dt-bindings: Update example for enabling USB offload on SM8250 Wesley Cheng
2025-01-16 23:28 ` [PATCH v33 22/31] ASoC: qcom: qdsp6: Introduce USB AFE port to q6dsp Wesley Cheng
2025-01-16 23:28 ` [PATCH v33 23/31] ASoC: qcom: qdsp6: q6afe: Increase APR timeout Wesley Cheng
2025-01-16 23:28 ` [PATCH v33 24/31] ASoC: qcom: qdsp6: Add USB backend ASoC driver for Q6 Wesley Cheng
2025-01-16 23:53   ` Randy Dunlap [this message]
2025-01-16 23:28 ` [PATCH v33 25/31] ASoC: qcom: qdsp6: Add headphone jack for offload connection status Wesley Cheng
2025-01-16 23:28 ` [PATCH v33 26/31] ASoC: qcom: qdsp6: Fetch USB offload mapped card and PCM device Wesley Cheng
2025-01-16 23:28 ` [PATCH v33 27/31] ALSA: usb-audio: qcom: Add USB QMI definitions Wesley Cheng
2025-01-16 23:28 ` [PATCH v33 28/31] ALSA: usb-audio: qcom: Introduce QC USB SND offloading support Wesley Cheng
2025-01-16 23:28 ` [PATCH v33 29/31] ALSA: usb-audio: qcom: Don't allow USB offload path if PCM device is in use Wesley Cheng
2025-01-16 23:28 ` [PATCH v33 30/31] ALSA: usb-audio: qcom: Add USB offload route kcontrol Wesley Cheng
2025-01-17  0:08   ` Randy Dunlap
2025-01-17  1:45     ` Wesley Cheng
2025-01-17  2:03       ` Wesley Cheng
2025-01-16 23:28 ` [PATCH v33 31/31] ALSA: usb-audio: qcom: Notify USB audio devices on USB offload probing Wesley Cheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=348416d5-01c7-416d-aecb-75da46f86a80@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=perex@perex.cz \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=quic_wcheng@quicinc.com \
    --cc=robh@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®