From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07C202D4B71 for ; Wed, 3 Dec 2025 08:42:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764751363; cv=none; b=HO1/t2GVTafcxjYFDiZzQJ1excgEntxsokAaD3EEfPAiprhgjDcIk3cIEwpIwKOFI11KngzPChrGoWUcwKr+1L8ic8PCXMDzofWCPZO9C0zqEXZ/JBtFEMRtRpsK5LzhDHblrbFVFnYd2wyfVqwNIIsf6cN5KkpVeTZcEKP+JLI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764751363; c=relaxed/simple; bh=ICxFLuck9SfnNnFsg4cG8X6+FFRE723qkDDin+aWOhM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Y24mqS1co8Q6eS5XiZoR8jWqtvyp/LMa8REVvUrCGI/78KWbRvp/yEz+9dW3dUg2Kho0MAO79/5D7Z/hrjWORrei5GKqK6VU4NS/gMt8GRU4vIx9bogknIHXVEDd3P+l/ftGpbMamXb9AsOlY9cjjMs1yaC+LdTVOJ+nnFTjc5E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=TzILvVHG; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="TzILvVHG" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4779cb0a33fso68657655e9.0 for ; Wed, 03 Dec 2025 00:42:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1764751359; x=1765356159; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4z48MR0puKx1M1rfqil+sFsUuYO/yJFNjmgNnDwCbIg=; b=TzILvVHGOA1w/3Vrm6e88IsbKuzc5NCBQ1cerG4574yZadH9QN6mJ9V6qm02wu7EMr fj+VYa3KBKXD5BDx7VKix6FWib0m/4nQPwhkKCTsOAf/qeIS4us7/0ETWCOluSpl8R3v E9Jd8nTJh57fmK8/tu3EEREEBsoVuhGQY2DWiAavZ4pydNAPJbiAl5NMlkQxSXUE4hLK NRvmrngFCGA94t1VkVuUmsJh9i72Q98UFv0bTtnvXuJBkWV/Wuz76ij1ryCukEu3P9u0 za1FwlV+aixd+3Nvmc26YK0I1elslHnHZx1H/T3tHWFVANtfoOZPY/W2qxN/OGRvkgYY ci7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764751359; x=1765356159; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4z48MR0puKx1M1rfqil+sFsUuYO/yJFNjmgNnDwCbIg=; b=emsOUO08dqRylQNN7HRkLMLmgqEl+bhns/MZKbNsK9FubCXtoQ6FBg0IaX92I4+hCN zMK03hwb5HFNRW7yV5AFxOdGZ/94nCFKbI4aUzoPgRjIrwknm6MVTYmHrv/cPmVoZFim QRXyD845YRpSTOKmWQT31rRc87dN/8Zousx00QxwUt36U7dx+JAGWGqV3vrgSkgvimsU Dt9jACW08m0AnncVxO/8Zoxa6jJlo9Bu64vHu+cdpVCux+aRev/8OK06/8TLnWQHsecw 6HugCIRxQC3BMFRJPFVx9NzXR7CBzi3UxBoYMd10zAUSPd7AS5sVKduTbwrFDUSCsX6w fDhw== X-Forwarded-Encrypted: i=1; AJvYcCWmTVKGaYaS9r1l8Ig1C+blc3aU0PNTQFGNv1/NEBj469D9mVPKYtNgxjRlejdHidkzipHJXE9ppFIUHrw=@vger.kernel.org X-Gm-Message-State: AOJu0YwwFMQz/XTY0fUILu+6Ou4nh426Lbrz5ULDka5gZNG+QBdQaV8P u4W41Sup+51pwfKb4CrBtyO9OwL0J+LtBIcI2PBnqk/TLasE7Q8MJpG6pFFXRGrAMYU= X-Gm-Gg: ASbGncsgHqo4F+rKKu+DeFadoPxQV2AQ0baesp98XfJLc9A32pGbZCZxWwW0jQgFh7u 26juMh5pGb9z/1fAkTjm5CuSXdFInuHGr+DBCAqAxGjKI3+haXxqk357cg+oBy5NPezxipcYpv/ +quqI3Kc1KHfPaCWl4VlFVwcOXFA2zK19mpA/9HPiS3+wWJfvyKIhwuSYWF/cZZSZ0+0nEZ6Awn /coPBHyM8atoqs9L5eHsyWdJMvmn/45jC5ADhr4JJqlIiUI5LcFacdoGz9pMfGxulbo3ttYJvNZ 7FtWiNqneSKXbhn/LmUK0ymhgBJ2ZNyKi7hcpQ3eqtwr9Wr9GBeFmSw23KcmvPEt0/lpukitT2o BN/oOPxSU/Yz+5xUlVbHR5/JXCJPbKqrhAvS/E8zhN2fuN1GHBs6vQQLtkCxBRbzPCErfjTu3eD PhvxX2ICUQu9kzfJ6YCxSGrG8izEcbeDFlsgLSCPErbhJBIq9n X-Google-Smtp-Source: AGHT+IEy36ArV9McU30R8H12wfKSN4iaRTsluRsIPsdGl5bOondsDWhwEKL9yAl9sToY1SSYh7kLpQ== X-Received: by 2002:a05:6000:1849:b0:42b:323b:f138 with SMTP id ffacd0b85a97d-42f731c2b7dmr1313815f8f.41.1764751359294; Wed, 03 Dec 2025 00:42:39 -0800 (PST) Received: from ?IPV6:2001:a61:2b8d:fd01:a55e:1753:c605:d34f? ([2001:a61:2b8d:fd01:a55e:1753:c605:d34f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42e1ca9aea3sm37237413f8f.35.2025.12.03.00.42.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Dec 2025 00:42:38 -0800 (PST) Message-ID: <34848777-b370-4a63-8b08-c3246d214167@suse.com> Date: Wed, 3 Dec 2025 09:42:38 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/1] scsi: core: Fix error handler encryption support To: Christoph Hellwig , Po-Wen Kao Cc: "James E.J. Bottomley" , "Martin K. Petersen" , "open list:SCSI SUBSYSTEM" , open list References: <20251203073310.2248956-1-powenkao@google.com> Content-Language: en-US From: Hannes Reinecke In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 12/3/25 08:38, Christoph Hellwig wrote: > On Wed, Dec 03, 2025 at 07:33:08AM +0000, Po-Wen Kao wrote: >> From: Brian Kao >> >> Some low-level drivers (LLD) access block layer crypto fields, such as >> rq->crypt_keyslot and rq->crypt_ctx within `struct request`, to >> configure hardware for inline encryption. > > So don't do that except for commands that can actually be encrypted, > i.e. those that have non-zero payload size. I think you really want > to fix this in the driver. > > And we really need to stop passing scsi_cmnds to the error handler. > > Hannes, any chance you could send another batch of your decades old > series? > There had been an intersection with the reserved command stuff, but now that Bart has dusted things off there I guess I should give it another go. Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.com +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich