From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CH4PR04CU002.outbound.protection.outlook.com (mail-northcentralusazon11013071.outbound.protection.outlook.com [40.107.201.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2FFB309F0E for ; Wed, 18 Feb 2026 11:26:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.201.71 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771413986; cv=fail; b=HNmc3MmhC6j4THDXUTHO89ZRLOo7+S7xnYNnX0ljMDaV+MZhqZPQGUDYkfjgYyhQG990uH/fGJIx5/sRH2ZuZQtyJnlLtz45urDSPgkm9p3U4CDtsUEJscz6R2o3lLq9XELNqYU6ZQxK1XaduGN4iySJxT5L64fBSeoC+yVWzK8= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771413986; c=relaxed/simple; bh=H6vZzBsGFRwLL/ZQLHcamO+gYqwTV59GHBuMCQW95ow=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=L5lbYgS/nTT/nrbLxlvZ+IZTuAXsGne4stsQKoEh1KoMgFQckksqzxort/hlkyVA7hh1kGcBxWjMGlrIj8g/PR1ZaqJ4AB/tQ+qlJ/BonrLYvOlbZKYI77T4qYqNZqkZezSmvprownoQ9xPglkx3Dzoxr8JdyAQvXgsrteIDU68= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=RXu9qks7; arc=fail smtp.client-ip=40.107.201.71 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="RXu9qks7" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=miiN8Rxt4kltmYqxuT8beyU5/fKCvMxiTNwsr+tC3UMCD/zc2Mnt2+Rj6NT3+MtT1ZzcqKSRPfM57tCvy+ZCN2rgYhq66YmKkL1UfEFnDxASxHH429ImBFWJAAIn22kqCPAeqKxHwY2pE6gN8VXTswTdFrTe7qcn04llgy6/p8dH60vgP1NPI4gUuPuHJf9k+TRlr8NmE1C0CZtPJShK6eRL4QQCsU4qZx7PcmZ/x9ChGDqKZLvUyivJqXdgTvUzvKReHh8RkeZSOJSFJb5lfVtYuPLu1YdZBVr3E9V8/bBT07WL04hkBsuifUznelZ8yiBK65K3IjokyH+iASSoyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OnXJgLpLUgvHjJOQP5Z1ws9LeQ2dK9dAvNwzvMyEgSg=; b=JeDwp+PBgOynQ8AsADSrcapORhUIHxi7cFjobnnNlpop3sPI8LGo/w5qFqM+xCe2WR8D0Jg9/smIEWlvJPJrP+7j2cUr3NAoh29CEjKlGpQINUU/WVsnrZUvs6QoA99CVrnu8GI7x/iAjsKtGCzb4z0wlgX6W3EWva0lX3QEp7lNto1YM/JflCreLeWHVOttzQlGPOjLcA2jr2aKzdHFTxixXgXOpewePNGtd93pxoK7RSnBln0DeRLMBYM8g+ljfQza+4IM8XnnogxEAXKV3W2nfq8KhMfshbCXBMldie8WB3CG4yFXP8GiaRQUfi8DBVcG0M+DAwkrTTFL3yfcrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.194) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OnXJgLpLUgvHjJOQP5Z1ws9LeQ2dK9dAvNwzvMyEgSg=; b=RXu9qks70AKLenrmtJAjh+s38FnvSo4x1g9WVwf681urKR4gXqvXcyfYj2K00ivxAcQ0GD5Ml3ZR+4bvuplQVP9CA23Xkiby/OZk+VuBE1m6xuFxQE/lKvjgQ2EaKVYbPSOUK2qeIDbClYsT6TJQYlli7H7jyJ1AC8QZ7UPrabs= Received: from CH0PR03CA0322.namprd03.prod.outlook.com (2603:10b6:610:118::27) by DS0PR10MB997601.namprd10.prod.outlook.com (2603:10b6:8:314::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.13; Wed, 18 Feb 2026 11:26:23 +0000 Received: from CH2PEPF0000013B.namprd02.prod.outlook.com (2603:10b6:610:118:cafe::5e) by CH0PR03CA0322.outlook.office365.com (2603:10b6:610:118::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.15 via Frontend Transport; Wed, 18 Feb 2026 11:26:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.194; helo=lewvzet200.ext.ti.com; pr=C Received: from lewvzet200.ext.ti.com (198.47.23.194) by CH2PEPF0000013B.mail.protection.outlook.com (10.167.244.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.12 via Frontend Transport; Wed, 18 Feb 2026 11:26:22 +0000 Received: from DLEE211.ent.ti.com (157.170.170.113) by lewvzet200.ext.ti.com (10.4.14.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Wed, 18 Feb 2026 05:26:22 -0600 Received: from DLEE208.ent.ti.com (157.170.170.97) by DLEE211.ent.ti.com (157.170.170.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Wed, 18 Feb 2026 05:26:21 -0600 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE208.ent.ti.com (157.170.170.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Wed, 18 Feb 2026 05:26:21 -0600 Received: from [10.24.69.13] (meghana-pc.dhcp.ti.com [10.24.69.13] (may be forged)) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 61IBQHVO307398; Wed, 18 Feb 2026 05:26:17 -0600 Message-ID: <3486f2bb-439d-4f7e-aad5-8345fba0283b@ti.com> Date: Wed, 18 Feb 2026 16:56:16 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] irqchip/irq-pruss-intc: Fix processing of IEP interrupts To: Marc Zyngier CC: MD Danish Anwar , Grzegorz Jaszczyk , Suman Anna , David Lechner , Roger Quadros , "Andrew F. Davis" , Thomas Gleixner , , , , References: <20230919061900.369300-1-danishanwar@ti.com> <20230919061900.369300-4-danishanwar@ti.com> <87ediu4nzs.wl-maz@kernel.org> <0968172c-4c41-4157-a13f-bad3dec677a9@ti.com> <86zf569utc.wl-maz@kernel.org> Content-Language: en-US From: Meghana Malladi In-Reply-To: <86zf569utc.wl-maz@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF0000013B:EE_|DS0PR10MB997601:EE_ X-MS-Office365-Filtering-Correlation-Id: 0ec2cdae-257f-4eaa-8da5-08de6ee08bb1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?a1djcFFMTHZNcXV6Q3J6OUdyWmpZMWtBNXd1ZVpHQVJQeHFTVEFiZDNicHFl?= =?utf-8?B?RE1PRno0QzZDZ25FMnQ2N3JmV0FTcmVlTXBIQjYwZlBPT2ZreG1qaWZ4UFky?= =?utf-8?B?RzdiN2RWKytwdVdRY05VWnNrZmVBMVI0SzZZdkxqSlJJSGhVNW1GSlZiRmJo?= =?utf-8?B?MFJ5L2F0cWw5NFZ4dmwwcVhJdndCY0NwbzJpMVQ1bVVVeEhuTEtFUE92RlRU?= =?utf-8?B?dUdhYURjR2NxTTdUYWlYRXo4ZndXMlVQcUI4VHUxZnl2VjZYWCtib3NwdEZE?= =?utf-8?B?eEd3WUNibE9WcUJGb25nOVNuSU8xckVrQlhEUWRYU3B6NnBqVWVucWQ2SUU1?= =?utf-8?B?Y2srWmIrN25EdnRNTVAwOTc3WW9FcUVwVlBPM29XcjlxTDlZTVhFUW5zR3pZ?= =?utf-8?B?ZGdUWDJrWnYwWFNZcHVweFArL3Z2N1VpZ1ZvblNqYmt5OUQ3VWJUaUQzeUxj?= =?utf-8?B?TXY5bXNLZ29DdUxRSVcraXNsZzJvNGk2dFdCQ1hWYWpPT1dBKzJaUUl5YWdl?= =?utf-8?B?RGVOcmM5QkpFTVVycXMyMGFuQkxCSGxoaWpDV3JIKzdHYVJ2ZUhqeDBCVnVr?= =?utf-8?B?Sy9FVXJ0UHQvV1QrSGU4cWVTbnlRckxka2hYbTdQZE1wam8rMVJSM2x3Mm1w?= =?utf-8?B?UW9YaC9BYXRGY1hLQy9ONk9PWTFFVWNHVExUZHE3a04waTJWKzZVOThVS2VB?= =?utf-8?B?SG9wWDlTL0xYODNvdmk1MmpzdDBWbWpaVzlxU1F6UFdzVTFKZ0JjWENkbmF3?= =?utf-8?B?LzdaSlRkTW1WQ24vUUpmRlJ5U0RvNTNwOTVCOW9xK04wWGVvVjFTSjFmYkZR?= =?utf-8?B?czBBOGd5aTF6QUZ3MVNDb3ZILzRnOCtaQlhaZnhXQXBKVmk1b2dhRkdLamQw?= =?utf-8?B?bExRYmJ5a2VZOWdKclE5OGo0bjNMSmEvcUJDRjVVbDVEVk8xQTlKb0dUUG1C?= =?utf-8?B?aU1kL2lEdzZaUW1EQkFYRmZKSWhLbHZweENKam0vS0dXVkcrSXhDbU0xL2cx?= =?utf-8?B?ZXd0SFg1UThFV20rVmZGcmtKcm5rTWRxNlBDSlhHNkg3RHIyM3A1QTIzcUdl?= =?utf-8?B?MUpLVXFYQjlEV1Q0a1FIc2QxTm9jZGYxd3ZyZkl3aEJEN2dlRzMxQ2hxZTND?= =?utf-8?B?Sm41V0crWUIrN2trNFdpYjhpNjltdVRHalBIb0xqcGhoSDJhd3dnTytGRy9Z?= =?utf-8?B?L2w4bnZjT3FHQWIwRUJvTE0yYllPWVVoMVFFMXAyUE90L1FwZDkzR2taeUda?= =?utf-8?B?VEduQTJNaklXM3hHdWR3NW5pdk1ZUzVGbVNIKzIvMTBnNGNqM1Jwdzk5ajdV?= =?utf-8?B?M0YrdVdob3hYTU9xOUYxZ1RNbnNzbVcvWjM5REVMR1lmWlFZQW53WUxCSWUw?= =?utf-8?B?SDJFeU1zc0Z1SzBydEhjMVZUbDRtQzd6RTZadXQwWlhQYlVlYnRYMkdualhs?= =?utf-8?B?eWUwWmE1V2VpMyt1WjErVEZoT2IyN2dqTVlhaUI2V3BmRjgwQkVBdXE4emxW?= =?utf-8?B?M3U2MGlZRmlnYTZiVjBDOWhFektLOEhsVW43VnEvWURrSTlSYUNUQkpQY24w?= =?utf-8?B?eUI2cEdwcVZqdmx5NTJtZ1RmVVd3M21qVUtEUXNVdC9VVC9BczFINlY1WHg5?= =?utf-8?B?TFNrQmpybWxxSHcxSklmQkUrVEFlMWJpZ204clFuODd3dEI5TUxJNkRoV1ZS?= =?utf-8?B?NkdQbzdjVndobWRxYmdmS05NdGg0a3BDaDFuTkVWeHJpbDlnR0V4dzhDRFIw?= =?utf-8?B?L0phdEcxM1EzYkp1dWh1amRTUkUxK3Nadnc2ZFB5MGJ1VE43a1VRTlVQOWhv?= =?utf-8?B?bzJUTWg0WEZnd1Q1SWdwMEVMMHpHdXNUZDBsRGRia0xPMWR3ekxCZVFzSGk5?= =?utf-8?B?QTZVSkVwZmlTWUM4Qis5V0t0MVR5Z2JiUzliU0V0NGowdk5Tem1PSTEyWWZ2?= =?utf-8?B?dElHU3pqYVZwM3dCTllGV011dTBxZnhRdkZYWGlsTndjVE5FK0I3OE9scWx1?= =?utf-8?B?YnlUV25jVVhhbmtiUStvdjV5eS85SEthS3ZKNlpNRlRsR3VoejZKRUhNOHhq?= =?utf-8?B?dTBsOUNFcERJZXMza2hrRlhDanQ4Mm9NN0pqaGM3SU81Q2FIcUJWV2h4ZFVY?= =?utf-8?B?Z3NQRFVSdHU1SlkwdTEyd1U4bW1HdEVMclo3V3kzSUhMWTFxc0Y5Zlhacmpq?= =?utf-8?Q?YEncEhxhTT2e9CDVflFVPPuRKOnuopYLGYLbwKlSjXDw?= X-Forefront-Antispam-Report: CIP:198.47.23.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet200.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(376014)(36860700013)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: cKXbNhweLHztlk9LIlgHBg3AE369e0NejIdLrJZKRv9OyHezuvOzyBX1PUXnqPW6HWBAMopWSK9M9m2bN4FUck3v5/66gWUwa7y0mkcfq+ImpXpUcE3VET5y3/jxvxbd5HSAeJjZ3BbxDz2zHlO+EGCpP+zO0iZFD+ONISbsoH65AoaVky5N6EJClbjpXec8WKk4+x2XAZ6ts+DTjskZFWwWfujuPJk54NP1zeM7XZHHnC4EzKZ2oexSWrzE09h4lIqmYevHYcMq/2wPBzQfVhVGCfdwiwo1x7Is7Ew35xgqQBNJaSvs1vVmaE4waVrVLBKdrBko3c8pd+IZkd9Ae/AH8XGm5j+cMzVGkwp/VOue7fBsexUXJyiySBa8MHj4ZOqGSZPCP1lhUiEaD3ZMMAqpqIW46F/iYUylEr74Gswbume1VewU2+Ou40V10pbF X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2026 11:26:22.7595 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0ec2cdae-257f-4eaa-8da5-08de6ee08bb1 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.194];Helo=[lewvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF0000013B.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB997601 Hi Marc, On 2/18/26 16:34, Marc Zyngier wrote: > On Wed, 18 Feb 2026 07:08:45 +0000, > Meghana Malladi wrote: >> >> Hi Marc, >> >> On 9/19/23 13:02, Marc Zyngier wrote: >>> On Tue, 19 Sep 2023 07:19:00 +0100, >>> MD Danish Anwar wrote: >>>> >>>> From: Suman Anna >>>> >>>> It was discovered that IEP capture/compare IRQs (event #7 on all SoCs >>>> and event #56 on K3 SoCs) are always triggered twice when PPS is >>>> generated and CMP hit event detected by IEP. >>>> >>>> An example of the problem is: >>>> pruss_intc_irq_handler >>>> generic_handle_irq >>>> handle_level_irq >>>> mask_ack_irq -> IRQ 7 masked and asked in INTC, >>>> but it's not yet cleared on HW level >>>> handle_irq_event() >>>> >>>> icss_iep_cap_cmp_handler() -> IRQ 7 is actually processed in HW >>>> irq_finalize_oneshot() >>>> unmask_irq() >>>> pruss_intc_irq_unmask() -> IRQ 7 status is still observed as set >>>> >>>> The solution is to actually ack these IRQs from pruss_intc_irq_unmask() >>>> after the IRQ source is cleared in HW. >>> >>> What you don't explain is whether the interrupt is level or edge >>> triggered? If it is level, then the "quirk" is that the interrupt >>> controller is slow to recognise that the level has changed. If it is >>> edge, this is a guaranteed recipe to lose interrupts. >>> >> >> These are level IRQs, but INTC has latency detecting the source >> deassertion, causing the double delivery (The hardware keeps the event >> asserted until cleared in IEP) - I will add more details about this >> fix in the commit message for v2. > > I'm sorry, but this comes almost 3 years late, and I've long forgotten > about all of this. I can only conclude that if you (TI, not you > personally) waited for this long to address my comments, then this is > probably not something we really need to care about. > Thanks for your reply. I understand the concern about the delay and the difficulty in revisiting something after such a long gap. This work resurfaced now because we are in the process of migrating to the 6.18 LTS kernel, and while validating the migration we encountered these issues again. For our platforms, these fixes are required to get PPS and timestamp functionality working correctly, and for ensuring long-term stability. I realize this comes a long time after the original discussion, but I would like to get the patches into the proper shape and aligned with your feedback. Thanks again for your time and guidance. Best, Meghana > Thanks, > > M. >