From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26FAE1EBFF7 for ; Wed, 18 Feb 2026 18:31:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=198.175.65.19 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771439465; cv=fail; b=aRQYKohQxz59YwlQI3ZI/KhIq6haMgU1kuan7PPMkgz2CwehLiFjNWgLs+DRG8cMMs7wUD3RBpGnmAMblxWZCoXzMwRJHk0kF90eaJgaaCZeEvzSmJaGVVDmPAwPe5lRiiEjf2PIfC6QWgVILo8yjBt3w3XT5PvU/FtwrLV5ilQ= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771439465; c=relaxed/simple; bh=iqJSCsUFFR9WpBZTPIPSWWrLAe2SGd7ApOjKaxo8dqE=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=d2rB2pIK/tj/dqU2T2oe1htM3CHbAGVnueB/wmwi+wZcN3gTLQLmmgKftZ4qSVtcU6wemhj/HoynkU8BsQdaJLrOXzlhtEAghCihUIJ7e1zqMB0rEGLjRhjnfdPQkTk1K1IqedQJXuMSxDZET4mDKuhRYwpBIzi8Md3rB9YqErE= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=YauxiJfG; arc=fail smtp.client-ip=198.175.65.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="YauxiJfG" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1771439464; x=1802975464; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=iqJSCsUFFR9WpBZTPIPSWWrLAe2SGd7ApOjKaxo8dqE=; b=YauxiJfGUYO4lK6rvqlFAdD8MvYIAwEqfZB1+J6VTQXX70eo/7p5CUVg N6TwknALwou0qXoSme33b/Ki8/toTr39J12kJuNUjlPVT5RNtnyFyCRKo Osxv4IUW7SECUFdwWrgRsoyz86D5bjtBI4E0KYBMYaaOH51Eh37Mxc/NX MLu6nqni2UcjZFdaRluD5gcyz9ptJ/9COC3BAs+ijb306yXqmikXJ/eyI eK6hryJR8bQVnLTOeuVoK2egTOQytqXOsyX3jTzTJD/4pVJbTzJahS3B6 diYRPb34vyznwCHWM3dmGZ/Dw132EanGdPzxpGR+haNbCFm+4vD3m/H0B A==; X-CSE-ConnectionGUID: 4Ievp3bdR+Wk6578gcjpaQ== X-CSE-MsgGUID: 4O6f+pY5QSmP8XdYg8aXwA== X-IronPort-AV: E=McAfee;i="6800,10657,11705"; a="72426072" X-IronPort-AV: E=Sophos;i="6.21,298,1763452800"; d="scan'208";a="72426072" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2026 10:31:03 -0800 X-CSE-ConnectionGUID: uCuI6rQ7RgCX2P/lBFw52w== X-CSE-MsgGUID: Bz4Ha72aSHGIwtYvIlbouQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,298,1763452800"; d="scan'208";a="214275541" Received: from orsmsx903.amr.corp.intel.com ([10.22.229.25]) by orviesa008.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2026 10:31:04 -0800 Received: from ORSMSX903.amr.corp.intel.com (10.22.229.25) by ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.35; Wed, 18 Feb 2026 10:31:03 -0800 Received: from ORSEDG901.ED.cps.intel.com (10.7.248.11) by ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.35 via Frontend Transport; Wed, 18 Feb 2026 10:31:03 -0800 Received: from CY3PR05CU001.outbound.protection.outlook.com (40.93.201.40) by edgegateway.intel.com (134.134.137.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.35; Wed, 18 Feb 2026 10:31:02 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=koaiAkqzsjSqPJolQmpH1DMLqYU81udRAjs6IxXfO7lXKmsqnDBaSj3uH1McTDAaHPew6uD7s9BuinyE5wNXCpJm+6sQxaZDV8MBZyRjHsWrsLb+Rg0PlTveja8ETiiCG5wRYvhzjJTqd6XyDJKfteVcUlTRb8briFYbD+X1eTkigXmIY1eu4GNzQpz0/jO/moUCFcW/b+8zD28mHJ51hEr4ifHRkyhOfahgWIARJg8+NgkfAKgm5KbLhqpP2Ptj0waLekqXtNFPRyCXzrM+HEC7h60PLhaRZiV1SC9Dfay/lqG/ZRSE2drtiqyhoWikztr8oxJleTeCT1/D4uWwrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qUZMup28I8YdYMvAySzb7e9OQ39xTXu/p97788EVV9E=; b=wiBctp03cVFJ0Of1mYGHEZym2+y811/mXyA1a6QNUFW8u0qgXa35+kX7HgINRYxTOYCwrYmz16ssVPwFbsMfTaWLq1qgcSdL6vJg4OQ+b7hWDbIfv+uKnccs/3yxFofUxOKRUMQguoq3YwDcpAW3PjYt4G6hbGj0AC8zJAqaQnjcHQBbFms3ZqqQnrKYSZH+ubsBwW7Ij8z5HEI1xh5kB/7n6r+LC4zrtRbRmjhYmVWUKQ+1s5cE5/nDQc4k/xR0SvAnuiH9Qs3XG/KlZceeHiq+jiwAPm+NY/Gt3+HnbgiLuBixZWQwVowCdmwMlkreNtinmKxpDoj41eJQZ6GzsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SJ2PR11MB7573.namprd11.prod.outlook.com (2603:10b6:a03:4d2::10) by CO1PR11MB4963.namprd11.prod.outlook.com (2603:10b6:303:91::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.15; Wed, 18 Feb 2026 18:31:00 +0000 Received: from SJ2PR11MB7573.namprd11.prod.outlook.com ([fe80::bfe:4ce1:556:4a9d]) by SJ2PR11MB7573.namprd11.prod.outlook.com ([fe80::bfe:4ce1:556:4a9d%6]) with mapi id 15.20.9632.010; Wed, 18 Feb 2026 18:31:00 +0000 Message-ID: <34871cc9-b90d-43ea-81c0-82f8cc0a2051@intel.com> Date: Wed, 18 Feb 2026 10:30:57 -0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/2] fs/resctrl: Add "*" shorthand to set io_alloc CBM for all domains To: Aaron Tomlin , , , , , , , , CC: , , , , References: <20260210210717.3866344-1-atomlin@atomlin.com> <20260210210717.3866344-3-atomlin@atomlin.com> From: Reinette Chatre Content-Language: en-US In-Reply-To: <20260210210717.3866344-3-atomlin@atomlin.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4PR04CA0378.namprd04.prod.outlook.com (2603:10b6:303:81::23) To SJ2PR11MB7573.namprd11.prod.outlook.com (2603:10b6:a03:4d2::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR11MB7573:EE_|CO1PR11MB4963:EE_ X-MS-Office365-Filtering-Correlation-Id: ccea7ee3-c8db-4e10-47de-08de6f1bdd6e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|376014|366016|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?YXI3SUtNc243UUV4amloWUpmc3g3c0ZWbXdab2dvcWdXTnoyTmdSV3g3S2Ir?= =?utf-8?B?clVlYjFXZDdjb0p5R3BBaFVuRWhwT05wNlAyS0xIakZ3dmJyRjlST2RRUXRV?= =?utf-8?B?YW1Uei9nbVhWWDNCQUFRYUZsNjVCVWlkaU1MYWxGanV0NmQ5Y1V3bTFvZElM?= =?utf-8?B?U0xtNGtLaU41WEhyS3FXR1VLOXo2MGVQVFBmbnI1eDZaUGEzNWtUL2E1Vmp4?= =?utf-8?B?UEpEWjl1SEtwVE9FSXlhTzFMbkdpL0pLQkJZTjBTVDBjL0kzNVkxOTdyUnRV?= =?utf-8?B?WHd6NTNlbVVZcm9MSnpaOUR6cVFqaXRTbThMWnNrOHlwRGVTMG5TOXZZOU11?= =?utf-8?B?aTU5K1BMTVNPd2RlbFRyYjJrVGlyK216SFlpdFZEODdXZEpOb0NlNVE0SnZy?= =?utf-8?B?UUdiYWEyVSthci9DcEdrZnVIMVN5NGlTVzNYU3M4WDFHZ2dGRWlKMzgyS1Z0?= =?utf-8?B?VUpROFdmMmRXMEs4UWdkcFovWFBUSm5WTmVQdEU1cEd0L0pXaXR3Y2xDWDE0?= =?utf-8?B?Y0J2R0loS2YvY3dZZ0VoMGNxajhTSk8vY1ZtZVhjbElvZGdtYUpZNFUvTGZC?= =?utf-8?B?UVJ3Q0F0UlZEWE5YWFZnUnJiRFJHUjV0UDByejJ6b2VRUEpGRmQ5bWVxTDNs?= =?utf-8?B?VHVlNVphUmJQdTZoSU5vU3VzaXo3OXBrU092M3lhUDZaTC8xWU1FcU5WUzFi?= =?utf-8?B?UUk1ZGtsb3JiUUc5WS9jOW04MDNoQnNPTk9aZ2gwUlhRZXBVeXdKM3VtK0ZS?= =?utf-8?B?KzJONVBGbHFJSlM1MmJ5WkhwalZ1TC9YYUt4RFRVeUZrZm1mOFRLcXQvVjM0?= =?utf-8?B?NFJjVVdULzFSZnFrbHRielJrOTJUdFBpTFJsRnB0V3Nic090MW1IUU9acXNI?= =?utf-8?B?OCtRZmtYSzBpUkkyVGJaaDI5WkY3NTNSV1pvWXJqYXl1T0J0SjU0R0pMUzk0?= =?utf-8?B?UFR6dmdIU1l6VUZkRUV0dzlhcnppMDRNL0c4aUwzM2E0WG1lOVJQUTIrQ1BZ?= =?utf-8?B?TlBoREp4dHNVZkszVnA2VXR5T0RFdVlJSVNwTFdPclFWWmVJUGpRYmJkVHl0?= =?utf-8?B?UjZlTDZWcElQQXJ6YlZRc1lQWUJoRGJiQnNwUmlaNEJVeTZMbXdRK1JycGlH?= =?utf-8?B?ckFlZ1hQNzQ2dHhoVWRibFg1UHpuM2FYRHF1eHpWSVdlbWhsK3g2aGF0VFVV?= =?utf-8?B?ZGU1VVZKUzFiSmJ5dlFwRFl1QTc4bjJWZXdRSkFHeHY0cTNHR3Z1TWRlRy9r?= =?utf-8?B?VnhzSUNaeUs4YkF0S2tIWCtZVzdqUDNHZ2ozellrNllDczhDcFlSZHVwdlM4?= =?utf-8?B?cDRzV3RQRGp6OFlUQ1pXa3JENGdWR2E0UXVTZjhaMjdzczRvZFpINHFBc1pl?= =?utf-8?B?MGgzZmV3bWtzLzZuMWhRa3hUMGtubkZZaGlYL1FIeG9kZnM3Tkc0SlNjVjhN?= =?utf-8?B?c1NLUDRGQ3dQRzM2VFJxRGJZV3VuUFM3U0FyN2lVdGM5OGZDYzMySXMzd2ZT?= =?utf-8?B?WmE3NnJRK21ocXY4VnJmRGdyNEJHcFUxMHo0akRTK25uRmx6TmNVUzlCQjNa?= =?utf-8?B?Zkx2bGJ1Y3UvMGhUUitlYlF6Z3d4bzNVWVJNQWVyMUFWMjJST2lscTRNUExG?= =?utf-8?B?RGZtWGJwd0NlNnEzOHdFYnhFUHBkZmp1QWdackJSK0lNdDZxY2JDSUw0b1Zk?= =?utf-8?B?VDJxaU5YZ05sY2hXelNOWVlTK0tGVkNNclRRRVFjYkgzYzlTSzRUMURzUnIx?= =?utf-8?B?TjlJTUFESk9tazJrQ3pndHVKRExrSkxzVndEcWcvUWVGSmpOazNEdnF6b2Rz?= =?utf-8?B?WkZQMmM0QzNIN0pIZEpIR2g5OUF0dWQ4T0gxMWNsQzlVaUJTUTNZYTlHVWN3?= =?utf-8?B?K016ak1waFVOdVF2R0cxTU9mR1hZM09Fc25HTWNzMjUwcFMzd1VCQVU3T2VN?= =?utf-8?B?dFNETm90eGFFWFczVzM3ZDFEc0t1SkJxaWliT25ES0tvOVErNFF1T2tRa3hV?= =?utf-8?B?RDFxRXdWWkhzQm92ME9CYVhOVklKU3h4Z2xFZWlmYkM5VWtpQ1ZQbjMwSFNs?= =?utf-8?B?ZFU2MWxGZitnNmU5dEs4aG5TRlVQQlVEK3ZxemRFL2Z1MWRFV05DYVQwR3BE?= =?utf-8?Q?A0xg=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ2PR11MB7573.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(376014)(366016)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZXNHdjNyRis2Z3dRK1IyZ1E3c09WbysrcC9JRk81WXhDMi8zc3Z1TSt2UjVo?= =?utf-8?B?T2dzbXNGS1ZkSnJlRVR4Q2wrbkFZWUFiaGdFcTJYckdKNEgyRHF3dHIxdm9s?= =?utf-8?B?eCtoYXE3OXVYMDZuM0QvUG5YcGhaMFNsdm1nakd2MDEveEhOOFZBeTNBQXZw?= =?utf-8?B?akZRQVBHM0RJVDFtK00yK1BsZ2p1SDdyU3ZtTWJJR28vcVdsOVdXMzNpTTNq?= =?utf-8?B?Z2xINjNWVGpyNERYVVpVQ2hoWm9Xa0hjcEE4MXVZL3ZWUlJHVGhoZVF6NFha?= =?utf-8?B?TnhuSlcwK3hOZi9YZCtXT3piWFFCSlQwQ0ttSC9talJqeWhYQkc0ZTlxVHZs?= =?utf-8?B?azZwdkM5dnhSUVNhUTU5cGlTNmF5eUFsSHFyY00zbGs4MzY2WDVGWGw3aVVH?= =?utf-8?B?ZTNZNGdHWDdlQ2tEUDhsVU5XTVZFTUFOOXQwWWhzWnpBQmlxOFhFdXE3cnJR?= =?utf-8?B?clI2TktJV2dHSnluMG5hUURVaC9FTGx5eGJ4aHNaUGhSdGJkV2t6OCtES2li?= =?utf-8?B?Z25IV3F0OWppRFFBZWdMMmlMdGV2MzJra3dabSt0YVhnU0ZxeThsVmsyTW1W?= =?utf-8?B?emdZTG4xUEZLQ3U5dlRBS25hZnlzWkZERnRqbDZtYW1NelZIdlRTamdOMXdV?= =?utf-8?B?QktTZU1JTUl5R1Z1TDBzVDNmeko5dmpqODEwa2dBcTcraGFMWnpXSSt4ZE9D?= =?utf-8?B?Y1cxaWRRWGI5bDJoN3ZZK3JhQnNQVTluR1lsK3lJSUsrQzY5MmpwMHhaYVhh?= =?utf-8?B?TUpYeUQ3b2hxaUoza0pDWEEzeGp6MmNDTWx2SmJaUWVsWmtVeW9CNUFZbG9K?= =?utf-8?B?aWdlWVlRanp2YnlVait1NWxtd3NodDR6NEJXbHZTNFBKMmxyWVhYZmtQRkQ3?= =?utf-8?B?SFZING9NcTNJMkFHZWhRTHZidlJKcklxdFNYUitFVjRkWmpjL0NGYThEU3ly?= =?utf-8?B?bFhGZjV6Z29UK2VBcG1WSytMeDJVYVRxYll4OU5SeXgvS2NKZkNIL1lXOWdW?= =?utf-8?B?dVU3djFqZk40VW5jRHNFcFpmbjRWRVNRbWJYTUlJMTNiY3grZDBMSGFOaU54?= =?utf-8?B?ZmhWMzlTNGRNQ2c5N3ZmMHpQaXFuajlGZUxuZkVmVjNxUWJqZi9xOVdYSlFW?= =?utf-8?B?dXVZRjJqNmI3YVd4VVI4RWk4SmUvSEdZZ0dMZEdiT1BjYkdrWGU4ZU9ETFEx?= =?utf-8?B?NkppVlV4azk3Rk9WVGJKTEo2Z3V2eFZaV04zZGx1azRieWdVRjhVUm53Ri9h?= =?utf-8?B?WWxQNFNpYitIWEl6c0RUSkN2OHgzKzVhVExjdjU0Mm9MVURkREswK2tRNmh1?= =?utf-8?B?SWNEWXI0Y0JBUWNJOXhCbEtFOWN4V09VVFZzd1JPWnBobTVjSHVpaVhUOEJF?= =?utf-8?B?OVNNa01aNjY1dnAwM21sTHROZTRISENHcXdTMzhITFBjd0sycHptT0pkSmVF?= =?utf-8?B?UDlsZUhzTWJaUGJYbXpxRFpiMGQ2czFXSXc0MHMyTmxlTkt6NGhNYmhyQ0ty?= =?utf-8?B?MVkrM3hURUFEUzZ4bG02Rkh4ZXl3QUdaeGpiMTdZSWJUMVJjNzJnellqbjZR?= =?utf-8?B?SWFobUJFSkttSlRuT00wSFZaZXdPbnl0bG8ySnBsUG5QUURxVXNhUkVGNzAy?= =?utf-8?B?aS9VUTJtallvd2pjZEtxUXkwN05xRDdUNlA2QW9vZXEvTlRmb3NjWmp5clRP?= =?utf-8?B?bUR2VThibjdXNk5ScXZNV2ovOVhBS1FyYm1sb1lGUmVncHFSTzZnRUczQjdy?= =?utf-8?B?RGE3djV3Zy93Tml6V2dOS2VTMDFtWmVrcVJrSDVhdkVjL3B3UnZRTEFQQXp2?= =?utf-8?B?OWtkSHJmRGtJZnNFQ2pXWWRRZGtPT2t4dTBKMDhrYWJwMnhpcjI1aUQ0UVhO?= =?utf-8?B?NUpZNmZYMlNpVTkzbEN5Zk1uR1RNYUQwWDZpem1zQzRBN044S0tYMGl0a3RE?= =?utf-8?B?OHE5N2ZrWXNPRGZ2OHpzVGJ0Y3NRaitCUTM2OTFid2JaK2k3YitFb2xwK2V1?= =?utf-8?B?Z0xjZVUvUmdleGY2RWQwNEdIUXZmS2RoN2dPRFdYcGFxM3hvbnpsbjVJdVND?= =?utf-8?B?K0xSbmZsOXVRUmFpWnZOTGtkMlVEVVVFako0M1NjdnRaTDdaZGdQVGRQSTcv?= =?utf-8?B?Q096S0JpQ3RiRHVWNEhoQWJCZ20yYnpHbTM4cFhQWldCQ3lyOXVjWFFUdVVI?= =?utf-8?B?YUNTUzdnaGVYYnk1eDF4bUJ6eDd6eGQzM05YYUFOTmZEUUlwT2NVNjNlNzBS?= =?utf-8?B?Q2l1dVV3aXVCbGNlZXZTWW5vUit6SjdpSFIwaGhJQ2JDYU0waUpDMFc2UzhB?= =?utf-8?B?VTRFR1Fscy84cjBBOGlxRXB1dm5BZEwxRGVBajIvY2pCOVk1dzRZQ0t5VFZX?= =?utf-8?Q?TpW0V7+f8yc7C/mo=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: ccea7ee3-c8db-4e10-47de-08de6f1bdd6e X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2026 18:31:00.4465 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /8dqNLHWQljXBt5V6RPU2aSiUW0chpiHRzXiDBxSDd7iNHalZn1vZbbu7DBSNa+McGw8dIFh9X6sfNwmlj6iEj20ffWb49m85yTo/xDuY5g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4963 X-OriginatorOrg: intel.com Hi Aaron, On 2/10/26 1:07 PM, Aaron Tomlin wrote: > Currently, configuring the io_alloc_cbm interface requires an explicit (nit: "Currently" can be dropped. Expectation is that the patch starts with context that is by default the current behavior.) > domain ID for each cache domain. On systems with high core counts and > numerous cache clusters, this requirement becomes cumbersome for > automation and management tasks that aim to apply a uniform policy. > > Introduce a wildcard domain ID selector "*" for the io_alloc_cbm > interface. This enables users to update the Capacity Bitmask (CBM) "update the" -> "set the same"? > across all cache domains in a single operation. > > For example, a user can write "*=0" to the io_alloc_cbm file to This example seems redundant. The description is clear and the documentation addition found in the patch describes this scenario anyway. > programme every domain with the same mask. The value supplied must, "programme" -> "program" I suggest to drop the last sentence "The value supplied ..." since it implies that the addition cannot do its own error checking. > however, remain within the valid range defined by the resource > (e.g., min_cbm_bits). > > Signed-off-by: Aaron Tomlin > --- > Documentation/filesystems/resctrl.rst | 10 ++++++++++ > fs/resctrl/ctrlmondata.c | 15 ++++++++++++--- > 2 files changed, 22 insertions(+), 3 deletions(-) > > diff --git a/Documentation/filesystems/resctrl.rst b/Documentation/filesystems/resctrl.rst > index 8c8ce678148a..948219e58882 100644 > --- a/Documentation/filesystems/resctrl.rst > +++ b/Documentation/filesystems/resctrl.rst > @@ -215,6 +215,16 @@ related to allocation: > # cat /sys/fs/resctrl/info/L3/io_alloc_cbm > 0=00ff;1=000f > > + Set each CBM to a specified value. Above sentence seems redundant when compared to below sentence that is more specific. Can it just be dropped? > + > + An ID of "*" configures all domains with the provided CBM. > + > + Example:: Just to make this clear I suggest to add caveat: "Example on a system that does not require a minimum number of consecutive bits in the mask::" > + > + # echo "*=0" > /sys/fs/resctrl/info/L3/io_alloc_cbm > + # cat /sys/fs/resctrl/info/L3/io_alloc_cbm > + 0=0;1=0 > + > When CDP is enabled "io_alloc_cbm" associated with the CDP_DATA and CDP_CODE > resources may reflect the same values. For example, values read from and > written to /sys/fs/resctrl/info/L3DATA/io_alloc_cbm may be reflected by > diff --git a/fs/resctrl/ctrlmondata.c b/fs/resctrl/ctrlmondata.c > index b96b661626c2..f47331a97337 100644 > --- a/fs/resctrl/ctrlmondata.c > +++ b/fs/resctrl/ctrlmondata.c > @@ -873,21 +873,26 @@ static int resctrl_io_alloc_parse_line(char *line, struct rdt_resource *r, > struct rdt_ctrl_domain *d; > char *dom = NULL, *id; > unsigned long dom_id; > + bool update_all; > > next: > if (!line || line[0] == '\0') > return 0; > > + update_all = false; > dom = strsep(&line, ";"); > id = strsep(&dom, "="); > - if (!dom || kstrtoul(id, 10, &dom_id)) { > + > + if (dom && !strcmp(id, "*")) { > + update_all = true; > + } else if (!dom || kstrtoul(id, 10, &dom_id)) { > rdt_last_cmd_puts("Missing '=' or non-numeric domain\n"); > return -EINVAL; > } > > dom = strim(dom); > list_for_each_entry(d, &r->ctrl_domains, hdr.list) { > - if (d->hdr.id == dom_id) { > + if (update_all || d->hdr.id == dom_id) { While this code is correct in that dom_id will not be accessed when update_all is true it makes the code more difficult to understand when an uninitialized variable depends on certain flows. > data.buf = dom; > data.mode = RDT_MODE_SHAREABLE; > data.closid = closid; > @@ -903,10 +908,14 @@ static int resctrl_io_alloc_parse_line(char *line, struct rdt_resource *r, > &d->staged_config[s->conf_type], > sizeof(d->staged_config[0])); > } > - goto next; > + if (!update_all) > + goto next; > } > } > > + if (update_all) > + goto next; One comment from v4 appears to be unaddressed. Copied here for convenience: I see that this aims to support input like "*=f;*=0" but I do not see how something like this can ever succeed since parse_cbm() stages the config and should fail if any domain already has a config. Should this perhaps just return success here? This could be made more robust by only returning success if there is no more text to parse, thus failing on input like "*=f;1=f". Below is a sample fixup that addresses the comments. What do you think? diff --git a/fs/resctrl/ctrlmondata.c b/fs/resctrl/ctrlmondata.c index 869e37f7d22a..9a7dfc48cb2e 100644 --- a/fs/resctrl/ctrlmondata.c +++ b/fs/resctrl/ctrlmondata.c @@ -954,17 +954,21 @@ static int resctrl_io_alloc_parse_line(char *line, struct rdt_resource *r, struct resctrl_schema *s, u32 closid) { enum resctrl_conf_type peer_type; + unsigned long dom_id = ULONG_MAX; struct rdt_parse_data data; struct rdt_ctrl_domain *d; + bool update_all = false; char *dom = NULL, *id; - unsigned long dom_id; - bool update_all; next: if (!line || line[0] == '\0') return 0; - update_all = false; + if (update_all) { + rdt_last_cmd_puts("Configurations after global '*'\n"); + return -EINVAL; + } + dom = strsep(&line, ";"); id = strsep(&dom, "="); > + > rdt_last_cmd_printf("Invalid domain %lu\n", dom_id); > return -EINVAL; > } Reinette