mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Garry <john.garry@huawei.com>
To: kajoljain <kjain@linux.ibm.com>, Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Ian Rogers <irogers@google.com>,
	Yao Jin <yao.jin@linux.intel.com>, <yeyunfeng@huawei.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Linuxarm <linuxarm@huawei.com>
Subject: Re: [PATCH 1/2] perf jevents: Tidy error handling
Date: Thu, 22 Oct 2020 10:43:48 +0100	[thread overview]
Message-ID: <348855b5-d109-3e30-a669-d4e2c766ad30@huawei.com> (raw)
In-Reply-To: <7e7c5aeb-5c9b-727a-d605-e871007af34a@linux.ibm.com>

On 21/10/2020 14:37, kajoljain wrote:
>>> May be we can use similar checks:
>>>
>>> if( verbose)
>>>     pr_info("%s: Error walking file tree %s%s\n", prog, ldirname,err_string_ext);
>>> if(rc > 0)
>>>      empty_map = 1;
>>> else
>>>     ret = 1;
>>>
>> Not that it matters much, this logic is slightly different for verbose set and rc < 0. I don't mind going with that, so let me know.
> Yes right. Sure if required we can made changes on these checks and include appropriate condition for verbose set and rc < 0. Seems fine to me.

I will just revert to the original logic for now. Someone can try to 
change later if they want.

Thanks

  reply	other threads:[~2020-10-22  9:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-19 15:38 [PATCH 0/2] perf PMU events test: Add scenario for arch std events John Garry
2020-10-19 15:38 ` [PATCH 1/2] perf jevents: Tidy error handling John Garry
2020-10-20  5:43   ` Namhyung Kim
2020-10-20  8:14     ` kajoljain
2020-10-20  8:35       ` John Garry
2020-10-21 13:37         ` kajoljain
2020-10-22  9:43           ` John Garry [this message]
2020-10-19 15:38 ` [PATCH 2/2] perf jevents: Add test for arch std events John Garry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=348855b5-d109-3e30-a669-d4e2c766ad30@huawei.com \
    --to=john.garry@huawei.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=irogers@google.com \
    --cc=jolsa@redhat.com \
    --cc=kjain@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=yao.jin@linux.intel.com \
    --cc=yeyunfeng@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome