From: Arnd Bergmann <arnd@arndb.de>
To: Karol Wrona <k.wrona@samsung.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH v2 1/5] misc: sensorhub: Add sensorhub driver
Date: Fri, 21 Nov 2014 20:38:25 +0100 [thread overview]
Message-ID: <3489864.y2krC9T9rK@wuerfel> (raw)
In-Reply-To: <1416593957-19788-2-git-send-email-k.wrona@samsung.com>
On Friday 21 November 2014 19:19:13 Karol Wrona wrote:
> Sensorhub is MCU dedicated to collect data and manage several sensors.
> Sensorhub is a spi device which provides a layer for IIO devices. It provides
> some data parsing and common mechanism for sensorhub sensors.
>
> Adds common sensorhub library for sensorhub driver and iio drivers
> which uses sensorhub MCU to communicate with sensors.
>
> Signed-off-by: Karol Wrona <k.wrona@samsung.com>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> drivers/misc/Kconfig | 1 +
> drivers/misc/Makefile | 1 +
> drivers/misc/sensorhub/Kconfig | 13 +
> drivers/misc/sensorhub/Makefile | 6 +
> drivers/misc/sensorhub/ssp.h | 279 +++++++++++
> drivers/misc/sensorhub/ssp_dev.c | 828 ++++++++++++++++++++++++++++++++
> drivers/misc/sensorhub/ssp_spi.c | 653 +++++++++++++++++++++++++
> include/linux/iio/common/ssp_sensors.h | 79 +++
You seem to provide infrastructure for other drivers here, so I don't think
drivers/misc is a good place. Have you considered making this a regular
mfd driver? If that doesn't fit, is there possibly some place in the iio
framework for this kind of driver?
Arnd
next prev parent reply other threads:[~2014-11-21 19:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 18:19 [PATCH v2 0/5] " Karol Wrona
2014-11-21 18:19 ` [PATCH v2 1/5] " Karol Wrona
2014-11-21 19:38 ` Arnd Bergmann [this message]
2014-11-22 12:17 ` Jonathan Cameron
2014-11-24 11:39 ` Karol Wrona
2014-11-24 12:35 ` Arnd Bergmann
2014-11-24 13:04 ` Karol Wrona
2014-12-03 23:12 ` Hartmut Knaack
2014-11-21 18:19 ` [PATCH v2 2/5] sensorhub: Add sensorhub bindings Karol Wrona
2014-12-03 23:14 ` Hartmut Knaack
2014-11-21 18:19 ` [PATCH v2 3/5] iio: sensorhub: Add sensorhub iio commons Karol Wrona
2014-12-03 23:19 ` Hartmut Knaack
2014-11-21 18:19 ` [PATCH v2 4/5] iio: sensorhub: Add sensorhub accelerometer sensor Karol Wrona
2014-12-03 23:29 ` Hartmut Knaack
2014-11-21 18:19 ` [PATCH v2 5/5] iio: sensorhub: Add sensorhub gyroscope sensor Karol Wrona
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3489864.y2krC9T9rK@wuerfel \
--to=arnd@arndb.de \
--cc=b.zolnierkie@samsung.com \
--cc=jic23@kernel.org \
--cc=k.wrona@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®