From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f48.google.com (mail-oo1-f48.google.com [209.85.161.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 351E7337693 for ; Wed, 15 Oct 2025 16:29:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760545771; cv=none; b=EMFoW/PslPDcrHDY1iAFVnwcNuVfYGsYEWa409+BVQCAldJYfDHfkfpWCe12avPM7JFD7I42mYmJL3DA48U6+RMsbLKBVGo4g0144tNX7tSww/+D2MQLLHBm96ioX7kInQ6SdGWn2dqqkQ2BQSfRjfSmc9mBg3Rd+YgR9YX8TaA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760545771; c=relaxed/simple; bh=c9DRtgxqBjR6FiucDGOUiESyKrgNeSaMO5VAfOIoETQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qDGHiJpaQ8q4bcup7fIwqlBuMBnIrDh1tXUoFED5T5oB77irlwMEKIKPdTghZ7xfyYoW50Hj9o9xFehBRDG7pXjhS5j7rCVjXLLtS96Sy1YGcJ0ZzvubtzTHVOE8uISUHkpK3UHcreoUa14fzzaK9KRKdda6CltOG3asGspsC5Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=FHruKKaT; arc=none smtp.client-ip=209.85.161.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="FHruKKaT" Received: by mail-oo1-f48.google.com with SMTP id 006d021491bc7-61bd4e002afso1830103eaf.2 for ; Wed, 15 Oct 2025 09:29:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1760545768; x=1761150568; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0IEFETDXO+bjt4XRF9cGd360VMY2ffLoA1X5D7REdqI=; b=FHruKKaTe52nmQ4G4l2uekHbzSAu7GrvHbxeuiVOMqqu89gEJBxz+EmLF1580OOrS6 6JXbLlsdBpqxhvpQbeNz8ylCyEItkACEzkBEXeAIGmc6Ra7MNWNtOiBxekFi+2xfYCf4 dr7QyH9GxXE9vY6P+3VJ+k6tFhVJ3KIX7Oa69CQb6Pz18lCB+J2K86XN+Q3ttVaYNHyp lc+F60ZrhSW3UXCR4TzWkt9caIOUoqA0SMwGD2OW6d61b6N8hLFiW4JLySkM5TBNDuOZ gPCBkNw1xdqa4+Vrj3VALh0hQ2bLpscLep18CE8XZD67YF8eGFDgq6uZYnzkDtQZj19D OSPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760545768; x=1761150568; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0IEFETDXO+bjt4XRF9cGd360VMY2ffLoA1X5D7REdqI=; b=B7Q6CU4n9aWW5gqoxf49hsObax0UfC4mnid4wGsC7QT3R36OXQyRKsV9cIhz4Ss05K 23DZkAl7Cmcxiy5/N6KfGfY0sOLQr+23UaWxUofgV7CkTGkK/U0uaYjpXM9NraR9j2q8 BEixbueV4vmtwyy+gD5fsjwz4z6i5h5AJ5lbdQRl/UFyUEPkg9kohcazS3KKimuxt+6S bY+GF/1M+lGbtg1tJQuZRIhXMdG+0nHOitp2DsAvM6Ig8RkDl7JqlKZSGvWs8LNtQAxY 3pOL9GYyE+kBXrk0tCrvX0IJss+KXWUwG8qvMTA0jmGr40mlLtk+EvDc9AZora2tzQV6 K7Cw== X-Forwarded-Encrypted: i=1; AJvYcCVrqRqm05DDBsu0rDDtpXkDDZZNSxWb+YijI5YQ73m1qV8en/CKL333mFgKXgSJy/bIbg6kQmP0JRKGq7A=@vger.kernel.org X-Gm-Message-State: AOJu0YyqdHzVS+hsl5oZO4nIapkd7dhbZ9Fh7kK/auVHMr636M0NU39Z AowtxaLB4rf93LaKmhxb2hrxBiwE0BlqOYZ7F3u/3VY6+lXEGcOdgR4V02MXuoFPSGA= X-Gm-Gg: ASbGncvoUlsf4hsRm3c+7fWJyjCSi6V/agDSgM61f844qII8320TNUq9XBxxeB+5vUY m5FwEKUFFL3ua1kCEkT2hXrqCuNT4QM4VfkrqqwNjoQWIAa+tppcBOP79S23teqsDxA+sk2SKZI PkpLg4/QIzUGa/x066smxLtIMlLYBMf6zUlOGM4IUoyOE5mS1ZOYs1008jObwwsuDK//Q3w/Hpt gLsoqZrEA6I54XikHe1OXn7I0cKoT46jbQehknOnsujpF12Fo3wsj7S74CnELr+Tel9WgLo+bA7 2cPWI7MWVAMAOLSFCQrb5Nigor4Q5YKb3CqyKb9c+9AaeRzHboCf77pPZMvqkoAbJBmmk7LjRi6 BQ3lVV2Dp3PwtW4BTtfwVdGIEkY6uANZA88S59VDW6UYBgV98xO5JH8w2zYCNmpGlPrlXdylxNK BQ39zNHyZEDvlUCMjkL92XDEQVpaPPvwEoiPoH X-Google-Smtp-Source: AGHT+IF+cLJe80ed4cj3kfbQheauCbstntwHjsgvv5HQx7cBnV+AHE/HMRPi8SW58d1ZXb7hcVX00w== X-Received: by 2002:a05:6808:14c1:b0:439:ad1e:8485 with SMTP id 5614622812f47-4417b38c9e3mr13965693b6e.24.1760545768107; Wed, 15 Oct 2025 09:29:28 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:c482:1912:c2de:367e? ([2600:8803:e7e4:500:c482:1912:c2de:367e]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-650181ff660sm4189888eaf.17.2025.10.15.09.29.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Oct 2025 09:29:27 -0700 (PDT) Message-ID: <348b0d94-4b3a-454d-be67-47563808ec76@baylibre.com> Date: Wed, 15 Oct 2025 11:29:25 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/6] spi: axi-spi-engine: support SPI_MULTI_BUS_MODE_STRIPE To: =?UTF-8?Q?Nuno_S=C3=A1?= , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Marcelo Schmitt , Michael Hennerich , =?UTF-8?Q?Nuno_S=C3=A1?= , Jonathan Cameron , Andy Shevchenko Cc: Sean Anderson , linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org References: <20251014-spi-add-multi-bus-support-v1-0-2098c12d6f5f@baylibre.com> <20251014-spi-add-multi-bus-support-v1-4-2098c12d6f5f@baylibre.com> <3180475bd51e1e057d6aa7e1b62f564cb57a117e.camel@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: <3180475bd51e1e057d6aa7e1b62f564cb57a117e.camel@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 10/15/25 5:30 AM, Nuno Sá wrote: > On Tue, 2025-10-14 at 17:02 -0500, David Lechner wrote: >> Add support for SPI_MULTI_BUS_MODE_STRIPE to the AXI SPI engine driver. >> ... >> + >> + if (xfer->rx_buf || xfer->offload_flags & >> SPI_OFFLOAD_XFER_RX_STREAM || >> +     xfer->tx_buf || xfer->offload_flags & >> SPI_OFFLOAD_XFER_TX_STREAM) { > > I'm a bit confused by this condition. It looks like setting priv->multi_bus_mode > (and the other fields) only matters for msg->offload but the above will be true > for regular rx/tx messages, right? Or am i missing something? You are correct. > > If so, I wonder why doing this for all transfers if we only care about > multi_bus_mode for offload messages. I guess you want to validate > xfer->multi_bus_mode? Yes, this is important to validate it since we don't support all possible modes. The mode still applies to the individual xfer even when not using SPI offloading. > I would then just take the switch() out of the condition > (I mean trying to setup a no data xfer with an invalid bus_mode should also be > seen as invalid IMO) and then use the offload conditions (or maybe simply msg- >> offload?) for the multi_bus_mode handling. To me, it makes the intent more > clear. It the validation only matters for xfers that send or receive data. I guess it doesn't hurt to check the mode in non-data xfers (e.g. ones with just a delay) but since we needed the condition anyway for the accumulator, it made sense to me to put it inside the conditional. I might have put an additional if (msg->offload) around the accumulator part since it only matters when using SPI offloading, but the indent was already getting quite deep.