From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751676AbdFGKjW (ORCPT ); Wed, 7 Jun 2017 06:39:22 -0400 Received: from fllnx210.ext.ti.com ([198.47.19.17]:47711 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751414AbdFGKjV (ORCPT ); Wed, 7 Jun 2017 06:39:21 -0400 Subject: Re: [PATCH 3/5] mfd: tps65217: Add a dependency on OF To: Lee Jones References: <1496760340-27959-1-git-send-email-j-keerthy@ti.com> <1496760340-27959-4-git-send-email-j-keerthy@ti.com> <20170607103753.n3entu2ylxvhdax7@dell> CC: Enric Balletbo Serra , Tony Lindgren , , "linux-omap@vger.kernel.org" , linux-kernel From: Keerthy Message-ID: <34936b6a-80f2-c8c4-f7ea-ad64d50d5ae5@ti.com> Date: Wed, 7 Jun 2017 16:09:14 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170607103753.n3entu2ylxvhdax7@dell> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 07 June 2017 04:07 PM, Lee Jones wrote: > On Wed, 07 Jun 2017, Keerthy wrote: > >> >> >> On Tuesday 06 June 2017 08:34 PM, Enric Balletbo Serra wrote: >>> Hi Keerthy, >>> >>> By change I was looking at this. Some comments below that I think can >>> be applied to all patches in this series >>> >>> 2017-06-06 16:45 GMT+02:00 Keerthy : >>>> Currently the driver boots only via device tree hence add a >>>> dependency on OF. >>>> >>>> Signed-off-by: Keerthy >>>> --- >>>> drivers/mfd/Kconfig | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig >>>> index 75b59f1..2d1425d 100644 >>>> --- a/drivers/mfd/Kconfig >>>> +++ b/drivers/mfd/Kconfig >>>> @@ -1297,7 +1297,7 @@ config MFD_TPS65090 >>>> >>>> config MFD_TPS65217 >>>> tristate "TI TPS65217 Power Management / White LED chips" >>>> - depends on I2C >>>> + depends on I2C && OF >>> >>> Shouldn't you add || COMPILE_TEST here ? >> >> Sure. >> >>> >>>> select MFD_CORE >>>> select REGMAP_I2C >>>> select IRQ_DOMAIN >>>> >>> >>> I think you can remove the of_match_device checks in some drivers too >>> >>> i.e: >>> >>> http://elixir.free-electrons.com/linux/latest/source/drivers/mfd/tps65217.c#L330 >> >> Yes that and removal of unused i2c_device_id. I will follow it up once >> this OF dependency is in. > > The of_match_device() checks should be removed with the OF patch. okay >