From: Randy Dunlap <rdunlap@infradead.org>
To: "Christopher Díaz Riveros" <chrisadr@gentoo.org>,
"Tom Lendacky" <thomas.lendacky@amd.com>,
mingo@kernel.org, akpm@linux-foundation.org, tglx@linutronix.de,
keescook@chromium.org, lauraa@codeaurora.org,
rostedt@goodmis.org, mhocko@suse.com, tal.shorer@gmail.com,
viresh.kumar@linaro.org, lokeshvutla@ti.com
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH-next] init/main.c: make local symbol static
Date: Thu, 18 Jan 2018 15:35:04 -0800 [thread overview]
Message-ID: <34989256-cac4-05ed-5b74-53a956b89eb2@infradead.org> (raw)
In-Reply-To: <1516318407.2510.76.camel@gentoo.org>
On 01/18/2018 03:33 PM, Christopher Díaz Riveros wrote:
> El jue, 18-01-2018 a las 16:31 -0600, Tom Lendacky escribió:
>> On 1/18/2018 4:09 PM, Randy Dunlap wrote:
>>> On 01/18/2018 02:06 PM, Christopher Díaz Riveros wrote:
>>>> Fixes the following sparse warning:
>>>>
>>>> init/main.c:167:12: warning:
>>>> symbol 'envp_init' was not declared. Should it be static?
>>>>
>>>> Signed-off-by: Christopher Díaz Riveros <chrisadr@gentoo.org>
>>>
>>> Does the kernel build OK after this change?
>>>
>
> I built it a couple of times before sending the patch, now I compiled
> it again and everything went ok.
>
>>> What about the other user(s) of envp_init?
>>
>> It looks like it's referenced in init/do_mounts_initrd.c. Rather
>> than making it static, it should be declared in .h file.
>>
init/Makefile should give you a clue.
>
> Ok, I'll try to figure it out, akpm accepted the patch in mm-next but
> was dropped because of testing failures. I'm still very new to all of
> this process.
--
~Randy
next prev parent reply other threads:[~2018-01-18 23:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-18 22:06 Christopher Díaz Riveros
2018-01-18 22:09 ` Randy Dunlap
2018-01-18 22:31 ` Tom Lendacky
2018-01-18 23:33 ` Christopher Díaz Riveros
2018-01-18 23:35 ` Randy Dunlap [this message]
2018-01-19 0:31 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34989256-cac4-05ed-5b74-53a956b89eb2@infradead.org \
--to=rdunlap@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=chrisadr@gentoo.org \
--cc=keescook@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lauraa@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=mhocko@suse.com \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tal.shorer@gmail.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®