From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6F393EF0C8 for ; Fri, 31 Jul 2026 13:22:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785504160; cv=none; b=DL3Hva5yWbbcqATOqyVU9V1DyNJgZYVIVvjuTjrc7jPIJR/8Uut/Q+wAthZp5xh6KtgWeYEh0GiqHk9jb9Ll/FyrJIZ1YU6hlQYNHk/4/EWnhblnpgMaUSI+IhpxjLF15DglSqNClrylaheLiKmi5egxHxP28t6hCq+dEV1dsg0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785504160; c=relaxed/simple; bh=uuo89+sAtKtyJaPS4V9rNIjPQmeUr9B7tn/iPGDAsbg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BybXjX1FDXyS3WZmYEguPaQ9TD4PI5M1sg290ZUI0BXTSOhadEhxF0NRULbl5BJz3gtqOI3TLUaEqmc0FZ4/nvoytxg+RQP6QYUEp3MH6LML0aRui6OwJO6trc/HND7ka6RvTv88iIT2JSLTiIBoILsQZj7Eyestqfi3ZB/Vfo8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AYF4gbzA; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MVMjiSKF; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AYF4gbzA"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MVMjiSKF" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66VBjwob4055038 for ; Fri, 31 Jul 2026 13:22:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= v+9qjsOSKXBQy8fGWCIsCrOpr3B6XcgBZrg078GxUsY=; b=AYF4gbzAlx2+5pWP UCsAFA9KAm9t1IY/bhHWSy0pT0/7pqVfjP/h/VN2f5SEhaeebEeWqnsmiUtqS0Xk llekquycx4Zalnc2uTsNorHi+T1+Y87HYc5a/T4gHNePogc56F2ZJ5kdsQ2SXSw3 2T2TZ74706nU8VOh+f97wuGPiiPWgndMLlarDYH/FyNn8Gn0ccujkF3AeD8F08wd vxerm1UDTMeLa/v0nA0X6OulBlJinHr+kubgPc9uOaIg/9RY3VmtQ2sOhMPnwZGG HqCDT75yycY4dbVJDJns5o7mesOWd6sQeCE9obPPlm25QvvxNIElRnHTmNztmO9I UXq0SA== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fru480apj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 31 Jul 2026 13:22:37 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2cfbf3e4a63so26827905ad.0 for ; Fri, 31 Jul 2026 06:22:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785504157; x=1786108957; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=v+9qjsOSKXBQy8fGWCIsCrOpr3B6XcgBZrg078GxUsY=; b=MVMjiSKFzWt5zZsNc7PPWTuwWrsE5alsvRGEdNIzfXxNz32pNsK5vmIaqlFjmLIaps XcKJYzEVabxjCK0XpdN0b2RWpCkDWkr65qgErjmcQAZg4AkYZfCr8Zz+frSrvlAsaokQ PEOWO0WriNaxPip0k5FdvA9fvKtunhM02wRrHeGC3l4MHdImcbP8/LKsKhatJG7zLl98 CEXoUqe0H6XuIwHzZbpNwSDQAp/QgOIWvj5RU7M/PleJepJ480SK5UgZkIUIwdulu/6x 5W4ung6/R3Tz1PEYy7EKprn58iLUzOmOpT5iSBIIknYMQ/wf+ZbnsS8SRhw9NJZ1WiEl xcMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785504157; x=1786108957; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=v+9qjsOSKXBQy8fGWCIsCrOpr3B6XcgBZrg078GxUsY=; b=at74peSgFCiQ78LBHPfkh/gy8jSFasxd9qfP5XYALAHnSbFyx3O+uusaEfPgSdV3qY XEsefo+03gxI4ZlsKKye1uUClNlLucXN2w6KJcGZd6cmRa+lgu5uT9NjnS31iOZCH6+g 0ps2xv+u15qeUI+EHxeLF/czODGAv8U5Ec2SdR3xea9HNmNAU1J9uDB6sY6GiGbwkY4H fFOIxVrSQC0rYwATDKbQfx3F44Ad2mx4Ed02IeAgkVU5WWh9OXEufsBPByuWP/Yfv263 bHPGf4ngAuoAsNdkWzCBI1cggukuFtls8xiTwfvyn7svmFFfLc8P+D4ie4aqZfZIAsCq BVDQ== X-Forwarded-Encrypted: i=1; AHgh+RoHcAoI2akLWqR+5TXDFBbelSv2yhbdwXm9JD3QBqMDLz38pIH5EoxWFCJtCFp4vMViOj6m82LwVVblR5M=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+8LRt/j21JN93Vq78E8y8phNza80R+lzwh9852/nvTSYJ7Y1j /jNk6IgHNteDDr6FprTIhOZGG0ytwcbQ39k9RBjH5eqyClPnHfwIC1Fr3xVXm62smQq5kYP9A/K OtVyTDwlrRJbVvRmgrHmfxTKtPLeVxUPt0OAlrdg+WRiaLjm5y8jrAISzZp6V7H/DYDQ= X-Gm-Gg: AR+sD10XYk/bp13jQBM836rWhrOmMMWlW3nW4U20XMKaLO+LpyzxLFmm6LFcSF74UIu J6ih+y6UOLb+pn0tK+yJc/FUOa5pPPucrtStexFCQC5T6ZS22V21vDX8xd+UFn+K6Z90TZd4Soz i4/w8SWKCVWmpI6SLoAxiwHh9zrbd+uS9D0ZMxacj6C/TbiMGJfAZDqskdnmPnfD8YxUvYMn1wh uU5k8K7XxH7I4NCPbOWfK2EkF5LMoqHs4P6TWucAbF69vLUVMBBSx0laLH/x2pIRbjeJGcttLVb FcfcBhqb85tzqxX3kSAtoFWvKkLlz1TywQ2/bKwu5LB+F0Xts7FeF/5b0ltafictxrzrtQC7Zwy 8hgyesIq+BCthrgbPb07/wRQ5UwAnxDo= X-Received: by 2002:a17:902:e84d:b0:2cf:84bb:1ebc with SMTP id d9443c01a7336-2d0521e9e05mr385205ad.15.1785504156901; Fri, 31 Jul 2026 06:22:36 -0700 (PDT) X-Received: by 2002:a17:902:e84d:b0:2cf:84bb:1ebc with SMTP id d9443c01a7336-2d0521e9e05mr384975ad.15.1785504156518; Fri, 31 Jul 2026 06:22:36 -0700 (PDT) Received: from [192.168.1.16] ([106.222.229.34]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d04ae19ecfsm5401795ad.10.2026.07.31.06.22.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Jul 2026 06:22:36 -0700 (PDT) Message-ID: <34998a81-864e-42fa-904f-2e5f3490fcf3@oss.qualcomm.com> Date: Fri, 31 Jul 2026 18:52:24 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 9/9] arm64: dts: qcom: hamoa: Enable CDSP cooling To: Stephan Gerhold Cc: Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Daniel Lezcano , Amit Kucheria , Konrad Dybcio , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Manivannan Sadhasivam , Kees Cook , "Gustavo A. R. Silva" , cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-hardening@vger.kernel.org, manaf.pallikunhi@oss.qualcomm.com, Dipa Ramesh Mantre , Dmitry Baryshkov References: <20260731-b4-qmi-tmd-v7-0-3befd44403d5@oss.qualcomm.com> <20260731-b4-qmi-tmd-v7-9-3befd44403d5@oss.qualcomm.com> Content-Language: en-US From: Gaurav Kohli In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=IJsyzAvG c=1 sm=1 tr=0 ts=6a6ca19d cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=x3UvaR+l8cLCJ1uKBUlNag==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=mOqVw97Yt21F7phKvS8A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzMxMDEwMSBTYWx0ZWRfX2dJ/9ACFSq4u bF20XHEFht0q5pWIhoaClLV2jwQs5o84sAMRgZTgSj/CptR4BcGQiWzYyJEvTwpU6PyagoFCJfc Rm2uZCeJG+0HjsKnjkeoIfiUyuVr49Q= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzMxMDEwMSBTYWx0ZWRfXzwumKA1AviBj der0Dvh2F/mJ2Q+7BBXwUCTgxeTzLhDZjb530T18XP61TWASk8RdDPShzHCfHn8FGW4dPk5Spjb njp+BczOwIORTjSey+ryiwjIVYGLDsSujH3eVGBNZVESDnUFrHJIwwwrUdF75kc6QJAbDynwFuG P0FaZnBvdR+QtSB4dHAz5tECcSRJj2P5m51ODiMQ8nau1hdLoEfToibjMxsNUncwUebLWp5zRoS KyI8VnjT07g6vg7wHsdE/wwmaUAXtTeu0dXrWEHHxTeHm/0GuzSKRO3bjJ4sxxxMB8sWx1voGAs tUdy+RCFKzq900EukQyoRn9/Mag3CHSa3eSHJzBAQogYp7HY+92OhbypEpIsQMiwtdBxB7YYKmd jcY9JFN35G5Dy7+pMfFKwtdr6Upl91WJrOM3lNmDbofQiwALGsB2XUDfDA2mYjloEQOL1rtLSry r/eYjgTLAAWACPMNJLQ== X-Proofpoint-GUID: yUHr2w_1TK7WJoM89wQjywLb-wY-8T3T X-Proofpoint-ORIG-GUID: yUHr2w_1TK7WJoM89wQjywLb-wY-8T3T X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-31_04,2026-07-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 adultscore=0 clxscore=1015 lowpriorityscore=0 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607310101 On 7/31/2026 4:50 PM, Stephan Gerhold wrote: > On Fri, Jul 31, 2026 at 04:03:49PM +0530, Gaurav Kohli wrote: >> From: Dipa Ramesh Mantre >> >> Unlike the CPU, the CDSP does not throttle its speed automatically >> when it reaches high temperatures in hamoa. >> >> Set up CDSP cooling by throttling the cdsp, when it reaches 95°C. >> >> Add polling-delay-passive so the governor periodically evaluates >> the zone during passive cooling and steps up cooling levels when >> temperature stabilizes below the next trip. >> > > Would be good to mention why you are treating hamoa-iot-evk differently. thanks for review, will add the reasoning. > >> Signed-off-by: Dipa Ramesh Mantre >> Reviewed-by: Dmitry Baryshkov >> Signed-off-by: Gaurav Kohli >> --- >> arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts | 32 +++++++++++++++ >> arch/arm64/boot/dts/qcom/hamoa.dtsi | 63 ++++++++++++++++++++++++++++++ >> 2 files changed, 95 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts b/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts >> index 9fa86bb6438e..a146be1cb5fb 100644 >> --- a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts >> +++ b/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts >> @@ -1684,4 +1684,36 @@ trip-point0 { >> }; >> }; >> }; >> + >> + nsp0-thermal { >> + trips { >> + trip-point1 { >> + temperature = <105000>; >> + }; >> + }; >> + }; >> + >> + nsp1-thermal { >> + trips { >> + trip-point1 { >> + temperature = <105000>; >> + }; >> + }; >> + }; >> + >> + nsp2-thermal { >> + trips { >> + trip-point1 { >> + temperature = <105000>; >> + }; >> + }; >> + }; >> + >> + nsp3-thermal { >> + trips { >> + trip-point1 { >> + temperature = <105000>; >> + }; >> + }; >> + }; >> }; > > Please avoid overriding node values like this... One quick rename of one > of the involved nodes and this will be silently broken without compile > error. Nowadays dtbs_check will *probably* catch these, but if you > override values using the label reference you would notice it > immediately when compiling. > > All those nodes already have a label you can use: > > &nsp0_alert0 { > temperature = <105000>; > }; > > &nsp1_alert0 { > temperature = <105000>; > }; > > If the same pattern is already used for other thermal overrides in > hamoa-iot-evk.dts, it would be good to prepend a patch to fix those too. thanks for review, will update this. > > Thanks, > Stephan