From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69EBB30596D for ; Fri, 13 Mar 2026 09:46:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773395182; cv=none; b=CMJt7Z+svNppGHrCzKEm59Ag4r/3w7VbRFvduADzoljPFCSn3bqkjXjdNhzZ8d6ErYMVlqNJx+3S3mmFhkCqmrDm2H+SkGBhkcnfY+FhbjdyrRKL34gUv94HxGv6Vb/mbkmfyg/mBqGReyqJYtt3dsVsxedzebgDispLHaYRJ2o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773395182; c=relaxed/simple; bh=soLnDKoEbEBzJ/46UuD6ujTKl9ZMRtSiLKjg0+glaPY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ax8N8uf7kDtvSfY8uZRzADVls2PpdoqS/ewykM2X+LjejLSzK1dx0K6WICBHZGeN3XBgCXGa/P8Jbq2zqQFU8WVF9YCXtWdOowor5hiSm6K9D4NObhG4GwWiKr+yTbRDkteA/+oEjo+M1iitQkMslPcr25YtUCJZLqp2zweTgRQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=xP/U7Msf; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xP/U7Msf" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-439b94a19fdso1845828f8f.0 for ; Fri, 13 Mar 2026 02:46:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773395180; x=1773999980; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DODGloFIP1eZNq44RxnWC9Eej94b0U2AuyYB0RlreSY=; b=xP/U7Msft9Yu93D88XJT5JC30JgEC2QErZxsKTL3HQiSx43LsD+VeRLVffxwjgP0rF OT2W0k6MI5hzwJJ1ZmwcdWvttx5SEKjudAaXlxJGOfzLFTbdgEFKbCvfUTMaxGJP445R OJToSLB6K4x+xsYe1HU0V47Mnho9Bpeop5jNGdvFrs00uFXOv+c/PWJzBinDDFMoCdyE WDEcqQZVc8upzJCCzpwP7sp4lj4AEjGXHgy11tffyIlMfWfMAK+NWsqiTsAqqwm6zxV3 z5x7odWLJzdqaq+1VW6QbVnbTes8nFnaiepF75g4C1RAF5nfUeF7YlW5hHSirkDYr15F T0OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773395180; x=1773999980; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DODGloFIP1eZNq44RxnWC9Eej94b0U2AuyYB0RlreSY=; b=C/r+M4UwnmfbESoyFJNdKtvkQcjKHDedteWyCrxKCCciv/OtDOedN+9wvhgJuVP5lA qdYqs6OuWDHLF5G1y6Z1MZTf0g+/2kQndb1lin8FLXrRuIfqVo2pd1t/496kWDwWT3mg 43Z36LarHPTvbdlAjuwax8qjfvfRHnvFyrr7hDtQG4VyCvklE6XC+avk8RY6fN7bk7Yu d8sBbb/DnTUCUpogFaMo2gRpvyAXrqn0AE6+1exJDbk/0nRVDwuvihp3iw0yXhdqsv+3 eMD3TZA1dpxYjTwaZrlfyMUF9+FE1YE3V0T7j7cjHfNoLuvmdTwcnLyxoslp8zRyNavw tC3A== X-Forwarded-Encrypted: i=1; AJvYcCWYY6cMogn9NsyNueNKSxkN57O6jSLUvEi+S9yDT7Oogo+JeLwk4uimf3S2UF/HylI0l4zUsqS7E4ng1O4=@vger.kernel.org X-Gm-Message-State: AOJu0YxwUStpqjYm+rxMWAmcBrReXnpkQJH+mO8u4oCUHmEsXnh1EZpj VqZMbAKJMtu7hg2LSuM5Z9pkSzyrGIXyzNDf1oY8aulNjPNWQIpgCPALfUFpkdfB078= X-Gm-Gg: ATEYQzx95IfBDVD2JHb3jvvR/hVUYm0pbeNEFk8yxHwkl8mpEBwZvAcA1NWmJ/T3Xxn jrVaq48VN0VB0JAdxWvuLmeGmjbZBe69Iftyt7YLEYtBVmt87gOsRtdFgWjO7B92KKmU6dnmDzA QUc5E2evIILQ1kqD4t8ls2Z36hWmjnM/NWZQFR90MEGub/uMKznaH19u3heXoXw10dL3Jn+0+DA pKWHhu6UYP4o1+JVKjojovEPrex17/ZoZGeS6rmrsiGbWv36+a4kv8nEETsKAWmzrCWqQ0502ud pVPubYcyH9WuMYYa7K5CTdzgRjbEyF8DGrICFean6lZqzPbobbRUzI3bINHHYUHqkXtrZ3m03+d kZP1/6uhIZBHHR9NG1NoQkApTkV/Xxa61oqmJNuyDacRHEodLrmpE92pDScuhf1NhLcM1C1hOQO pWXNSPwd0puzhEYA4wijtYpxA33UeOylvm6A4q5/uXMK8wx30= X-Received: by 2002:a05:6000:310f:b0:439:b1c3:84bc with SMTP id ffacd0b85a97d-43a04d79dedmr5493120f8f.7.1773395179640; Fri, 13 Mar 2026 02:46:19 -0700 (PDT) Received: from [192.168.0.101] ([109.76.176.163]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439fe1aa2c3sm14037146f8f.13.2026.03.13.02.46.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Mar 2026 02:46:18 -0700 (PDT) Message-ID: <3499e8ad-ee87-410b-9db1-215d6c20e195@linaro.org> Date: Fri, 13 Mar 2026 09:46:17 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] media: qcom: camss: Fix csid clock configuration and IRQ offset for 8775p To: Wenmeng Liu , Robert Foss , Todor Tomov , Vladimir Zapolskiy , Mauro Carvalho Chehab , Hans Verkuil , Vikram Sharma , Suresh Vankadara , Wenmeng Liu Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260313-vfelite_fix-v1-0-2ee7de00dee7@oss.qualcomm.com> <20260313-vfelite_fix-v1-1-2ee7de00dee7@oss.qualcomm.com> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <20260313-vfelite_fix-v1-1-2ee7de00dee7@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 13/03/2026 09:42, Wenmeng Liu wrote: > Fix two issues in csid driver for 8775p platform: > > 1. Simplify clock configuration for csid lite by removing unused clocks > and correcting clock rates. Only vfe_lite_csid and vfe_lite_cphy_rx > clocks are actually needed. This should be its own patch and should that patch have a Fixes: ? Simplification != fixing a bug. > 2. Fix BUF_DONE_IRQ_STATUS_RDI_OFFSET calculation for csid lite on > sa8775p platform. The offset should be 0 for csid lite on sa8775p, > > Fixes: ed03e99de0fa ("media: qcom: camss: Add support for CSID 690") > Signed-off-by: Wenmeng Liu Yeah this should be standalone then. My general rule here is if your patch requires line items to explain various things being done, then those line-items deserve their own patch. --- bod