mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Luke Jones <luke@ljones.dev>
To: Andrei Matei <andreimatei1@gmail.com>, tiwai@suse.de
Cc: linux-kernel@vger.kernel.org, perex@perex.cz,
	ruinairas1992@gmail.com, sbinding@opensource.cirrus.com,
	tiwai@suse.com
Subject: Re: [PATCH v4] ALSA: hda/realtek: Add quirks for ROG ALLY CS35l41 audio
Date: Fri, 23 Jun 2023 11:29:41 +1200	[thread overview]
Message-ID: <349dd967fd5c201619cea0c54e3a09e933bfd377.camel@ljones.dev> (raw)
In-Reply-To: <CABWLsesOzR=Wpc1TTp3PLXAuWUfX-heUnUys7ffM=Jzn-mEbxw@mail.gmail.com>

On Thu, 2023-06-22 at 08:35 -0400, Andrei Matei wrote:
> Hello,
> Is this patch specific to the Ally, or does it cover other Asus
> laptops discussed in this thread [1]?
> 
> Thanks!
> 
> [1]
> https://lore.kernel.org/lkml/b4c202b2-ab29-e2aa-b141-0c967b2c1645@opensource.cirrus.com/T/#m42ec3f3f4ceb610430587b916281b570fbb666df


It is Ally specific. Most of the laptops will require a set of similar
quirks, but for a different codec susbsystem ID.

Some others have now been submitted, if your laptop is not yet
supported please file a bug report, if it is a ROG laptop you can
submit something here https://gitlab.com/asus-linux/asusctl and I will
help plus submit any fixes upstream per usual.

Do keep in mind that the 2023 range of ASUS laptops are almost all
missing the _DSD properties for the Cirrus amp they are using, and so
you will be missing bass/midrange until a solution is agreed upon (or
you add an ssdt patch) - you also need the correct firmware tunings for
your laptop. It is very highly unlikely ASUS will add the missing
properties to a bios update for each and every one of the laptops + the
variants in the full 2023 range.

Regards,
Luke.

  reply	other threads:[~2023-06-22 23:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-22 12:35 Andrei Matei
2023-06-22 23:29 ` Luke Jones [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-06-21 16:17 Matthew Anderson
2023-06-21 16:22 ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=349dd967fd5c201619cea0c54e3a09e933bfd377.camel@ljones.dev \
    --to=luke@ljones.dev \
    --cc=andreimatei1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=ruinairas1992@gmail.com \
    --cc=sbinding@opensource.cirrus.com \
    --cc=tiwai@suse.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®