From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f53.google.com (mail-ot1-f53.google.com [209.85.210.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0B04257824 for ; Sun, 2 Aug 2026 15:14:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785683680; cv=none; b=pwZD1qR2yK1F0D0jLfcd7EmKYirprkDvSHFUsz3C6gnDAMoGhghm+Waha1+jdFWFrrQ14ROQAD7Yohmzgf9RPTV3NnHeZ0dyuVj8YECkcIXJQAtc6Nr9RbQmBkgl+XOYP2u5bx10/tIHc9zwdtjiNOmoWYFJWM6msYmJp9Fb9dk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785683680; c=relaxed/simple; bh=PLLcLqMx1gfzbLZ/bw5r7C+UIrKhF4+HRnGPl4TA7eA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Hy5MI7w4IKoJUMDy/A2fYhvoLG7Vrv8fQeDCYoAWMx7lUR8BwsLS0FTW8VHk6/+GHx3q2WKZltUXWtktiQfymy/mIf0+4Kb5e87XLO/hcSMvQ9xw7qOuH370iAgI4vyWCp71QqkZwTeTlBSP+NegVlKxC8/dKzIkOHkTSQ5hZ7U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=LPcpvGxH; arc=none smtp.client-ip=209.85.210.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="LPcpvGxH" Received: by mail-ot1-f53.google.com with SMTP id 46e09a7af769-7eb29ed2bbdso863982a34.2 for ; Sun, 02 Aug 2026 08:14:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1785683676; x=1786288476; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Rr0TzZh8MRzpbub91JNUFmvt27M8H9CPFD+akea5yMo=; b=LPcpvGxHLEoRq6QNUt4ikhJcW1nEvX0ktgo0ByMtsEabEAtMoJzc2BWdt6eKgrd9Jo 3ps+Kz6yXLTQCMvl7eH06dfuYjsOL0/w4lxQ0Ds4M+1/I5PzhvTcStBKhoiOt7ancXOh 7GvNMsDYXrOn6vqS2lRU+wvQbga1lv2rOgHoI32uXQMfVWnYngKeoxqtBNXdEG4az0FW hS3GNTU0+76baS2y+epitph9bXHw+AwtiyhD/kFHOZdb8rC7sDThdt8eIJQ5cdvgoays DNUFwOnXEdhos4MtlvT6eSBtN0NxVlithYm9JNkgLEi7425YDBaX4sOp2huU8SeBYm/D kpEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785683676; x=1786288476; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Rr0TzZh8MRzpbub91JNUFmvt27M8H9CPFD+akea5yMo=; b=Kbi7O5WSvm5lual5ujjB8zRPr+6agLayRLhq1VTugNVDNT9pftMB1G1/VNKF5gzUp+ yp7nzXKnnQggK1TdFNJnpkioZyRlQapyKAtWNHlkTDHUaSLk5pV6musdGMpgCqlem8oU 2ONuhQE++1owgyPdLEwBVcqds+BOcR0Kundc2rj+ckjpbxRHr5EwrrsvzZnUDKu48r6r lGGB+3WdMcoV1AxcKcgTzs5zJg6sLoCVVnjkpvqG+zgH8iOYyHaJvNi+5OUi7MzMp2yE 2PK3fs5M5ULMtTBv0863brytmgey2nlU9bVLMbZORpbULYVfzsxYTxjyV3510hdpAllX kCcw== X-Forwarded-Encrypted: i=1; AHgh+RoB1qgJh9n/NYMaDIPsLyeB0s2jcQQf1dWKPQytw65vnJimuZL4uCNgmD23VHPqTHExvCRyNHh4Mv987WQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yw4gU2iiZzK0btDiOUX8oyuzy8tLEE/pmCrOo61RaAVwKLkbY+9 YnRpwV0pUTN9iJI9KJxPE/NLQt8USvCKpnorCYsGUbtrrYiI1l/g5UZWlE0sg7NnJ4A= X-Gm-Gg: AR+sD12AToz2PQk7VBY+wQ2CnO5nFe6T2Lv6ZbTHGIdTksjRZ0ZaGUeZJs7Fcm28NP6 85wvI7YiLOo0ZOIBqsnduBdg/sCZl6sqYenpUreFgBKqtrrRk4SVgSzOtI0fic/E3/YKKSfPLs/ 5E3CvMg573oAVsNfOgjpqmhPnXrTr3TVqtb/fHLqAdPoxwziNSeJipBtBMy23BBYNOpYWBIG8Hb A3k5ErTk2c/+Muv1rllyBXRgN66q4mKt5fKy2P6kJqdnhDUoMOkvTSIkt5vUiswzX1bf0CBVj44 B+m+KtjwEqCqy1fSvbiPAlVcxs/mllTh5B7pxpR+bZeGGdKhrgTswId8+waem1XbVyzsnaI7h7/ paD0swWV21ZRO884Kha0iLZAGXaOfjovEBAKxqXeySxgmbvouzpK7voJUNiqL5DW3ZGRe1WykvQ a2JGWG0ydVBecV6t7/eVpTpB7stTbXBwWyS77oveFt+HKerLwk24yMnWuHLxCtVLa++rj+dR4ZL VvlplLvZBTzx7hlMkOOp2/F+GOPTcvY+gJnvD4= X-Received: by 2002:a05:6830:2409:b0:7e7:8dc0:3951 with SMTP id 46e09a7af769-7f196cf6adbmr12788526a34.8.1785683676486; Sun, 02 Aug 2026 08:14:36 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:5487:2b6e:1057:d3d3? ([2600:8803:e7e4:500:5487:2b6e:1057:d3d3]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7f18e8cc0efsm5219109a34.0.2026.08.02.08.14.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 02 Aug 2026 08:14:34 -0700 (PDT) Message-ID: <349e5f1c-b162-4e10-a4b8-87c2c3b83554@baylibre.com> Date: Sun, 2 Aug 2026 10:14:32 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] iio: chemical: ccs811: cleanup checkpatch __packed warning To: Adi Nata , joshua.crofts1@gmail.com, jic23@kernel.org, nuno.sa@analog.com, andy@kernel.org, u.kleine-koenig@baylibre.com, email@sirat.me, mazziesaccount@gmail.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: linux-kernel-mentees@lists.linux.dev References: <20260723235312.432a895c@systembl0wer> <20260802022559.23138-1-adinata.softwareengineer@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260802022559.23138-1-adinata.softwareengineer@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/1/26 9:25 PM, Adi Nata wrote: > Change instance of __attribute__((__packed__)) to __packed per > checkpatch.pl warning. > > Reported by checkpatch: > FILE: drivers/iio/chemical/ccs811.c This same feedback applies to all of the other patches you have been sending. Making checkpatch happy is not a good reason on it's own. Find out the reason why checkpatch makes this suggestion in the first place and use that as the justification for such changes. > > WARNING: Prefer __packed over __attribute__((__packed__)) > +} __attribute__((__packed__)); > > Signed-off-by: Adi Nata > > v2: > - Rename commit message to include driver name > > --- > drivers/iio/chemical/ccs811.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/chemical/ccs811.c b/drivers/iio/chemical/ccs811.c > index ce7187ccd706..0e5c79b775a2 100644 > --- a/drivers/iio/chemical/ccs811.c > +++ b/drivers/iio/chemical/ccs811.c > @@ -70,7 +70,7 @@ struct ccs811_reading { > u8 status; > u8 error; > __be16 raw_data; > -} __attribute__((__packed__)); > +} __packed; > > struct ccs811_data { > struct i2c_client *client;