mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: "Lena Wang (王娜)" <Lena.Wang@mediatek.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"dsahern@kernel.org" <dsahern@kernel.org>,
	"edumazet@google.com" <edumazet@google.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Shiming Cheng (成诗明)" <Shiming.Cheng@mediatek.com>
Subject: Re: [PATCH] Net:cache didn't flush when ipv6 rule changed
Date: Wed, 28 Feb 2024 08:34:49 +0100	[thread overview]
Message-ID: <34a1ca43d2f21428367237b4b693df6804bf716d.camel@redhat.com> (raw)
In-Reply-To: <3fd5e055b5f56c596416f0cf37c6b47e77af0379.camel@mediatek.com>

Hi,

On Wed, 2024-02-28 at 07:28 +0000, Lena Wang (王娜) wrote:
> Dear David,
> Update the patch as below, thanks.
> 
> 
> From db01a40e45f51d00cb19e45a41507c97363d6ed8 Mon Sep 17 00:00:00 2001
> From: shiming cheng <shiming.cheng@mediatek.com>
> Date: Mon, 26 Feb 2024 20:17:58 +0800
> Subject: [PATCH] Net:cache didn't flush when ipv6 rule changed
> 
> When changed from old rule&route configure to new one as below,
> ipv6 cache dst_entry did not change to new route table as no
> cache flush callback function, then forward to wrong out interface.
> When fib6_check dst_entry, the fib6_node version[fn_sernm] is
> always the same with socket dst_cookie, old cache dst_entry is
> always used and no chance to update.
> 
> So we need to update fib6_node version when rule changed and
> flush cache to avoid dispatching a wrong interface.
> 
> Signed-off-by: shiming cheng <shiming.cheng@mediatek.com>

You need to cc the netdev mailing list to allow up processing the
patch.

Please also include the target tree in the subject prefix ('net' in
this case), a suitable fixes tag and avoid sending patches in reply to
existing threads as it confuses our bot.

@David (out of sheer ignorace) could this the root cause for the fib6
self-tests sporadic failures?

Thanks,

Paolo


  reply	other threads:[~2024-02-28  7:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-26 13:11 Lena Wang (王娜)
2024-02-27 15:06 ` David Ahern
2024-02-28  7:28   ` Lena Wang (王娜)
2024-02-28  7:34     ` Paolo Abeni [this message]
2024-02-28  8:24 ` [PATCH net v2] " Lena Wang (王娜)
2024-02-28 12:30   ` Jiri Pirko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=34a1ca43d2f21428367237b4b693df6804bf716d.camel@redhat.com \
    --to=pabeni@redhat.com \
    --cc=Lena.Wang@mediatek.com \
    --cc=Shiming.Cheng@mediatek.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®