From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sphereful.davidgow.net (sphereful.davidgow.net [203.29.242.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9417F1E885A for ; Tue, 21 Apr 2026 05:46:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.29.242.92 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776750379; cv=none; b=evfkisM81eqOeirB7qWua6lrcIbQWKdA4F3y/XZC43VwmGVFGU/Bt7qyDjKEyQxiuPXnDSZ0mCJDpjAy+93OQ0R2qxHg6G5jmEqeqaaj2sghf3xRg2knLhab04oudo7ttOwFqawd9tnQr6cuXtqRermo0O8+5krD8qVQGktkiWs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776750379; c=relaxed/simple; bh=OwBHxGhy1wBazT7o/iwSSkTlvcPkI6MDxzzMbjuqm4g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YZ+B/E4HnP7R4P5cQWAoEP9QRTX8IDJ3TNgHet7tYUX5+GBaEbkAcZLZh7+fsz7QbmclvHkWKz2CjUoAJGBs6oZJomaimXNb/6GwPxezId+rkpxnNGyQ9z8s5e8DTZRU5wM6Q6m7Q4hFDoIifljqz5rnlySgbBdsZRMUhKzneWc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=davidgow.net; spf=pass smtp.mailfrom=davidgow.net; dkim=pass (4096-bit key) header.d=davidgow.net header.i=@davidgow.net header.b=D+ZPv1/G; dkim=pass (4096-bit key) header.d=davidgow.net header.i=@davidgow.net header.b=n6Dc80km; arc=none smtp.client-ip=203.29.242.92 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=davidgow.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=davidgow.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=davidgow.net header.i=@davidgow.net header.b="D+ZPv1/G"; dkim=pass (4096-bit key) header.d=davidgow.net header.i=@davidgow.net header.b="n6Dc80km" DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=davidgow.net; s=201606; t=1776750369; bh=OwBHxGhy1wBazT7o/iwSSkTlvcPkI6MDxzzMbjuqm4g=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=D+ZPv1/GpmDiKPquyFWNdklH4jmowZ4BkhrGdbGaI7eQj0GFjnMbCa5rxJLJrTF0t Cl8oQoNHSWcnQDfIat2hBDI9b199YxqWbqhzFyH0Ju7ZBD1VMayQeRyLSXECSTMXZ2 zw0W1El5cd0XRBwLF7W+u9HPWSV9UaSSlg/KQMyfJiX36DecfMIcCrHOkn2X4b+yOX w0ltek7GMTNEVo/WeSr4RDXKscOtzVecCDoX0tPeGyYiGv00W3+XTzDUh5eamoCjE+ +n+9BA3UuBQIe3MBxM34/0vu3FOh9Vh0+bzEG2lHQMar7w2cn8DpkvKHmXsYRSe57a Jl7BBV4SIutdaUSxVFqfYY4XfNTlzzc7CRUX5sMQopTEXPu0qzbMNnY1xxEs0w//Zm 4UpomFFU1itwIylZMZR7uIa8E8mVLvWSLgFdH4PdD10bvgwb48mF3/vA0fYWY6tjX+ A8rwKXFAwR5WNydyGiCTbV8hPiKxX0oMZx48/vOpx7R7cJUZQggVieItBvFEHGJXLP NoaOfynN6vOMW7sbgIoWFRUeNvce+dMu/qt2RAOJ++s1EjSQx9muc0wpN9zEf5ojPM rgVL/dpPKoB7ZoEGOy6egiDq2JMuVcP+xVGEyLfsfcVmCpeHzzTVFqwyeAw2hjd796 HvW/9RmGSyVOOKHbTODW49+c= Received: by sphereful.davidgow.net (Postfix, from userid 119) id 23C701E8CB2; Tue, 21 Apr 2026 13:46:09 +0800 (AWST) X-Spam-Level: DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=davidgow.net; s=201606; t=1776750338; bh=OwBHxGhy1wBazT7o/iwSSkTlvcPkI6MDxzzMbjuqm4g=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=n6Dc80kmCtFBMv5fX2XajpRlCv3BJY5rFu9I4JK/d+TZp1HwwDZa4DhdqHKDSCbLn S5jfrpGTeHgqbJpCJrq6u2NJnGVJ9x4UcSYY5VpdMYn/hCSHmTOdo2PwyahgKUJi1k 40vaKyXNSp4JAiHqgm3JCfxu0e6gFivcPasQjhX/mp6rI4RVKjluKbTz9/YZS4/pqN /O2KKX+9mh3zELpDC1zp/r4rwniwC5FqLiIvroFvutRGdi4sSsfqMPv8pqEdl6DiRk 445Pw7wX5HdOfH1dTIxiE7SRjpYDZ9lnbxUNZTiY7g9w1SpouwFpxfK2XQVhTqOfhp Z1qOmDGOWnh9cyZpYmbzUy9mrzeEANX+cR8xJxVFu8t/jcMjHgC5T53UC8AybnTh+d 7xiPGME1NZBcZhN4FhqbNEQpOhe3qw87NbsO4Dg95+k8uxXouUYq+pnD+7T5EfkGkO uaoiRmEteb7OqlPful2VM9GPQv3Molticbf1BFEASoo0xRGSwF+s3EcpHD32CTbX88 m2dZ2L5f6CpAXoOImkJZrg+7t8/MjlojSIySAmPoOwctSfRZwlny8LhRqaM/x5JoA1 tckQDyGatjcv6fSCKAopWhwDkLdsdzbYE8ZIf/IJnuUr6A/4jeL7UuiJPNpWTmo+0E 7mMgYDdgkU/DeQWToDR88OY8= Received: from [IPV6:2001:8003:8810:ea00:615:932a:cdfa:179c] (unknown [IPv6:2001:8003:8810:ea00:615:932a:cdfa:179c]) by sphereful.davidgow.net (Postfix) with ESMTPSA id 9F5CA1E8CAB; Tue, 21 Apr 2026 13:45:38 +0800 (AWST) Message-ID: <34a81ec2-af84-465d-9b5e-7bb5bf01680f@davidgow.net> Date: Tue, 21 Apr 2026 13:45:33 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 5/5] lib: kunit_iov_iter: Add tests for extract_iter_to_sg To: "Christian A. Ehrhardt" , David Howells , Andrew Morton , linux-kernel@vger.kernel.org Cc: Kees Cook , Petr Mladek References: <20260326214905.818170-1-lk@c--e.de> <20260326214905.818170-6-lk@c--e.de> Content-Language: en-US From: David Gow In-Reply-To: <20260326214905.818170-6-lk@c--e.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Le 27/03/2026 à 05:49, Christian A. Ehrhardt a écrit : > Add test cases that test extract_iter_to_sg. > > For each iterator type an iterator is loaded with a suitable > buffer. The iterator is then extracted to a scatterlist with > multiple calls to extract_iter_to_sg. The final scatterlist > is copied into a scratch buffer. > > The test passes if the scratch buffer contains the same data > as the original buffer. > > The new tests demonstrate bugs in extract_iter_to_sg > for kvec and user iterators that are fixed by the previous > commits. > > Cc: David Howells > Cc: Andrew Morton > Signed-off-by: Christian A. Ehrhardt > --- Hmm... this is failing on powerpc, where PAGE_SIZE is 64k: [13:20:40] # iov_kunit_iter_to_sg_kvec: ASSERTION FAILED at lib/tests/kunit_iov_iter.c:1084 [13:20:40] Expected tail < bufsize, but [13:20:40] tail == 1048576 (0x100000) [13:20:40] bufsize == 1048576 (0x100000) [13:20:40] [FAILED] iov_kunit_iter_to_sg_kvec [13:20:40] # iov_kunit_iter_to_sg_bvec: ASSERTION FAILED at lib/tests/kunit_iov_iter.c:1084 [13:20:40] Expected tail < bufsize, but [13:20:40] tail == 1048576 (0x100000) [13:20:40] bufsize == 1048576 (0x100000) [13:20:40] [FAILED] iov_kunit_iter_to_sg_bvec [13:20:40] # iov_kunit_iter_to_sg_folioq: ASSERTION FAILED at lib/tests/kunit_iov_iter.c:1084 [13:20:40] Expected tail < bufsize, but [13:20:40] tail == 1048576 (0x100000) [13:20:40] bufsize == 1048576 (0x100000) [13:20:40] [FAILED] iov_kunit_iter_to_sg_folioq [13:20:40] # iov_kunit_iter_to_sg_xarray: ASSERTION FAILED at lib/tests/kunit_iov_iter.c:1084 [13:20:40] Expected tail < bufsize, but [13:20:40] tail == 1048576 (0x100000) [13:20:40] bufsize == 1048576 (0x100000) [13:20:40] [FAILED] iov_kunit_iter_to_sg_xarray [13:20:40] # iov_kunit_iter_to_sg_ubuf: ASSERTION FAILED at lib/tests/kunit_iov_iter.c:1084 [13:20:40] Expected tail < bufsize, but [13:20:40] tail == 1048576 (0x100000) [13:20:40] bufsize == 1048576 (0x100000) [13:20:40] [FAILED] iov_kunit_iter_to_sg_ubuf [13:20:40] # module: kunit_iov_iter [13:20:40] # iov_iter: pass:12 fail:5 skip:0 total:17 [13:20:40] # Totals: pass:12 fail:5 skip:0 total:17 Any chance we could bump up the buffer size (at least) on systems with larger PAGE_SIZE? Cheers, -- David