From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 298BCCA101C for ; Tue, 5 Sep 2023 21:52:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244552AbjIEVwa (ORCPT ); Tue, 5 Sep 2023 17:52:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241006AbjIEVw2 (ORCPT ); Tue, 5 Sep 2023 17:52:28 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E53BE9 for ; Tue, 5 Sep 2023 14:52:24 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-9a2a4a5472dso61900566b.1 for ; Tue, 05 Sep 2023 14:52:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693950743; x=1694555543; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1sXq4tMf8r0BTPTigD/vFRQoudDkPpomgeI7QgSk3C8=; b=RjjyOZU1EqGPscqwSvhLmnoSqcQIPX+xHmwLUtHI7X2YHQPRpuAj/c7GlB193WArVY qpGMLFuPbIXgHq8UmkMNjld2CgcgUhcIIAnZRrotvMBs/Mm9pgwDGZTI96sOCoeQi4aV X1gs8/svzgpjolRBMpRG3jG03ZgVTK3M1dyQvX6x4LB69AoQhnWLhxKRYV84PcleCAao sAy2j0HUK4KanlLzkBUh2ZvJKWmTxLBbkQM3pFF+xHTVynnyWQC6+7uo89/Z6bUG9eTL 7laVhnMolvqk949Yjnlz2ddPdeFt+L6D9vGbbRO7XMnZ0fG7kHPB3rBnN7MmBgRBgmBK NLjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693950743; x=1694555543; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1sXq4tMf8r0BTPTigD/vFRQoudDkPpomgeI7QgSk3C8=; b=lyyOEkW/HjJnlTa4jII/W1ftUszZpRfaSwIaVcIkw6o1Bro5Fv42kHHBOWZfh0go33 N9FLB6VeZ4HLaODJbXTLFy8zYFZmgjkRkge2T8gJnvOY304CW8obgIqLQx+NP6Bjl7wr 1WiyMq3+CUyvIx9CdIk23V2P//9c7meLGaPsH0ad0ffKHXdUIvJPn32JP2/SuGdLLsH8 YRlJBu8MRuGHAGR1f+1FQjj2aQt01QJhTnk4Vk9r/7fwKvFunaj/zInBPLuuU4XStAEY Q5/qVqrpREdkKHkOK390lEZZyTCAFY/MHu7/GzYVRFQFGd2TGZdulQFaqZdgqE2KPTP6 ym0Q== X-Gm-Message-State: AOJu0YzrXiI890acdGdQyPkkq7JfPfxWEan3ACzRyAul6Lrz8koeHRkZ NGHgVVdixl2/6UPQakQX9Ovt5w== X-Google-Smtp-Source: AGHT+IFIais0k3szY6NyGV7Kf+EEyxKBSpYfXVxluyTtAR3ZvSYb875QLxLdksYWv2WENpcP1T0NjA== X-Received: by 2002:a17:906:9754:b0:9a5:9b93:d60d with SMTP id o20-20020a170906975400b009a59b93d60dmr993645ejy.36.1693950742989; Tue, 05 Sep 2023 14:52:22 -0700 (PDT) Received: from [10.10.15.130] ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id gf16-20020a170906e21000b0098669cc16b2sm8050192ejb.83.2023.09.05.14.52.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Sep 2023 14:52:22 -0700 (PDT) Message-ID: <34a95082-ed15-48db-9c64-2ecbe0ccdd6a@linaro.org> Date: Wed, 6 Sep 2023 00:52:21 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFT PATCH 2/2] arm64: dts: qcom: msm8996-xiaomi: fix missing clock populate Content-Language: en-GB To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org References: <20230901081812.19121-1-krzysztof.kozlowski@linaro.org> <20230901081812.19121-2-krzysztof.kozlowski@linaro.org> From: Dmitry Baryshkov In-Reply-To: <20230901081812.19121-2-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/09/2023 11:18, Krzysztof Kozlowski wrote: > Commit 338958e30c68 ("arm64: dts: qcom: msm8996-xiaomi: drop simple-bus > from clocks") removed "simple-bus" compatible from "clocks" node, but > one of the clocks - divclk1 - is a gpio-gate-clock, which does not have > CLK_OF_DECLARE. This means it will not be instantiated if placed in > some subnode. Move the clocks to the root node, so regular devices will > be populated. > > Reported-by: Dmitry Baryshkov > Closes: https://lore.kernel.org/all/CAA8EJprF==p87oN+RiwAiNeURF1JcHGfL2Ez5zxqYPRRbN-hhg@mail.gmail.com/ > Cc: > Fixes: 338958e30c68 ("arm64: dts: qcom: msm8996-xiaomi: drop simple-bus from clocks") > Signed-off-by: Krzysztof Kozlowski > --- > .../boot/dts/qcom/msm8996-xiaomi-common.dtsi | 32 +++++++++---------- > .../boot/dts/qcom/msm8996-xiaomi-gemini.dts | 16 ++++------ > 2 files changed, 22 insertions(+), 26 deletions(-) Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry