From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7DF6331A5F; Wed, 11 Feb 2026 10:13:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770804833; cv=none; b=rDQ9HKIsZbP5y9fk7fGGsSwILoDXzMyThkXjt7mq2vC+HWj2ljzqAMMACKzCcgrnG2Nj1cGgydQnrp7E3Auj5W9crMGnv8G8X93axUrrJEC+R0Ye5WQqAvF2L7UgfdaDTUGYjxifb/JQXQu5RFiXsM9guX1PV6oQc4+0sRa+KSs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770804833; c=relaxed/simple; bh=JFnX7yfR+381QSg8y1LbW4qWSHq1WxFa6n1bWoTWAN4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sNVxFVxMbvUBz8wb1FLHVzWmjLXrfaYqp1QUYVO8KJ54F1A8vzHJxmql9b60UNPXj9t5o/wKC+UunokuYn/K39FA9bYPWwbKz8q49QM+6+F3mkinXJEPiiDURfSCnq0ZsIX3Gn8/VqTHABKKbiNbWHp7vH8ZL6UxIXnDho5vvWk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=B8u+HgjN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="B8u+HgjN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30CE4C4CEF7; Wed, 11 Feb 2026 10:13:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770804832; bh=JFnX7yfR+381QSg8y1LbW4qWSHq1WxFa6n1bWoTWAN4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=B8u+HgjNPMxacH9NpoYGeAB44HvTBxQHojZ4EC4DaURdrxrjgWx5VJCvYgEuK0TNV JTE4VBxkzKFUoSdIV3YlX8ZaJ48N/YUQt4ZDvEFbpKo4D4LMx6e+lk2xxkoD/BawtO 14nGoysBuyZuO9CaX6+74uypUtlEkBl4TGDG+xL/sv2RS3sDURFJQZN0fVTdH0z1cA aKH2VKCAJU3RNctaSnNW2R3j+kI1Oy1HPyymRzvFNh7z8xFd7ZgpYmv4fPFoN8HFUt NsfRDcsMTFJcnwoGvqN2EPWqQvfSSyq/cBbsX2BiijrWuel3dRtOxtx6/iOuxFfkCH 4qvEwTHcQeJEQ== Message-ID: <34a9b531-4f53-47ee-861e-1b18ff1a5752@kernel.org> Date: Wed, 11 Feb 2026 11:13:48 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] gpio: aggregator: add gpio-aggregator DT compatible To: Bartosz Golaszewski , James Hilliard Cc: linux-gpio@vger.kernel.org, Geert Uytterhoeven , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alexander Stein , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260211081355.3028947-1-james.hilliard1@gmail.com> <20260211081355.3028947-2-james.hilliard1@gmail.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 11/02/2026 10:47, Bartosz Golaszewski wrote: > On Wed, Feb 11, 2026 at 9:14 AM James Hilliard > wrote: >> >> Add an OF match entry for "gpio-aggregator" to support plain GPIO >> forwarding from devicetree without delay semantics. >> >> This allows exposing selected lines as a logical GPIO controller with >> stable aggregated offsets, so consumers can reference forwarded lines >> instead of physical controller offsets. It also allows creating bundled >> groups of named lines that can be exposed to userspace as a convenient >> virtual gpiochip interface. Using "gpio-delay" for this case is not >> suitable because it enables delay features and requires 3-cell GPIO >> specifiers. >> >> Signed-off-by: James Hilliard >> --- >> Changes v1 -> v2: >> - Split DT schema into a separate patch >> (suggested by Krzysztof Kozlowski) >> - Expand commit message rationale and use-case explanation >> (suggested by Krzysztof Kozlowski) >> - Clarify userspace use case with bundled named line groups >> --- >> drivers/gpio/gpio-aggregator.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/gpio/gpio-aggregator.c b/drivers/gpio/gpio-aggregator.c >> index 416f265d09d0..a09752fc5fe2 100644 >> --- a/drivers/gpio/gpio-aggregator.c >> +++ b/drivers/gpio/gpio-aggregator.c >> @@ -1635,6 +1635,9 @@ static int gpio_aggregator_probe(struct platform_device *pdev) >> } >> >> static const struct of_device_id gpio_aggregator_dt_ids[] = { >> + { >> + .compatible = "gpio-aggregator", >> + }, >> { >> .compatible = "gpio-delay", >> .data = (void *)FWD_FEATURE_DELAY, >> -- >> 2.43.0 >> > > Regardless of the DT bindings - this change is perfectly fine. We do You cannot have compatible without DT bindings, so this alone is not "perfectly fine". Maybe you wanted platform_device_id entry for ACPI/legacy/MFD devices? Best regards, Krzysztof