From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 437AD1DFD8 for ; Mon, 30 Dec 2024 15:36:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735572969; cv=none; b=i0Qewekjy+rpwrDxnRtWfu/NrNAwTfvzhZfTMo8bZ/PjvpjZ/+kvG9MXHYEJEiQ7aMW1xzjyDamtM64iwS6pOjQuI8Y16+NbESKKBw+8VaJL+ujzfEBqCIdbVua7UYp9FSrcBZemaN+6MYBCr6cPWSD0EDIvmY9ziPuqTr6guJk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735572969; c=relaxed/simple; bh=wkeG7P4UChRzJtrhWCiRAM2V3yJ4AXjEyMvJFckL1vg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=syxWnXQ/W1yXtkYGL23m4WW13hMjwnYaxjq8VB+3xzSXrAzDtnQVe3d5T0u5xW0KESfAhyPXJQx7d/s+uyQ4g26qy/IJNYUcSMQRmRucvpftbz+AZqmSzls8Xu0L1yU+QmEz7O+VoX4SykWyCahuxZX17oVzajMWgIPf1M4HSKk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YiuZkCiA; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YiuZkCiA" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BU7FlSq027081 for ; Mon, 30 Dec 2024 15:36:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= QlRM+Tt9HfLWUo5Qja07NOP2unyO6boK9jX6MFLYbss=; b=YiuZkCiAgKoaSu6I T7wuFOM30jnPMCFlD/2Ycy1t2gju+g9FFZkeU9CmrAq8s5rgkLxKjKbHa9VD4oMq gKak7txiI99BvXno+E8spyxdFRJVo+cEAPskuIlel7hcLRC2Uu6GUjonHjgspvu2 mDAVHYETYJ8wGRFPIbRHsKZQhDqtVxERfx4tp+1z4FsoWhftT7XGwRGcB0BAqSDK xjQfF7THQ2jdRNKJ8pMz3KvNyP3fmo/7EEXf0cMwV8xydSZjuBW+tp1TVzkTzYu5 cf6v0LkMk8Yd+GuvvVpnTpGfIJT0mdtNva8AimAjzD1QFqTjWjrAPn5AmVl27RZv zdJ4bw== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 43upyr90u6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 30 Dec 2024 15:36:07 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-7b6f85325c3so118119085a.1 for ; Mon, 30 Dec 2024 07:36:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735572966; x=1736177766; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QlRM+Tt9HfLWUo5Qja07NOP2unyO6boK9jX6MFLYbss=; b=NLGfTYvRfPuSS9x7ZZ/el93gqZi8wmTVKlz7DncuPa9Q3WmhSWICxXea9rXELIWHqP WAHGp+WwZGKyfk1JjZm2Oi4bNZhuaixKBMDb9g92njaKZgg51pJnLhgIVOSlb8mm6NMQ TQNall1Lco8qGhbKxSx3BpP5B9DB4e4IgRiISxegX1jC3v7yIJhOPe1xTsQH1msrXjTn zzyROwC7ZSIMKSDnifXL1PKzATkdjuOnRfBlpoOq4fKWhfrekujI6he77hNTrCv8w3gV BC/2qd5mclBui46Rl3CsC+cw6YMpn/MLiHRjP4kmgjVLn5L23Q2obBND/WVRukTCl7+N NohQ== X-Forwarded-Encrypted: i=1; AJvYcCUpHQQU5Nv/XGNVlzYx7wHsQcgqouWAj+Dd26O6IKLiGLbZqcOSjLNuZnjHIX2MQh6hQe2FsVIXj43JCp0=@vger.kernel.org X-Gm-Message-State: AOJu0YweS7HytJdpPojcl+Qwh6Z5k2kzwyM3v0L3D/UnEQNdOF+2zor+ t8VNwurh4Fo7DwmrUscHrWcdy62zK3zmzyds/6qRjRFmMy2uD5otIU4RXsGeg/g0aJR1TXMJ5He Y6tDUDfuwUuKHDGfpKPXmATXDZ+8IoIxUxDABnOEDh1Udj9Vasd+BqWcZm6LTqA8= X-Gm-Gg: ASbGncsd1kQp7qLRvLMMJ9U8tWoK0sSqDIcac2MUakbKgh8Fd2uPyixFcgS8tbUfT2f QmcRNLLZobrRcx+sh8avL3c0O1J/5/8Wx+0y4TSKRbFgSt2lJICIFUbidAvFRg6+2mCzawBuJuy WV06Wxh1oSXM7WAAvVBUyiCH4FlkfTBvFqQ57SDHpFl3HgHrOeY+rtrPGEoFhTZ71bK8TynV97z tyDVb0dsx+22zkj6poBazFpqKMGnhswenZJxDAp0nItOMhGY6CuK9pFuDKLYUlvid1obxcqtd/p V1YaI8dU8kDja9famNxlerE6DJbScr+riTI= X-Received: by 2002:a05:620a:2496:b0:7b6:e61b:3e60 with SMTP id af79cd13be357-7b9ba742c0cmr2250329785a.7.1735572966273; Mon, 30 Dec 2024 07:36:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IEi4DQS+Ey4mwcCBBrhyHtkNV/V1K4BRSDlma3sCc3zl5NHxwgFKp47MXICxUIytxfQe/LDZQ== X-Received: by 2002:a05:620a:2496:b0:7b6:e61b:3e60 with SMTP id af79cd13be357-7b9ba742c0cmr2250326985a.7.1735572965855; Mon, 30 Dec 2024 07:36:05 -0800 (PST) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aac0f01228bsm1477930666b.143.2024.12.30.07.36.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Dec 2024 07:36:05 -0800 (PST) Message-ID: <34ab59a1-b735-44d1-918a-1b82954a4423@oss.qualcomm.com> Date: Mon, 30 Dec 2024 16:36:03 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/6] Add SPI4 support for IPQ5424 To: Kathiravan Thirumoorthy , Konrad Dybcio , Manikanta Mylavarapu , andersson@kernel.org, linus.walleij@linaro.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, konradybcio@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Cc: quic_varada@quicinc.com, quic_srichara@quicinc.com References: <20241227072446.2545148-1-quic_mmanikan@quicinc.com> <52fa8219-0485-4fc6-8f3f-5759649057cf@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <52fa8219-0485-4fc6-8f3f-5759649057cf@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: oOXcWfSNVpc1_kc_rnI71urXi2C3wvUz X-Proofpoint-ORIG-GUID: oOXcWfSNVpc1_kc_rnI71urXi2C3wvUz X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0 bulkscore=0 lowpriorityscore=0 mlxlogscore=969 adultscore=0 clxscore=1015 impostorscore=0 priorityscore=1501 suspectscore=0 phishscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412300135 On 30.12.2024 4:34 PM, Kathiravan Thirumoorthy wrote: > > > On 12/30/2024 7:28 PM, Konrad Dybcio wrote: >> On 30.12.2024 2:54 PM, Konrad Dybcio wrote: >>> On 30.12.2024 7:51 AM, Kathiravan Thirumoorthy wrote: >>>> >>>> >>>> On 12/27/2024 12:54 PM, Manikanta Mylavarapu wrote: >>>>> Add SPI4 node to the IPQ5424 device tree and update the relevant >>>>> bindings, GPIO pin mappings accordingly. >>>>> >>>>> Changes in V3: >>>>>      - Rename SPI0 to SPI4 because SPI protocol runs on serial engine 4 >>>> >>>> Do we really need to do this? If so, it will not align with the HW documentation and will lead to the confusion down the line. IMHO, we should stick with the convention followed in the HW documentation. >>> >>> +1, the clocks are called SPI0/SPI1 internally >> >> Ok, I looked at a bit more documentation and it looks like >> somebody just had fun naming things.. >> >> SPI0 is on SE4 and SPI1 is on something else, with no more >> clock provisions for that protocol.. Which is not usually the >> case. > > > IPQ5424 has one QUPV3 instance with 6 SEs. SE0-SE4 are Mini core and SE5 is FW core. > > SE0 and SE1 are for 4-wire UART and 2-wire UART respectively. SE2 and SE3 are for I2C protocol. SE4 is for SPI. > > Since SE5 is FW based (some RDPs use this SE for I2C). In GCC block, clocks for this instance is named after SPI as SPI1. Thanks for the explanation. Manikanta, please refer to this in the commit message as well Konrad