From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99A18306498 for ; Fri, 14 Nov 2025 09:46:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763113569; cv=none; b=cNQV7UAr/OzXhjWrawafrA1ODoIbHR2rDojPChEN83w+9ShH++YW2zNqtpJnMBnDFvMyzAtAwFbdY9cvUMFQ6CuENNAv6r7eD5R8nhR5YsAUgGUTsDmLycii+xTIKQLcEPiMto4Yi98OasYbOA0mOTmakBiFENOT4DewHxSRKgM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763113569; c=relaxed/simple; bh=ajCREfT/hcJRDBbyJOi3jQMEdUT2txP4PezLHt7RVuM=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=jKIHtbtws1kJaIheX/DiAvgve0hVylrzs7wE/VLeMsuVDy+AsGzEIFXjLuS00zPPgoPJaiNBfBe20MS0cPqmheDC5YbUgw+1mdmeEoHuvJnndUO9piYDHshN5gNTsj4p21oa3xAV13VdqezsGCkSTqweyBwpMmhSu+JeXR+xyGk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SBMmQAXq; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SBMmQAXq" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-477770019e4so20808845e9.3 for ; Fri, 14 Nov 2025 01:46:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763113566; x=1763718366; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=5bwqEJshLQG2pK67j+3WEK74xje3ZFwPQhZbDPgILsA=; b=SBMmQAXqf0ETquKTKF04tRQ9J6y+ojJjIWPMaVmSbGOZCcwYcsecP5l9OFpCC5XfvN 1CthhUrl3cBGTWRO8O9f4XVQV8JJ6066kwll+g9KbxZVo2rEkY3i8sQkRp40FTBOnDmK 0dotcj0zMntYWLGZQIwqAMrP54GVBFGEfqlKKNCnH6ldPsOFVuhKfQaDS/t+MJ5+XwbG WxHbDOb0ieWnZyQXzaw9B0LKQHlOAcIXjhe4PFwyoaHcxxay40p/QhCod+kg58tjiSDl Jp3IHufofQArrKPYnVEtAraT5Ajeeud9VhJw54HBJ4d2u18d1zkkASOHM5aoCCadPxm/ B9zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763113566; x=1763718366; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5bwqEJshLQG2pK67j+3WEK74xje3ZFwPQhZbDPgILsA=; b=T9kBBMzaiLkGu/4/ZbKto3cmy6VI1bM9RN81bdSz6NTL4bOFW92zF6vSHXN6yFuunc nPFwCZaUDz3DDDQqK/u4b7zsnu73lKNh7icVQSkedzRKMVmEFlf4VtG3FuKVL+us4kwZ NK4ThFE8UEArb4HEWWtGB4kTci0AyM43fEi+BYVAsWfRAx1MriDrn8Q2R/pMgs1PjjSD ZetFtWgoSBlRUSOE2StEaiTPCBjxKDMsIO1tIOsShzU5g7fxTsJKtwuf5j6E5JMV66HE jLEx/PGqMuI/293A8R8DbwmHY5Qv9H2rkQr4WUOb6ErJeqKZWzY9JM/3tbGiIP5GeGDT lRhg== X-Forwarded-Encrypted: i=1; AJvYcCUckpkmeJ7uHb3v529gvSk5s8GdeWFJk+WGaRzbPJg+hCYWnpFjS7kZBflzUOcNAuvfHCFdRGzX+70B8ls=@vger.kernel.org X-Gm-Message-State: AOJu0YymOyuc3wETGWxLhajsluF/d2UYtEbKqHbaHBtfH+QgYA1ycQtc 83hlPVJri816SlC1qkT1L0RzOvATl6vR6qhwHcTwzuVxH12TQP8K17ZU X-Gm-Gg: ASbGncvSg85D8NqRAKloeHZHH5IGFMwOuAdI87LSI+eSNeK3f+trp5oxV1RXD26ohfD Q0GgKjV6LJ9BrGP11DGRA1fEEDQ359VBQCmfunL9fEl0QwG0kA14WO8+ktqw1AJtKD0N1N8Mz25 OJPmhSFEYnvTH8xVIWmc9l6YsuelcdiOdcqJRFKetBJQ/1IKu9qEtDN55eJzwQLdh5fmefKSoTu 5bMUkMNMwBqyTX4SL7lsmAYMfAQ6+c2fU43GJHyGJbvtjepEznk4uli2NvItufZT0OaP7HizSNg MN6B/2+ypr4rZR8xEhhGFg8zOYmAOWFRQFbpF4vcjbBX081vpIrcErbY+B0PuuvL0xk0m43Wbvc YrFpiXm4k7zvlYyxEHP+SZ/D/S4kXx1kHzcGy2/tKyWq+DqXErKTyqWqKy8iBRL0PB2aq69VoYM EUgnwzfwE3uR6KovZfH+4= X-Google-Smtp-Source: AGHT+IH/jWTFHh9aKpcCWJvmgpXyHpzOKiaHuKZDq/cY0kpC+Nuc21cAjdAdX+5mcEWPkyyHNGr6Gw== X-Received: by 2002:a05:600c:474a:b0:46e:2801:84aa with SMTP id 5b1f17b1804b1-4778fe003ecmr21077485e9.0.1763113565466; Fri, 14 Nov 2025 01:46:05 -0800 (PST) Received: from [192.168.1.187] ([161.230.67.253]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47787e45677sm143331965e9.8.2025.11.14.01.46.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Nov 2025 01:46:05 -0800 (PST) Message-ID: <34af5576a5e779a279975dd9fb8be7c2b233f661.camel@gmail.com> Subject: Re: [PATCH] pwm: adp5585: correct mismatched pwm chip info From: Nuno =?ISO-8859-1?Q?S=E1?= To: Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= , ziniu.wang_1@nxp.com Cc: laurent.pinchart@ideasonboard.com, nuno.sa@analog.com, lee@kernel.org, linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev Date: Fri, 14 Nov 2025 09:46:43 +0000 In-Reply-To: References: <20251114065308.2074893-1-ziniu.wang_1@nxp.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Fri, 2025-11-14 at 10:30 +0100, Uwe Kleine-K=C3=B6nig wrote: > Hello, >=20 > On Fri, Nov 14, 2025 at 02:53:08PM +0800, ziniu.wang_1@nxp.com=C2=A0wrote= : > > From: Luke Wang > >=20 > > The register addresses of ADP5585 and ADP5589 are reversed. >=20 > My German feeling for the English language suggests: > s/reversed/swapped/. >=20 > > Fixes: 75024f97e82e ("pwm: adp5585: add support for adp5589") > >=20 > > Signed-off-by: Luke Wang > > --- > > =C2=A0drivers/pwm/pwm-adp5585.c | 4 ++-- > > =C2=A01 file changed, 2 insertions(+), 2 deletions(-) > >=20 > > diff --git a/drivers/pwm/pwm-adp5585.c b/drivers/pwm/pwm-adp5585.c > > index dc2860979e24..806f8d79b0d7 100644 > > --- a/drivers/pwm/pwm-adp5585.c > > +++ b/drivers/pwm/pwm-adp5585.c > > @@ -190,13 +190,13 @@ static int adp5585_pwm_probe(struct platform_devi= ce *pdev) > > =C2=A0 return 0; > > =C2=A0} > > =C2=A0 > > -static const struct adp5585_pwm_chip adp5589_pwm_chip_info =3D { > > +static const struct adp5585_pwm_chip adp5585_pwm_chip_info =3D { > > =C2=A0 .pwm_cfg =3D ADP5585_PWM_CFG, > > =C2=A0 .pwm_offt_low =3D ADP5585_PWM_OFFT_LOW, > > =C2=A0 .pwm_ont_low =3D ADP5585_PWM_ONT_LOW, > > =C2=A0}; > > =C2=A0 > > -static const struct adp5585_pwm_chip adp5585_pwm_chip_info =3D { > > +static const struct adp5585_pwm_chip adp5589_pwm_chip_info =3D { > > =C2=A0 .pwm_cfg =3D ADP5589_PWM_CFG, > > =C2=A0 .pwm_offt_low =3D ADP5589_PWM_OFFT_LOW, > > =C2=A0 .pwm_ont_low =3D ADP5589_PWM_ONT_LOW, >=20 > I wonder how that didn't pop up during development of 75024f97e82e. I > would expect that the driver doesn't work correctly in a very obvious > way without this change?! I tend to want to send this to Linus before > 6.18, but the question makes me wonder if I'm correct with that > urgency. Any insights? Yeah, this one I kind of asked for Liu to test it (as I was not testing the= PWM bits) and he did tested it [2]. But it was v2 and that series had some more itera= tions. So I suspect that I messed up along the way and the last version of the series= was not tested (for the PWM bits). [2]: https://lore.kernel.org/linux-gpio/3efb68e2-7091-47e1-81a2-39930da5a42= 7@nxp.com/ - Nuno S=C3=A1 =20 >=20 > Best regards > Uwe