From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 499E1432BCE for ; Mon, 20 Jul 2026 15:47:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784562458; cv=none; b=DO/A3mnI2diugvUwiAj5N5pof/rCnA9XLj9nHHf9OVQLs6VS7izaHw40A1gZbYD8RVTw+yg+cTVOgfPru6baO36JlY6bMeE+wZvezGca/ABxgI9l6m+aMjwataSDvCOauNDNE40HZrKgH9QJgeXp0Bny+MCXIeRYxVRlMKOuxkA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784562458; c=relaxed/simple; bh=6lATRFPxTxT8XD806au+dhBs7SL2lPkrnjUO8GWkEAU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=csjfIXglo9vBymEr4PgCzmQ1La5iN1P5oIzw1l4haEUe8pX6jjR99hDozGNYl03E8RRzcze2eUTmdlGa4DVBzzKOrpYjEohQbfLR1KloX2L9vRujszWmh8EtMw5MuLytrzRzyzdAylwad2ad6qMbuqLDUP5DtY2b6CxS9yR4xHQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CLul07nl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Oq5yNzW3; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CLul07nl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Oq5yNzW3" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66KFLVEF2957764 for ; Mon, 20 Jul 2026 15:47:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= P8ECtc/MvhpkV2EQxc5dreSw9c9e9tz4Nmib+ihrXVQ=; b=CLul07nlOyGdApoQ l42NO8/xTkYrBsBoxz8r5jkgyBwNZswyduQMqfQ3WZY9hupTlwl6605f5v6y7VTZ OZlAXP+7LTK+6f8H55Hf94w7HybiseEc4iacyJsLbBJgRJegXTvdR/B4vfoL2aTz 7HvtLMp74Wn0bOcLexAykUOccXMjHJU6+c+Xdn5LLedqehGM1/efdBAPy2/nbhyw yCzegs2F+AWOm7QIqod1Ux1lP887rwvgAIo9qkqZGHheHBqVF+QCB9Ztg0Fl1vo0 6fY39lgOoIpLGGFs9Q5PX0TIup86Shv7NYZQG1YRH+v3LBZZrAbrSXKDCgYrzIul eHpLpQ== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fhk2f92r8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 20 Jul 2026 15:47:35 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-51c9e97b626so20678421cf.1 for ; Mon, 20 Jul 2026 08:47:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784562455; x=1785167255; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=P8ECtc/MvhpkV2EQxc5dreSw9c9e9tz4Nmib+ihrXVQ=; b=Oq5yNzW33++JpiGhx5cpY76J9pcIMNdOvG+D/5Us47A90A7KAWa7gGpeBY4jMLy/tR 1SWGGd6twXbLlweA7xgfgscDDSn9EQ1jTRQbtcNWMjAsmcjr5EVJnhBvM45A7RLMGttL XW0yICA7zFid1QT79RtKzabXW2mC25CEcmUTeQ1PxVMoiYGUBnwYcqIWf2s4pRBe1Lx1 lB5TaBlz73xFcTCfDOhAPRYxupZBY1ppwExOvOYz9qeXyng+GFhNTY9PzGcEwrlbLbvL 5ypjJJIi6ZNhpLp08/Tl1zJM8yBBAxQQKejqGko6UIXaN9pHFl1sDuacTJRuB4esGKxj 8WJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784562455; x=1785167255; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=P8ECtc/MvhpkV2EQxc5dreSw9c9e9tz4Nmib+ihrXVQ=; b=qvdLeEiDCQND1aXya1RqtlpwlsQ/zzj9LmY8+idMT52lstYj2gdCyV9wK5aiSA7znB oj07LPwRTu3erwRQ1BDteRV/kwIEC1WUWV92ifXR98sUEPmx+b4JRk1xVZzHAQiHIL1N VAeAvvViVkNbBJTpU452jbSaMeibV5yy8BhHKuZ2pe3ApyXHPM23a1UD3iUqc/SIscvD 1sqTAKKBmcHOHfb7GnPsjMbowmJ1pIeBg/87bGPEbTxw+4fueKzeEF8Nk3EW0P9Ah0Ag xdZpXFuhT1qUIWLyUQDQRBHSp8xaC+/qsuhcUAccM/DAoZoTQDRv6u3Z/o1BnzJw7GZq tx+Q== X-Forwarded-Encrypted: i=1; AHgh+RoHuNH1r7U9HbmpSrLX29TIs8kxUgt1P2/b11qblddtVfI+Z2rL4MtOL/1g6kjHsFU/4MokXHkHI84UCv8=@vger.kernel.org X-Gm-Message-State: AOJu0Yzl1GHQdiSw+2Cc3stw5EHd7DCD8YNBrA7760hINeg1mpBAl+YF y/ZfSbOlizSe21cRwJYx1TPU6zdI8bJsO+taPklQAF/RaOzRrydWTN8yQR/Fvo4aFPGU7DnB2pg rj+upPNFVyJZG6RN6WjcBXsIzQOB6ToV+f9uHjiAnY9jsRFSLD8QfSpoXhF6YOLf3rUQ= X-Gm-Gg: AfdE7ckcFVYchwjD0zXlKd1REYUTh5MyifkFT7DhPA/KldGr554JOlVRbfE0bcLbWh5 OHbQgOYjG5ShjfWK2vQCipKNqPWg8EKJis+PR0iAKIsF0kRVraKcSMS5gp0Yzi60h2i7mOKYdPM kdDU7Nne04D+0+aFocjrC2sZy2jE96VtivgK+kuUTsqyC+ACmYbb10DpjKy5XXiO10tZXbRrK+O v8roW8C1Jzsta6tqTT7DhIC37e9DncRenJ1Adzk8kLB6g3l2V5Atu5zojketTmSPi3pFkUzllyo DFNOuiRpZyG1mO2SvxkXf9YTQZlUegdkkzjuZ8ZxDW1beMkSGrxlpgYv5dYUQw/KbhqPr+GjhM5 IRaIJCtQ/GUAv2FjNPr9Nu/oc X-Received: by 2002:a05:622a:987:b0:51b:fe41:4764 with SMTP id d75a77b69052e-525faca1108mr11990301cf.7.1784562455391; Mon, 20 Jul 2026 08:47:35 -0700 (PDT) X-Received: by 2002:a05:622a:987:b0:51b:fe41:4764 with SMTP id d75a77b69052e-525faca1108mr11990051cf.7.1784562454931; Mon, 20 Jul 2026 08:47:34 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1705a08490sm490061566b.21.2026.07.20.08.47.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jul 2026 08:47:34 -0700 (PDT) Message-ID: <34b0bb3b-d756-4cd6-806d-75b1124f4397@oss.qualcomm.com> Date: Mon, 20 Jul 2026 17:47:32 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] dmaengine: qcom: gpi: Fix SE ID and SE Protocol fields widths in SCRATCH_0 To: Chandana Kishori Chiluveru , Vinod Koul , Frank Li , bjorn.andersson@oss.qualcomm.com Cc: praveen.talari@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, mukesh.savaliya@oss.qualcomm.com References: <20260720-fix_se_id_and_se_protocol_fields-v1-1-e41dbb107d97@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260720-fix_se_id_and_se_protocol_fields-v1-1-e41dbb107d97@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: ZznACy0Ft0eGbRvqooYq9rsjZD1XyGqG X-Authority-Analysis: v=2.4 cv=X8xi7mTe c=1 sm=1 tr=0 ts=6a5e4318 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=4BU4YjERTYdAktGsJ0gA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIwMDE3NSBTYWx0ZWRfXxCfLsLJiAFBS pnuAKRHfKrDB+Prmkc6jWV9K8emOrfHXHKQjJC4aD4zLXVZYlhi/1oEeauL8s5Dfbkg6AhVYPIm 1KcnqoHPhwH8QTl8qjHAdCPyX2Ono/o= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIwMDE3NSBTYWx0ZWRfX1BioyP9sQt/H FayAjUehDQHIU2hDkv04Jl8wmgWPjpMS9gLfLmaL80e22twWy3ukeKEcyGOza3QC/uK72xVXrwc /NXLvIstwn0KTmIqZNHL+GztQsmQwf5KuCSlsy7wZBfTRtAPs12vpVs0UDtIdQTjxSMZg0Qf24N 2lM5pZxwbdDF2SUBuFHZYXLwqgPIW1tcBkCkiEoRJNPvAU6DlRXmZJa2jiaHXSMKPly4/CdAqOp YxbO8p432r+lHsR9YSS8lAflJI4EaCDCLOoc2XGlPGleP9Dxlbs7n44+Y+w7FCJUoGNSNR6Pm0R d825vwHSeR+bbCr1nNnY+h0DxWk5FlSiKA52u2sSH5t8+6v3SXTsROh5k7a3VktZHmKjQeaCi2Q k1enlT9BUdgk79NFgvIjhHBtYgqQRKiwoG9YMT12iLO+duiSJsIvM6Jv0zmCxY6R/5SQMhCOAAw eMX0ybkIDcvkE+0xyrQ== X-Proofpoint-GUID: ZznACy0Ft0eGbRvqooYq9rsjZD1XyGqG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-20_03,2026-07-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 phishscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 adultscore=0 clxscore=1015 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607200175 On 7/20/26 5:27 PM, Chandana Kishori Chiluveru wrote: > GPII_n_CH_k_SCRATCH_0_SEID is currently defined as GENMASK(2, 0), only > 3 bits wide. Serial engine indices >= 8 get silently truncated by > FIELD_PREP()/u32_encode_bits() when written into the scratch register, > causing the GPI channel to bind to the wrong serial engine. The > channel allocate command still succeeds (it doesn't require the > target SE to respond), but the subsequent channel start command times > out waiting for hardware to complete the handoff to the (incorrectly > bound) SE, and gpi_send_cmd() returns -EIO leading to GSI usecase failures > for SE8 and SE9 serial engines. > > Older documentation, such as the SDM845 hardware programming guide, > describes the SE ID field as bits [2:0]. More recent QUP hardware > documentation defines the field as bits [3:0]. Use the wider definition > to match current hardware documentation while remaining compatible with > existing platforms and enabling serial engine IDs greater than 7. > > Also update the SE Protocol field definition to match the documented > register layout and keep both fields correctly packed. > > Fixes: 5d0c3533a19f ("dmaengine: qcom: Add GPI dma driver") > Signed-off-by: Chandana Kishori Chiluveru > --- > drivers/dma/qcom/gpi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c > index a5055a6273af..8f09eaf4e714 100644 > --- a/drivers/dma/qcom/gpi.c > +++ b/drivers/dma/qcom/gpi.c > @@ -207,8 +207,8 @@ enum CNTXT_OFFS { > > /* Scratch registers */ > #define GPII_n_CH_k_SCRATCH_0_OFFS(n, k) (0x20060 + (0x4000 * (n)) + (0x80 * (k))) > -#define GPII_n_CH_k_SCRATCH_0_SEID GENMASK(2, 0) > -#define GPII_n_CH_k_SCRATCH_0_PROTO GENMASK(7, 4) > +#define GPII_n_CH_k_SCRATCH_0_SEID GENMASK(3, 0) > +#define GPII_n_CH_k_SCRATCH_0_PROTO GENMASK(6, 4) There exist protocols, such as QSPI with id=9, so this surely can't be right (unless there's another bitfield for that?) Konrad