From: Aurabindo Pillai <aurabindo.pillai@amd.com>
To: Tom Rix <trix@redhat.com>,
harry.wentland@amd.com, sunpeng.li@amd.com,
Rodrigo.Siqueira@amd.com, alexander.deucher@amd.com,
christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@linux.ie,
daniel@ffwll.ch, Qingqing.Zhuo@amd.com,
mario.limonciello@amd.com, nicholas.kazlauskas@amd.com,
maira.canal@usp.br
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/amd/display: change to_dal_irq_source_dnc32() storage class specifier to static
Date: Mon, 27 Jun 2022 09:20:13 -0400 [thread overview]
Message-ID: <34b5c26c-bf3f-4b7c-3dd8-9e1317968c28@amd.com> (raw)
In-Reply-To: <20220626144615.2227149-1-trix@redhat.com>
On 2022-06-26 10:46, Tom Rix wrote:
> sparse reports
> drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn32/irq_service_dcn32.c:39:20: warning: symbol 'to_dal_irq_source_dcn32' was not declared. Should it be static?
>
> to_dal_irq_source_dnc32() is only referenced in irq_service_dnc32.c, so change its
> storage class specifier to static.
>
> Fixes: 0efd4374f6b4 ("drm/amd/display: add dcn32 IRQ changes")
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c b/drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c
> index 3a213ca2f077..b1012fa1977b 100644
> --- a/drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c
> +++ b/drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c
> @@ -36,7 +36,7 @@
>
> #define DCN_BASE__INST0_SEG2 0x000034C0
>
> -enum dc_irq_source to_dal_irq_source_dcn32(
> +static enum dc_irq_source to_dal_irq_source_dcn32(
> struct irq_service *irq_service,
> uint32_t src_id,
> uint32_t ext_id)
Reviewed-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
next prev parent reply other threads:[~2022-06-27 13:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-26 14:46 Tom Rix
2022-06-27 13:20 ` Aurabindo Pillai [this message]
2022-06-27 21:43 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34b5c26c-bf3f-4b7c-3dd8-9e1317968c28@amd.com \
--to=aurabindo.pillai@amd.com \
--cc=Qingqing.Zhuo@amd.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maira.canal@usp.br \
--cc=mario.limonciello@amd.com \
--cc=nicholas.kazlauskas@amd.com \
--cc=sunpeng.li@amd.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®