From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752466AbdBFUKI (ORCPT ); Mon, 6 Feb 2017 15:10:08 -0500 Received: from mail-out.m-online.net ([212.18.0.10]:33492 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752353AbdBFUKH (ORCPT ); Mon, 6 Feb 2017 15:10:07 -0500 X-Auth-Info: L0OdZrtSAhtctH0xLDE2THXwAWrg5+FeUJukyJmIUYU= Subject: Re: [PATCH -next] drm: mxsfb: fix error return code in mxsfb_load() To: Wei Yongjun , David Airlie References: <20170205160036.7364-1-weiyj.lk@gmail.com> Cc: Wei Yongjun , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org From: Marek Vasut Message-ID: <34b860df-1790-dc2f-efde-12bf3d910a79@denx.de> Date: Mon, 6 Feb 2017 19:53:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170205160036.7364-1-weiyj.lk@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/05/2017 05:00 PM, Wei Yongjun wrote: > From: Wei Yongjun > > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Signed-off-by: Wei Yongjun Acked-by: Marek Vasut > --- > drivers/gpu/drm/mxsfb/mxsfb_drv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c > index cdfbe02..28a75cb 100644 > --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c > +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c > @@ -221,6 +221,7 @@ static int mxsfb_load(struct drm_device *drm, unsigned long flags) > mxsfb->fbdev = drm_fbdev_cma_init(drm, 32, > drm->mode_config.num_connector); > if (IS_ERR(mxsfb->fbdev)) { > + ret = PTR_ERR(mxsfb->fbdev); > mxsfb->fbdev = NULL; > dev_err(drm->dev, "Failed to init FB CMA area\n"); > goto err_cma; > > > -- Best regards, Marek Vasut