From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6ADAC48CD2; Wed, 10 Jan 2024 13:48:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="hvxRyBv2" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1704893918; bh=SgeTmy9vWKtca0Vyjva4J6wsQuy5/arJ5kyVli3Wyhc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=hvxRyBv2rN52qUOdhsThMmZY46Lu8JPBT67MHEWZGEdwDVv2zjhDaMeApPxWzVSg5 MXSdj9XvLeuHPnm5OrW7W+xrHYTkJf3lG76WzvoqeU+63BFuq27oOZkIYNn8IBhDUN 9EIBF3iNk7GpA8bobjb3TKIYkyfGb9IGHrK3WPCs4EfYLY8wzgMyzCYwUqm5HJtN32 lSgVcm+ReFE9eX+UVtMCUviOI9Y0DicPifaw6hj+sLT/vZX6n8ZB2bqgfRlkmWm6aw 5kFVW/g07pLX1sr/qL7aCUh74zOdWb5zO10ILCyRong6SiOJl1hN4tbumiIILWdR2Z KM5ScTEWWNigQ== Received: from [100.113.186.2] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 1AE913780C1F; Wed, 10 Jan 2024 13:38:37 +0000 (UTC) Message-ID: <34bda5e0-0587-459b-b31c-46112b1b10fa@collabora.com> Date: Wed, 10 Jan 2024 14:38:36 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] arm64: dts: mediatek: Add initial MT7981B and Xiaomi AX3000T Content-Language: en-US To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Matthias Brugger , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Daniel Golle , Hsin-Yi Wang , =?UTF-8?Q?N=C3=ADcolas_F_=2E_R_=2E_A_=2E_Prado?= , jason-ch chen , Macpaul Lin , Sean Wang , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= References: <20240110095118.25598-1-zajec5@gmail.com> <20240110095118.25598-2-zajec5@gmail.com> From: AngeloGioacchino Del Regno In-Reply-To: <20240110095118.25598-2-zajec5@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Il 10/01/24 10:51, Rafał Miłecki ha scritto: > From: Rafał Miłecki > > MT7981B (AKA MediaTek Filogic 820) is a dual-core ARM Cortex-A53 SoC. > One of market devices using this SoC is Xiaomi AX3000T. > > This is initial contribution with basic SoC support. More hardware block > will get added later. Some will need their bindings (like auxadc). > > Signed-off-by: Rafał Miłecki > --- > arch/arm64/boot/dts/mediatek/Makefile | 1 + > .../dts/mediatek/mt7981b-xiaomi-ax3000t.dts | 15 +++ > arch/arm64/boot/dts/mediatek/mt7981b.dtsi | 108 ++++++++++++++++++ > 3 files changed, 124 insertions(+) > create mode 100644 arch/arm64/boot/dts/mediatek/mt7981b-xiaomi-ax3000t.dts > create mode 100644 arch/arm64/boot/dts/mediatek/mt7981b.dtsi > > diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile > index 0a189d5d8006..8bff11acfe1f 100644 > --- a/arch/arm64/boot/dts/mediatek/Makefile > +++ b/arch/arm64/boot/dts/mediatek/Makefile > @@ -8,6 +8,7 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt6797-evb.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt6797-x20-dev.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-rfb1.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-bananapi-bpi-r64.dtb > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7981b-xiaomi-ax3000t.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc.dtbo > dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nand.dtbo > diff --git a/arch/arm64/boot/dts/mediatek/mt7981b-xiaomi-ax3000t.dts b/arch/arm64/boot/dts/mediatek/mt7981b-xiaomi-ax3000t.dts > new file mode 100644 > index 000000000000..a314c3e05e50 > --- /dev/null > +++ b/arch/arm64/boot/dts/mediatek/mt7981b-xiaomi-ax3000t.dts > @@ -0,0 +1,15 @@ > +// SPDX-License-Identifier: GPL-2.0-only OR MIT > + > +/dts-v1/; > + > +#include "mt7981b.dtsi" > + > +/ { > + compatible = "xiaomi,ax3000t", "mediatek,mt7981b"; > + model = "Xiaomi AX3000T"; > + > + memory@40000000 { > + reg = <0 0x40000000 0 0x10000000>; > + device_type = "memory"; > + }; > +}; > diff --git a/arch/arm64/boot/dts/mediatek/mt7981b.dtsi b/arch/arm64/boot/dts/mediatek/mt7981b.dtsi > new file mode 100644 > index 000000000000..ce878ad55204 > --- /dev/null > +++ b/arch/arm64/boot/dts/mediatek/mt7981b.dtsi > @@ -0,0 +1,108 @@ > +// SPDX-License-Identifier: GPL-2.0-only OR MIT > + > +#include > +#include > + > +/ { > + compatible = "mediatek,mt7981b"; > + interrupt-parent = <&gic>; > + #address-cells = <2>; > + #size-cells = <2>; > + > + cpus { > + #address-cells = <1>; > + #size-cells = <0>; > + > + cpu@0 { > + compatible = "arm,cortex-a53"; > + reg = <0x0>; > + device_type = "cpu"; > + enable-method = "psci"; > + }; > + > + cpu@1 { > + compatible = "arm,cortex-a53"; > + reg = <0x1>; > + device_type = "cpu"; > + enable-method = "psci"; > + }; > + }; > + > + oscillator-40m { > + compatible = "fixed-clock"; > + clock-frequency = <40000000>; > + clock-output-names = "clkxtal"; > + #clock-cells = <0>; > + }; > + > + psci { > + compatible = "arm,psci-0.2"; PSCI 0.2? I invite you to check a kernel log for a string like this one: `PSCIv%d.%d detected in firmware` ...because of course if it says v1.0, this should be "arm,psci-1.0". This is just a nitpick anyway, so you can already get my Reviewed-by: AngeloGioacchino Del Regno P.S.: but please, confirm or deny that PSCI thing ASAP :-) P.P.S.: For next time - I'd be happy if you could add a cover letter to your patch series..! Cheers, Angelo