From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC595C433EF for ; Wed, 20 Jul 2022 07:53:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229869AbiGTHxB (ORCPT ); Wed, 20 Jul 2022 03:53:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229461AbiGTHw6 (ORCPT ); Wed, 20 Jul 2022 03:52:58 -0400 Received: from mail1.perex.cz (mail1.perex.cz [77.48.224.245]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE08048E96 for ; Wed, 20 Jul 2022 00:52:54 -0700 (PDT) Received: from mail1.perex.cz (localhost [127.0.0.1]) by smtp1.perex.cz (Perex's E-mail Delivery System) with ESMTP id 7C44BA003F; Wed, 20 Jul 2022 09:52:52 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.perex.cz 7C44BA003F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=perex.cz; s=default; t=1658303572; bh=QBCCW4Q0CQG3BJ2QHP8R81ix3DWBDeELsQW0yXxSMLk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=hEzRLP92NLkiIRWQ5pUOaA6UneSn05B6NU//P0qsi4D8xm3ocMRnpChcWzcaEdxu1 kEgigc45qBN1PR1QJCAel2DEEd0LvrLCwFuqQZ3jCiL17NTjxshyjOOw5bFL07FuEl tSuKIq/pQsugV65FCaOONXwdvBn9NVb+wwHpt92M= Received: from [192.168.88.20] (unknown [95.168.116.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: perex) by mail1.perex.cz (Perex's E-mail Delivery System) with ESMTPSA; Wed, 20 Jul 2022 09:52:42 +0200 (CEST) Message-ID: <34bddb2f-dc57-c08c-358e-26cf7824c203@perex.cz> Date: Wed, 20 Jul 2022 09:52:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] ALSA: hda: Skip creating captures in SOF context Content-Language: en-US To: Kai-Heng Feng Cc: tiwai@suse.com, Bard Liao , Pierre-Louis Bossart , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org References: <20220719144753.252231-1-kai.heng.feng@canonical.com> From: Jaroslav Kysela In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dne 20. 07. 22 v 3:45 Kai-Heng Feng napsal(a): > On Tue, Jul 19, 2022 at 11:41 PM Jaroslav Kysela wrote: >> >> Dne 19. 07. 22 v 16:47 Kai-Heng Feng napsal(a): >>> On HP laptops that use SOF driver for DMIC, the micmute LED doesn't >>> light up when mic is muted after commit 9b014266ef8a ("ASoC: SOF: >>> topology: use new sound control LED layer"). >>> >>> The micmute LED itself is still working via sysfs, but it doesn't follow >>> mute anymore. That's because unlike vendors like Dell and Lenovo, HP >>> laptops use HDA codec to control mute LEDs instead of ACPI. So on HP >>> laptops, both SOF and HDA create captures with >>> SNDRV_CTL_ELEM_ACCESS_MIC_LED access, snd_ctl_led_set_state() considers >>> there are two different kcontrols and one of them is not muted. >> >> It does not mean that it's a wrong behavior. When both controls are muted, the >> LED should be turned on. It just requires that all inputs are off (and it may >> be the default - probably we can set in UCM or so). If you turn the "Capture >> Switch" off in amixer / alsamixer, do things work as expected ? > > Yes. When all captures are muted the micmute LED is on. > >> >>> So skip creating captures for HDA when it's called from SOF, the >>> captures are already handled by SOF. >> >> The capture controls are for other inputs like external analog microphone. If >> it is required to suppress the MIC LED for some hardware, just skip the >> "spec->mic_mute_led = 1" assignment in hda_generic.c . Also, the check >> "codec->core.type != HDA_DEV_ASOC" is not sufficient, because you don't know, >> if the topology really sets the MIC LED flag. > > AFAIK the external analog microphone on DMIC laptop is driven by SOF driver too. > If those capture controls are indeed needed for external analog mics, > use UCM to mute them by default won't work either. Could you describe this ? I though that only DMIC is handled by SOF when HDA codec is in the system. There is a separate analog codec for external analog microphone or the HDA codec is somehow connected to SOF/DSP ? If so, how ? Jaroslav -- Jaroslav Kysela Linux Sound Maintainer; ALSA Project; Red Hat, Inc.