From: Kim Phillips <kim.phillips@amd.com>
To: Vijay Thakkar <vijaythakkar@me.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: "Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Jiri Olsa" <jolsa@redhat.com>,
"Namhyung Kim" <namhyung@kernel.org>,
"Martin Liška" <mliska@suse.cz>, "Jon Grimm" <jon.grimm@amd.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v4 2/3] perf vendor events amd: add Zen2 events
Date: Mon, 16 Mar 2020 16:51:52 -0500 [thread overview]
Message-ID: <34be3999-34ef-871f-0950-089a00e5b1dd@amd.com> (raw)
In-Reply-To: <20200314044453.82554-3-vijaythakkar@me.com>
On 3/13/20 11:44 PM, Vijay Thakkar wrote:
> Signed-off-by: Vijay Thakkar <vijaythakkar@me.com>
This email address differs from patch 1/3's S-o-b:
Signed-off-by: thakkarv <thakkarv@gatech.edu>
Choose one, and please spell your whole name out - Vijay Thakkar.
> +++ b/tools/perf/pmu-events/arch/x86/amdzen2/branch.json
> @@ -0,0 +1,52 @@
> +[
> + {
> + "EventName": "bp_l1_btb_correct",
> + "EventCode": "0x8a",
> + "BriefDescription": "[L1 Branch Prediction Overrides Existing Prediction (speculative)."
Remove the leading '[' in the BriefDescription string.
Other than the above two nit picks:
Acked-by: Kim Phillips <kim.phillips@amd.com>
Thanks,
Kim
next prev parent reply other threads:[~2020-03-16 21:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-14 4:44 [PATCH v4 0/3] update to latest PMU events for zen1/zen2 Vijay Thakkar
2020-03-14 4:44 ` [PATCH v4 1/3] perf vendor events amd: restrict model detection for zen1 based processors Vijay Thakkar
2020-03-14 4:44 ` [PATCH v4 2/3] perf vendor events amd: add Zen2 events Vijay Thakkar
2020-03-16 21:51 ` Kim Phillips [this message]
2020-03-16 22:54 ` Vijay Thakkar
2020-03-14 4:44 ` [PATCH v4 3/3] perf vendor events amd: update Zen1 events to V2 Vijay Thakkar
2020-03-14 4:52 ` Vijay Thakkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34be3999-34ef-871f-0950-089a00e5b1dd@amd.com \
--to=kim.phillips@amd.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=jon.grimm@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mliska@suse.cz \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=vijaythakkar@me.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®