From: Shrikanth Hegde <sshegde@linux.ibm.com>
To: Swapnil Sapkal <swapnil.sapkal@amd.com>
Cc: mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
jolsa@kernel.org, adrian.hunter@intel.com,
thomas.falcon@intel.com, ashelat@redhat.com, yu.c.chen@intel.com,
gautham.shenoy@amd.com, ravi.bangoria@amd.com,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
namhyung@kernel.org, irogers@google.com, james.clark@arm.com
Subject: Re: [PATCH v1 0/6] perf sched stats: Fixes and improvements
Date: Wed, 28 Jan 2026 13:33:25 +0530 [thread overview]
Message-ID: <34c47190-d44c-47fc-b41a-04857054d287@linux.ibm.com> (raw)
In-Reply-To: <20260127185000.431884-1-swapnil.sapkal@amd.com>
On 1/28/26 12:19 AM, Swapnil Sapkal wrote:
> These patches contain fixes and improvements related to perf sched stats
> code. The series includes:
>
> * Bug fixes
> - Add NULL check for cd_map in perf sched stats to prevent potential
> NULL pointer dereference
> - Fix NULL check in cpumask_to_cpulist() in perf util
>
> * Code quality improvements:
> - Replace hardcoded max cpus value with MAX_NR_CPUS constant in perf
> header
> - Define SEP_LEN macro to replace magic number in perf sched stats
> - Correct spelling of function name in perf sched stats
>
> * Documentation:
> - Fix various issues in the perf sched stats man page
>
> Swapnil Sapkal (6):
> perf header: Replace hardcoded max cpus by MAX_NR_CPUS
> perf util: Fix NULL check in cpumask_to_cpulist()
> perf sched stats: Add NULL check for cd_map
> perf sched stats: correct spelling of function name
> perf sched stats: Define macro for SEP_LEN
> perf sched stats: Fixes in man page
>
> tools/perf/Documentation/perf-sched.txt | 8 +++----
> tools/perf/builtin-sched.c | 30 +++++++++++++++----------
> tools/perf/util/header.c | 5 +++--
> tools/perf/util/util.c | 2 +-
> 4 files changed, 26 insertions(+), 19 deletions(-)
>
Other than the comment in Patch 1/6, rest looks good to me.
For the series:
Reviewed-by: Shrikanth Hegde <sshegde@linux.ibm.com>
prev parent reply other threads:[~2026-01-28 8:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 18:49 Swapnil Sapkal
2026-01-27 18:49 ` [PATCH v1 1/6] perf header: Replace hardcoded max cpus by MAX_NR_CPUS Swapnil Sapkal
2026-01-28 7:39 ` Shrikanth Hegde
2026-01-28 16:25 ` Swapnil Sapkal
2026-01-28 18:13 ` Arnaldo Carvalho de Melo
2026-01-28 18:15 ` Arnaldo Carvalho de Melo
2026-01-28 18:29 ` Swapnil Sapkal
2026-01-27 18:49 ` [PATCH v1 2/6] perf util: Fix NULL check in cpumask_to_cpulist() Swapnil Sapkal
2026-01-27 18:49 ` [PATCH v1 3/6] perf sched stats: Add NULL check for cd_map Swapnil Sapkal
2026-01-27 18:49 ` [PATCH v1 4/6] perf sched stats: correct spelling of function name Swapnil Sapkal
2026-01-27 18:49 ` [PATCH v1 5/6] perf sched stats: Define macro for SEP_LEN Swapnil Sapkal
2026-01-27 18:50 ` [PATCH v1 6/6] perf sched stats: Fixes in man page Swapnil Sapkal
2026-01-28 8:03 ` Shrikanth Hegde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34c47190-d44c-47fc-b41a-04857054d287@linux.ibm.com \
--to=sshegde@linux.ibm.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=ashelat@redhat.com \
--cc=gautham.shenoy@amd.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=swapnil.sapkal@amd.com \
--cc=thomas.falcon@intel.com \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®