From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57A4FEB64DD for ; Tue, 18 Jul 2023 06:46:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230253AbjGRGqw (ORCPT ); Tue, 18 Jul 2023 02:46:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229823AbjGRGqs (ORCPT ); Tue, 18 Jul 2023 02:46:48 -0400 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E22413E for ; Mon, 17 Jul 2023 23:46:46 -0700 (PDT) Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-3fbd33a57b6so54988415e9.2 for ; Mon, 17 Jul 2023 23:46:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689662804; x=1692254804; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9MzpjYGu8uAXuw8m2JeqLMYOotZpBjXKkWslMNpPfQY=; b=dM4w6aU0rxo+mykLBhf6VgvAgnA3PZpH+EIFcFVaNVCOh/AhIIDLfWrGGipHl66yEM +1dCZKsF3WEj69NG3G+bpkfxH2o5w7pxRUzgAt8KvM993ogHrZnjDZwNmA3I4EWMyAJ6 RApAqc3Hb+Th2mdLMv9HU8NQuyL+rWq9NKcxt3/cqLHtfAHyTrilAHla2LqxaCX3PHBo tiBeDlvx8lviywZ96lrHxzTzbXLpaANhARYgkdwjzwV6nMNCvG8gJD11HAMxf3YK3U5f yg8XNtXubXx4ctTXMEZ0bwWp9r2dpo7R5ndVnTtV0JjEG9doiFczRXd/PxV+KI6hybX6 A5qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689662804; x=1692254804; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9MzpjYGu8uAXuw8m2JeqLMYOotZpBjXKkWslMNpPfQY=; b=do0LX2NHiPIkyjY6BmxCKWPpEMrTqY13bofshMMUrr99caI76M+HDWHULquIudMKoE /NYvXGvfjcb3PstFfyqn6LHXTJXcXy//O7ngx0FFZSscLyXHL7C0wgWmgGaeXtoSWXOl 2PVvLg+LD8nlcMUZZaXkT1rRhqqRR/f+U+kxloinqopWOhh2AEmbD5/0GW1XJ/wutm0s jCVqX2hepMQU6M8yHiWHFg3YZMLJiyNYKnz5AC58nwnPx/KBLroevH9wPfFMes6mQFmt NMn3nbKfwDgbUjuGAsyyPQSrML4gean4x2OqA9aeaqdSsvhXbjyoZazhZa26WVY5lIOQ NZrQ== X-Gm-Message-State: ABy/qLbR22yyhAwpHLEm/OVove1x6Ib/RCPMUNWWyO+FxylJZv+bLJ8p ztvZOkj0sy6IZIV3dGgU26f5QFiKahrM1kW2yn4= X-Google-Smtp-Source: APBJJlEMe2AWmmooDbTnb7UfuwafhIPjsltMOto2MO1y8QkVyhRmtsAr5Jo0Hvds0ickXOTjAbHVpg== X-Received: by 2002:adf:e483:0:b0:314:77a:c2b9 with SMTP id i3-20020adfe483000000b00314077ac2b9mr13966880wrm.39.1689662804690; Mon, 17 Jul 2023 23:46:44 -0700 (PDT) Received: from [192.168.69.115] ([176.187.222.251]) by smtp.gmail.com with ESMTPSA id s3-20020a5d6a83000000b003143801f8d8sm1395032wru.103.2023.07.17.23.46.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Jul 2023 23:46:44 -0700 (PDT) Message-ID: <34c52f9b-df4c-1b02-8419-b9b4fb18dd70@linaro.org> Date: Tue, 18 Jul 2023 08:46:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] KVM: x86: Fix errors & warnings in irq_comm.c Content-Language: en-US To: shijie001@208suo.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org Cc: hpa@zytor.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org References: <1b85fe6bf831ffd0b994a9703e8b06f7@208suo.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <1b85fe6bf831ffd0b994a9703e8b06f7@208suo.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/7/23 08:21, shijie001@208suo.com wrote: > ERROR: Macros with complex values should be enclosed in parentheses > > Signed-off-by: Jie Shi > --- >  arch/x86/kvm/irq_comm.c | 6 ++++-- >  1 file changed, 4 insertions(+), 2 deletions(-) > @@ -365,7 +367,7 @@ EXPORT_SYMBOL_GPL(kvm_intr_is_single_vcpu); > >  #define PIC_ROUTING_ENTRY(irq) \ >      { .gsi = irq, .type = KVM_IRQ_ROUTING_IRQCHIP,    \ > -      .u.irqchip = { .irqchip = SELECT_PIC(irq), .pin = (irq) % 8 } } The value is already enclosed in parentheses... False positive? > +      .u.irqchip = { .irqchip = SELECT_PIC(irq), .pin = ((irq) % 8) } } >  #define ROUTING_ENTRY2(irq) \ >      IOAPIC_ROUTING_ENTRY(irq), PIC_ROUTING_ENTRY(irq)