From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84965257D for ; Mon, 20 Jan 2025 07:50:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737359408; cv=none; b=OMMCXqdImsBio3iBn+s+weW6uDcInBYreYV/jwqs1gGJug723/hhIKbw3RqlXXKKHOJCgtQ2nIRd7qCJpIYznAgFiGr0JYMh37RmAlcsDYLlpyjT3U6rkw572hTdMl4Y+gzK0WbiNpMfpibW7FOtKSFpklkoYRP9uxnbrcUcEl0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737359408; c=relaxed/simple; bh=I14WiomT1aJEeiQ/oSAt25ZhqOR0rggmx8Ip7ANi0hE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=A27+y8Dvb4pDrDqrOA1ajrrcpps4NjaO3KISWmXDVFDDGFYTFixy7i5vpx1IeSwwpWNMSJm6bADHycJd8Y+iRynswJ+fe1P8DHZtJ/KiN6avFunBUkpeTJuABwYgiGn6VubC9+QeU1syEv3tHx/s8Cp1tnpyXhVgwT83WG6Nw6M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=KbmGLCd0; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KbmGLCd0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737359405; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=uubHGHZOYKVc1XOiZc6ZGTaLVbmG5dy5mGIOvRhGN14=; b=KbmGLCd0yG3pURsuebgvO9PCSYnFaz4F1jeU7AMlZvvIpY3TJWN0h1ZJyXPpIZm+34RE0J OTU4mRvRpTcx2VmVG9JJFS/zEzDoj7YxzxYxKKN+LjRLtARhY99HjWpU1eDcDJzJi/TBZK 2fU1IE7+wW4Yg+iwyoQ/aEi77solmjU= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-563-gHSb8q0INjuAbZLKxSTQLg-1; Mon, 20 Jan 2025 02:50:03 -0500 X-MC-Unique: gHSb8q0INjuAbZLKxSTQLg-1 X-Mimecast-MFC-AGG-ID: gHSb8q0INjuAbZLKxSTQLg Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-436219070b4so19594465e9.1 for ; Sun, 19 Jan 2025 23:50:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737359402; x=1737964202; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=uubHGHZOYKVc1XOiZc6ZGTaLVbmG5dy5mGIOvRhGN14=; b=ne4KhCS0rdYW36LksK/pp3mXKfn54DbZFwSPVKUeZZGL3EXLS7fBq84457jKnbdKUW zcLJTJZlbp9YDkJPhkZjxh7HCzpc/NXT7NlQX0GMyp3VA0ZMcGQrU/RzCHr+7KBg61OG LS+qOh7rqVvRE39t0QRtmkhFDC834PNHw0vJ67HI9N9YM4UzYEodiYd/6ycRSojuW2UP HXHfa5xn0DUasMxePkSUqMfbvYqwGNdFt6e+AHhB2XJLEHdQkTN24HRdoSi4kJpZakVy MTJQwMRGUifXqrfwvW6X/bxtN0xrUffcRUSQuMafA+6PMb/2pIplQG7SWLcPX3yzNRAp sNng== X-Forwarded-Encrypted: i=1; AJvYcCWRXUuK+acR/IsKfGeQRtR3BK8djVY1br9ep5iolRZXvGzNXekGs5SjN1w/zKfzYxOTRjMOuiAQO5tfsXQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxSNMZH24MMkKg7e9eVT0Geo0EkcBRFMUQQQudGmTdvaNbq6Usk JXUOYAulWtHpcmOxpH+PdEUI3m1YLRgR1pIr1r41AtyBRsCryJre4cNnNLgI5mkyYhLweX5pS2U 6HwT08sQ6BjyJdmnXFAA5pc9LzmtxXwV6+8xdttqZStkqkibfvwzJx2dTiJZc5w== X-Gm-Gg: ASbGnctCv3OJVT4dKA+oWPwv4C1/D52PSEiIPZgKKLLn9LMZPI9LSwd5gq6DHvWbjNE P/PWh0XW9uBz0R5N6HVleSiIYk44Z7pRQubVrYcNqi5+GJi4QS3cUx+O3j6aC32mXy8kIjfnGh3 CHwp8pGdLX0dJCgqQdW15UXvqekV8Ede08KLq0jCoudNS97cUYSLMjwWTrAiTgcv0RSZsewL2XN tKiJOHUbcN0hF4GO06YK3Y6WPYT/bmbJGs6ozyFXCjZxdsXRC4npm7J2L/JyIYhLk9otxcArWy5 znKZ+W0W8JcrAdqNnxcrRbJ6NDMZW5YWK+cO6sSO9ITiDiK7IK28//xhWD5Z6rldAvgklS1Tzx7 HRHDVORnakWAI+Qyncmf/6g== X-Received: by 2002:a05:600c:1987:b0:434:a7b6:10e9 with SMTP id 5b1f17b1804b1-438913e2fa9mr113951775e9.17.1737359402101; Sun, 19 Jan 2025 23:50:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IGRhQiZcCx864cqBqCtmAk+Rz1VIBg6nUspozR4BDSgvMBQ8KVQUqohtdk2nDGJJSZwRuOYUg== X-Received: by 2002:a05:600c:1987:b0:434:a7b6:10e9 with SMTP id 5b1f17b1804b1-438913e2fa9mr113951595e9.17.1737359401795; Sun, 19 Jan 2025 23:50:01 -0800 (PST) Received: from ?IPV6:2003:d8:2f22:1000:d72d:fd5f:4118:c70b? (p200300d82f221000d72dfd5f4118c70b.dip0.t-ipconnect.de. [2003:d8:2f22:1000:d72d:fd5f:4118:c70b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438904621cdsm128576665e9.27.2025.01.19.23.49.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Jan 2025 23:50:00 -0800 (PST) Message-ID: <34ccd133-7623-4cd8-aad7-08526a97c472@redhat.com> Date: Mon, 20 Jan 2025 08:49:59 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] mm: memory-failure: update ttu flag inside unmap_poisoned_folio To: Miaohe Lin , Wupeng Ma Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, osalvador@suse.de, nao.horiguchi@gmail.com, mhocko@suse.com References: <20250116061657.227027-1-mawupeng1@huawei.com> <20250116061657.227027-2-mawupeng1@huawei.com> <21674fcc-bd5d-3e32-6e45-f0a16ab93202@huawei.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <21674fcc-bd5d-3e32-6e45-f0a16ab93202@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit >> if (folio_test_hugetlb(folio) && !folio_test_anon(folio)) { >> struct address_space *mapping; >> >> @@ -1572,7 +1598,7 @@ void unmap_poisoned_folio(struct folio *folio, enum ttu_flags ttu) >> if (!mapping) { >> pr_info("%#lx: could not lock mapping for mapped hugetlb folio\n", >> folio_pfn(folio)); >> - return; >> + return -EBUSY; >> } >> >> try_to_unmap(folio, ttu|TTU_RMAP_LOCKED); >> @@ -1580,6 +1606,8 @@ void unmap_poisoned_folio(struct folio *folio, enum ttu_flags ttu) >> } else { >> try_to_unmap(folio, ttu); >> } >> + >> + return folio_mapped(folio) ? -EBUSY : 0; > > Do we really need this return value? It's unused in do_migrate_range(). I suggested it, because the folio_mapped() is nowadays extremely cheap. It cleans up hwpoison_user_mappings() quite nicely. Any particular reason we shouldn't be doing that? -- Cheers, David / dhildenb