From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CBA0322B63 for ; Fri, 23 Jan 2026 11:09:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769166583; cv=none; b=mx58HczuPwcDHJe1cbx7ud/HaaYMIdx6goXadxY3njMTSFeMW1XLGHcNeUXgvaaXW4IWSu7huLh9JOJLT/EIPJ5R4pMLfSV3DsfPG2Y7j4rVFgUzaKl+qkAkwOvvmrwVF+/D9o7gE3OY5rdt1PQQlzHX/aMbGJqostT9xZJNHak= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769166583; c=relaxed/simple; bh=xbUf5FSd3RGLMyp4pwto3xlILvjlfs6fnWPMVV4Z2nM=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=gU3sAvVWj6bhgaT9Gc9qA1Sb6LtaVCvDSGw4T0WCE+1UVp2QlLPUSAUG0j+9QAdsROE3W9xTfHPM+mvj670M/DAgSULf0TopByQEMbU+GhGdRpjeqjxBYULhSSzThJiEEGd/uI76olpchsywgI06JLdI/ugXi/6wGR1d+e5fCPs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=TYqfsmjN; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="TYqfsmjN" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-432d256c2e6so2065284f8f.3 for ; Fri, 23 Jan 2026 03:09:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1769166578; x=1769771378; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:organization :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=xbUf5FSd3RGLMyp4pwto3xlILvjlfs6fnWPMVV4Z2nM=; b=TYqfsmjNQpksOzXdeneMvXh+O6bDM8nH5xF1BX3r1OCsHSjeZKEb+fExifa4yrp5T/ /MNQEicib6EWRcV1cQIxjcaGGr/ttroc2ceo4H6fBfbkb+soZ3ydcZ9twrRhE7+lHXLI DBngFoaJ2tBwIlTUpmkyi70XLH486JbmDQShlbBKYLYUirgP7tvp2YOkYvFRsbT60UuS +9CIu3MdcA4Gb/hKGQX5tx3pIpfK6zvdSv9aF7cjB7GnwHc8oKHYiNsL2mjXAXMNYBAP 3WCe8IidTW+OEYZzH+28RN6s2yloSHGcT61QeEI1Hh90nEaFxMgYvRYtFPqNe79yElpI ZSsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769166578; x=1769771378; h=mime-version:user-agent:content-transfer-encoding:organization :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xbUf5FSd3RGLMyp4pwto3xlILvjlfs6fnWPMVV4Z2nM=; b=mlAcfxdG/HzQRB7darJ6JFNqwCEBJoxpXxgrBNnV1SNt3KY30IA5YKW6GsXlOS5hm1 IyCt/bHjUvVsgLsUTuUs6teRfrPG2MARxUbsxYGT9l62nZ57ygziUGkGc7kDfHWyj+B2 S+Ovxs0jy56JeMswwb4HSpQk//RFU1jYxHefFIVd/N8g97wsqkAwtWsPlShPD51P2g40 S/9o3Fb9v6h0cOVJUoApjBcenr5ddCGDj1FWrEyLhk9MTNtJz3APfF1yeJb1iOL1qKbb 0fcS5E1cKmH/GZeJxV5DaHjeVNKiQ/lTfP0s1jJo50xeYQLVFN6ZppmLKdHi2eAvQzMU QzmQ== X-Forwarded-Encrypted: i=1; AJvYcCVvJsEsMY4lFIx0Y/knPbGpd/5RqG1WgqSgLDNJbzx9M/7JbnIWAD64XDOxafwtGy8qFQYTZWTfONGG3HU=@vger.kernel.org X-Gm-Message-State: AOJu0YyiyeMFNY12mpy0nnpyakAQk3k6nxhrO3XL7AvBHBCGGl/IOIug 0RKKafY9o40dp1QG0G7dvteE1eoOcdkc7XI+emqF1dxVEbu15fsCD3hORftxik1WbUA= X-Gm-Gg: AZuq6aKrxiDuFwVJmFJiB5BVXS02/4AXSEsd13uHVNxRf7pel/Vv05+TeFt28D0fQzB y5vwG0dPT5knjboXn5j+72tzHVROd2flwkUI02NHU4coS4VMnKt75rC4TkirJtdyabq7+74weSD gZO1xAcqZ4enfNtJ/RVCsgDSrynVCK+dmZ51spxdLM9V60BnfO+tC3zYmDmoap4i/GkLjFQlauK RNP6+4IODN3z/i7WZaDprbawfnP3okdyqnAQKC/g5H8aqLPvZOGagBiVBVNZ3NhrYSnQejBaOVU HonUmPJxQfssMvBgp+giVlY8XYWBeUafNYWNmAAR4NLBpa5FtC5f19+EtlM61YPDOgifOP8kjLU DJArPgmWCEw3sdhz5/flktGjymJIEkBJhGk0ZmubwqULUh9e4cheEqV7ExZPoi4DoNISV X-Received: by 2002:a05:6000:2505:b0:430:f742:fbb9 with SMTP id ffacd0b85a97d-435b15952c2mr4262892f8f.23.1769166578378; Fri, 23 Jan 2026 03:09:38 -0800 (PST) Received: from [10.203.83.237] ([151.19.16.90]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435b1c02ba3sm5959916f8f.2.2026.01.23.03.09.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jan 2026 03:09:38 -0800 (PST) Message-ID: <34d7983a594b40d6d98dce02c1cff843f689a275.camel@baylibre.com> Subject: Re: [PATCH v2 2/2] iio: accel: adxl380: Optimize reading of FIFO entries in interrupt handler From: Francesco Lavra To: Jonathan Cameron , Andy Shevchenko Cc: Ramona Gradinariu , Antoniu Miclaus , Lars-Peter Clausen , Michael Hennerich , David Lechner , Nuno =?ISO-8859-1?Q?S=E1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 23 Jan 2026 12:09:36 +0100 In-Reply-To: <20260123095417.31b11fd6@jic23-huawei> References: <20260119102317.1565417-1-flavra@baylibre.com> <20260119102317.1565417-3-flavra@baylibre.com> <20260122195313.53fde73c@jic23-huawei> <20260123095417.31b11fd6@jic23-huawei> Organization: BayLibre Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Fri, 2026-01-23 at 09:54 +0000, Jonathan Cameron wrote: > On Fri, 23 Jan 2026 10:13:16 +0200 > Andy Shevchenko wrote: >=20 > > On Thu, Jan 22, 2026 at 07:53:13PM +0000, Jonathan Cameron wrote: > > > On Mon, 19 Jan 2026 11:23:17 +0100 > > > Francesco Lavra wrote: > > > =C2=A0=20 > > > > In order to minimize the time required for transferring FIFO data > > > > from the > > > > sensor to the host machine, perform the read from the FIFO in a > > > > single call > > > > to regmap_bulk_read().=C2=A0=20 > >=20 > > > It's a call to regmap_noinc_read()=C2=A0 not regmap_bulk_read() > > > I'll fix it.=C2=A0=20 > >=20 > > This is interesting, does it mean the patch was never tested on the > > real HW? The driver has been tested (by me) on real hardware, both before and after this patch. > > Or maybe noninc is intentional? > >=20 > It's absolutely intentional.=C2=A0 The device presents a single register > address > that has the fifo behind it (which is what we added noinc for years ago). > So patch should definitely work.=C2=A0 Goes from reading that register N = times > in > each call within a loop of M to reading it N x M. >=20 > If regcache is in use this makes a difference as avoids corrupting > registers > after this point as the address increment expected in the hardware for > a bulk read doesn't happen.=C2=A0 Without regcache it's just "documentati= on" > as > at least for protocols used here its the same as a bulk read on the bus. >=20 > So patch is fine, it just mentioned the wrong call in the description > I'd guess this is because someone is working with a tree that has the > wrong call in > it but might be wrong. I have this patch applied also to older kernel versions where regmap_noinc_read() doesn't exist, so this is just a copy-paste error in the commit message. Sorry about that.