From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAF86C4332F for ; Wed, 14 Dec 2022 02:12:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237069AbiLNCM6 (ORCPT ); Tue, 13 Dec 2022 21:12:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236997AbiLNCMx (ORCPT ); Tue, 13 Dec 2022 21:12:53 -0500 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9F7F21832 for ; Tue, 13 Dec 2022 18:12:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670983972; x=1702519972; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=ZmK/KU5tTbZX8ybLUypBojUhuMY9rkggoufgf9gLQOk=; b=HK10/Xl+qxBH/W8sUy+krIskNqeiDnBgmf/i67XpRGp0Z6GgBOQQerrl Y4j9PI/tY7q/5JtODCXBWq8uVDowI/9L2gVy5mqrJw838ykLovqd8otum fcHjddptXsBInHDjvcwcomneNU80IXYvJ551SWUJr7EOjeApPpszqBGYz peuoQWXqRedrGtW2/lpyozr8/uzE83v0Q4dd4qLafhbz+quSklZoDaNrb N7KTKEmuUMGxRhHrSK772yFMDBSqMMHAn9C+g3UoQ/ye1b67em0tNuoIs /nKYWKPOlMO58VY6prR0NPaz9V4u3xNO9/zoqpG1I63iTA43x1aK1QAgi Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10560"; a="404561370" X-IronPort-AV: E=Sophos;i="5.96,243,1665471600"; d="scan'208";a="404561370" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2022 18:12:52 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10560"; a="894106998" X-IronPort-AV: E=Sophos;i="5.96,243,1665471600"; d="scan'208";a="894106998" Received: from emanneba-mobl.amr.corp.intel.com (HELO spandruv-desk1.amr.corp.intel.com) ([10.212.199.244]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2022 18:12:51 -0800 Message-ID: <34d950e1e11dc91281adf3d2e8bb52645b4a7d6e.camel@linux.intel.com> Subject: Re: thermal throttling on xps13: unchecked MSR access error From: srinivas pandruvada To: Linus Torvalds , "Rafael J. Wysocki" Cc: Ricardo Neri , Linux Kernel Mailing List , the arch/x86 maintainers Date: Tue, 13 Dec 2022 18:12:51 -0800 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Linus, Sorry about the issue. On Tue, 2022-12-13 at 16:35 -0800, Linus Torvalds wrote: > Hmm. > > I don't think I've seen this before on my trusty old x86 laptop (XPS > 13 9380 - it's a few years old) > >     unchecked MSR access error: WRMSR to 0x1b1 >       (tried to write 0x0000000004000aa8) >       at rIP: 0xffffffff8b8559fe (throttle_active_work+0xbe/0x1b0) > You got a (PROCHOT#) throttling event. > I'm blaming one of > >   930d06bf071a ("thermal: intel: Protect clearing of thermal status > bits") >   6fe1e64b6026 ("thermal: intel: Prevent accidental clearing of HFI > status") > This is to blame. I am able to reproduce on an old system. I sent a patch " thermal: intel: Don't set HFI status bit to 1" Please check. Thanks, Srinivas > with no real reason apart from being the last commit to touch that > function, but also when it started happening. > > The first kernel I see this for is 6.1.0-03225-g764822972d64, but > honestly, it's possible that it has happened before too, and the real > issue is that the machine just happened to be hot and throttling at > bootup and/or I just didn't notice. > > The CPU in this thing is a > >   Intel(R) Core(TM) i7-8565U CPU @ 1.80GHz > > which hopefully makes somebody go "Ahh, yes, I missed that case". > > I don't *think* the MSR access checking has changed, but maybe it > did, > and I'm barking up the wrong tree. > > Anybody? > >                  Linus