From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8227238D52 for ; Sun, 21 Jun 2026 22:13:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782080007; cv=none; b=X4FcXs26MQUH7bXYG+HdySlFHEydEmG9O5J1LzZePfLDsCZ6cFZvJW6Rqv1W7O01Gr+hggEHQd5snWpJjoO1+2UU2ntL3RhHgm1xDjuVFpwa/usEAPaZAb7VUfz/R18B6qmz9UsWLJVI0LEczVwr5YYhu9K8KK27mQHdEmEAijk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782080007; c=relaxed/simple; bh=ORBVxfRpmLiudfyTMDa019f9ckGkexsE/k+OVh7I3dc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Lj4qDnS98DgNUr5HNmgc02Ag26Bve9YdzQNzyIea2/hSEMm+nwQFfraCYofWXMglmnA+0CsiG3BUE+uwXPJg9QbFZiyO3fJlqZ489d5+WnMTjyu+80m/KDkQWN0rMqjNaYLC2Obv/ppgDFe0AJovzFlV3xgv4j1RHPmOv/GlfSo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=U3/Q3cAZ; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="U3/Q3cAZ" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-490b211ee6aso25558285e9.3 for ; Sun, 21 Jun 2026 15:13:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782080004; x=1782684804; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=B5ShssB+JZOjy0sh3g4Pr8XZkwmz2AKN1oirgDDzG8A=; b=U3/Q3cAZfnzuzzAa/ai4GYIW+keqPKlY8oid/nxvVCVGXTGQ97snFuimchNpvfaWZv I69EOjoK/C5uiMLvfS/uWwp1H8O+rJAtQfQoalJd4dCxU2u3qgcxr22Ehxm9PvKVOz4b R90D+8vYQlic1F9Jpe+LxCtBiJz5chTs5r3iucqwUun6Urd8D2SAlZMx9utbgbjKfZAl JGBw9xMR4zuqREk1/gBvnY6pB71i6dc6jkxCxYQkNwbxAMZDlQivY51gwBoN5EGKVC1N fzYxtCVMSeP6o/a5/fUBQMkfzU9Rgjfltl4fRwmOG5uQlvsz8XnY48Bhpxaj5pR1W6uJ oPnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782080004; x=1782684804; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=B5ShssB+JZOjy0sh3g4Pr8XZkwmz2AKN1oirgDDzG8A=; b=Oq6Z9E5OKimBeb7hb6uP0ZDnNQN9q+iVJCAOuAPDg/aH051Nmo71jDBHkt3U5mweYf JKVianbHA3J843uvmH8MqIFB2IO1/OcWcAE3yW6E32VqmMNd9ZQcszsgIG9D5ovPOcyl CDDnAjjwoOgs9c+DWXWcR35UbZ4wFeH29fG+aiN8U7WA7yssijQ7F6qIluoQV/AgBqoi X9lkeBXn0vtQby1gW2NWbBDlkV96gwDIChfchWTiPUiqw7JTueS4YDN+XoCNPUpfZH6t a/T5FSG35ka2cYF2ZLy66ar5N1KzG8PbdYCwnkuwlJSNDFthyzWX4tq9joA8eVcCmAWn AYcw== X-Gm-Message-State: AOJu0Yy4SfY6Qh4JQBuvm8Ekxkp4dmofKFx0N8AJJllk+kzdi9BLR3Si +KW6GzkdrL7s7uVHPVxWSLb5MvvDL4CNiqDgeuGmTCvS/Jbp1FAY5/ufay87HjjM52uC0Ps0ug8 r7ywe X-Gm-Gg: AfdE7ckT1MEP3qrugTJKxMeiVBo2L7+DqzxgZoHTiWKFyfe6Plx1ReHOK64mghykX7f CTY8YDZDIZDEk8JsMJzk7Bp3M4Q8KDymjr0CMJejtZlmsEMaWbFxaRvTuSIM95IqCih0mb8xDSq Apf9Ycunbv4/9FruAoDOfjRarglvhgwTEKnxTDKoGZf5Ay9QvS7rnuEsErw1sABu4A/i5Gn8EUi 9WIN5IVxWas8eI8RcUyRliaoAepbSFZgSHMSJwyb/d840wltNEzXe9BAn0l3prkbbW7CfRXXNXb 5y+a3zLWZl9K83pvNkY8FdNoEdJcwp935bMHICUq1CgWzJ9s8A5hL4tkddiNkAsFIlu360SDrne rDsMD8T+0x81SQ72k93uUrsg2XCG6zeL5gFJUQRHElCIP/YMV96wgom0vtzkjYy32AKG8D4NTY+ 4+yWE9YiCPG5gB6f2rk0ShJ1Q/N4t4fQKJuZ4LIg== X-Received: by 2002:a05:600d:8489:10b0:490:e243:4806 with SMTP id 5b1f17b1804b1-49240e36652mr152237535e9.9.1782080004435; Sun, 21 Jun 2026 15:13:24 -0700 (PDT) Received: from [192.168.0.20] (nborisov.ddns.nbis.net. [185.218.67.109]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-46666c57b8asm20903811f8f.26.2026.06.21.15.13.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 21 Jun 2026 15:13:24 -0700 (PDT) Message-ID: <34d9fd50-0e35-4dae-8610-4caba75e76c3@suse.com> Date: Mon, 22 Jun 2026 01:13:22 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86/cpu: Hide and rename static_cpu_has() To: Borislav Petkov , X86 ML Cc: LKML , "Borislav Petkov (AMD)" References: <20260620015041.336288-1-bp@kernel.org> From: Nikolay Borisov Content-Language: en-US Autocrypt: addr=nik.borisov@suse.com; keydata= xsFNBGcrpvIBEAD5cAR5+qu30GnmPrK9veWX5RVzzbgtkk9C/EESHy9Yz0+HWgCVRoNyRQsZ 7DW7vE1KhioDLXjDmeu8/0A8u5nFMqv6d1Gt1lb7XzSAYw7uSWXLPEjFBtz9+fBJJLgbYU7G OpTKy6gRr6GaItZze+r04PGWjeyVUuHZuncTO7B2huxcwIk9tFtRX21gVSOOC96HcxSVVA7X N/LLM2EOL7kg4/yDWEhAdLQDChswhmdpHkp5g6ytj9TM8bNlq9I41hl/3cBEeAkxtb/eS5YR 88LBb/2FkcGnhxkGJPNB+4Siku7K8Mk2Y6elnkOctJcDvk29DajYbQnnW4nhfelZuLNupb1O M0912EvzOVI0dIVgR+xtosp66bYTOpX4Xb0fylED9kYGiuEAeoQZaDQ2eICDcHPiaLzh+6cc pkVTB0sXkWHUsPamtPum6/PgWLE9vGI5s+FaqBaqBYDKyvtJfLK4BdZng0Uc3ijycPs3bpbQ bOnK9LD8TYmYaeTenoNILQ7Ut54CCEXkP446skUMKrEo/HabvkykyWqWiIE/UlAYAx9+Ckho TT1d2QsmsAiYYWwjU8igXBecIbC0uRtF/cTfelNGrQwbICUT6kJjcOTpQDaVyIgRSlUMrlNZ XPVEQ6Zq3/aENA8ObhFxE5PLJPizJH6SC89BMKF3zg6SKx0qzQARAQABzSZOaWtvbGF5IEJv cmlzb3YgPG5pay5ib3Jpc292QHN1c2UuY29tPsLBkQQTAQoAOxYhBDuWB8EJLBUZCPjT3SRn XZEnyhfsBQJnK6byAhsDBQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJECRnXZEnyhfs XbIQAJxuUnelGdXbSbtovBNm+HF3LtT0XnZ0+DoR0DemUGuA1bZAlaOXGr5mvVbTgaoGUQIJ 3Ejx3UBEG7ZSJcfJobB34w1qHEDO0pN9orGIFT9Bic3lqhawD2r85QMcWwjsZH5FhyRx7P2o DTuUClLMO95GuHYQngBF2rHHl8QMJPVKsR18w4IWAhALpEApxa3luyV7pAAqKllfCNt7tmed uKmclf/Sz6qoP75CvEtRbfAOqYgG1Uk9A62C51iAPe35neMre3WGLsdgyMj4/15jPYi+tOUX Tc7AAWgc95LXyPJo8069MOU73htZmgH4OYy+S7f+ArXD7h8lTLT1niff2bCPi6eiAQq6b5CJ Ka4/27IiZo8tm1XjLYmoBmaCovqx5y5Xt2koibIWG3ZGD2I+qRwZ0UohKRH6kKVHGcrmCv0J YO8yIprxgoYmA7gq21BpTqw3D4+8xujn/6LgndLKmGESM1FuY3ymXgj5983eqaxicKpT9iq8 /a1j31tms4azR7+6Dt8H4SagfN6VbJ0luPzobrrNFxUgpjR4ZyQQ++G7oSRdwjfIh1wuCF6/ mDUNcb6/kA0JS9otiC3omfht47yQnvod+MxFk1lTNUu3hePJUwg1vT1te3vO5oln8lkUo9BU knlYpQ7QA2rDEKs+YWqUstr4pDtHzwQ6mo0rqP+zzsFNBGcrpvIBEADGYTFkNVttZkt6e7yA LNkv3Q39zQCt8qe7qkPdlj3CqygVXfw+h7GlcT9fuc4kd7YxFys4/Wd9icj9ZatGMwffONmi LnUotIq2N7+xvc4Xu76wv+QJpiuGEfCDB+VdZOmOzUPlmMkcJc/EDSH4qGogIYRu72uweKEq VfBI43PZIGpGJ7TjS3THX5WVI2YNSmuwqxnQF/iVqDtD2N72ObkBwIf9GnrOgxEyJ/SQq2R0 g7hd6IYk7SOKt1a8ZGCN6hXXKzmM6gHRC8fyWeTqJcK4BKSdX8PzEuYmAJjSfx4w6DoxdK5/ 9sVrNzaVgDHS0ThH/5kNkZ65KNR7K2nk45LT5Crjbg7w5/kKDY6/XiXDx7v/BOR/a+Ryo+lM MffN3XSnAex8cmIhNINl5Z8CAvDLUtItLcbDOv7hdXt6DSyb65CdyY8JwOt6CWno1tdjyDEG 5ANwVPYY878IFkOJLRTJuUd5ltybaSWjKIwjYJfIXuoyzE7OL63856MC/Os8PcLfY7vYY2LB cvKH1qOcs+an86DWX17+dkcKD/YLrpzwvRMur5+kTgVfXcC0TAl39N4YtaCKM/3ugAaVS1Mw MrbyGnGqVMqlCpjnpYREzapSk8XxbO2kYRsZQd8J9ei98OSqgPf8xM7NCULd/xaZLJUydql1 JdSREId2C15jut21aQARAQABwsF2BBgBCgAgFiEEO5YHwQksFRkI+NPdJGddkSfKF+wFAmcr pvICGwwACgkQJGddkSfKF+xuuxAA4F9iQc61wvAOAidktv4Rztn4QKy8TAyGN3M8zYf/A5Zx VcGgX4J4MhRUoPQNrzmVlrrtE2KILHxQZx5eQyPgixPXri42oG5ePEXZoLU5GFRYSPjjTYmP ypyTPN7uoWLfw4TxJqWCGRLsjnkwvyN3R4161Dty4Uhzqp1IkNhl3ifTDYEvbnmHaNvlvvna 7+9jjEBDEFYDMuO/CA8UtoVQXjy5gtOhZZkEsptfwQYc+E9U99yxGofDul7xH41VdXGpIhUj 4wjd3IbgaCiHxxj/M9eM99ybu5asvHyMo3EFPkyWxZsBlUN/riFXGspG4sT0cwOUhG2ZnExv XXhOGKs/y3VGhjZeCDWZ+0ZQHPCL3HUebLxW49wwLxvXU6sLNfYnTJxdqn58Aq4sBXW5Un0Q vfbd9VFV/bKFfvUscYk2UKPi9vgn1hY38IfmsnoS8b0uwDq75IBvup9pYFyNyPf5SutxhFfP JDjakbdjBoYDWVoaPbp5KAQ2VQRiR54lir/inyqGX+dwzPX/F4OHfB5RTiAFLJliCxniKFsM d8eHe88jWjm6/ilx4IlLl9/MdVUGjLpBi18X7ejLz3U2quYD8DBAGzCjy49wJ4Di4qQjblb2 pTXoEyM2L6E604NbDu0VDvHg7EXh1WwmijEu28c/hEB6DwtzslLpBSsJV0s1/jE= In-Reply-To: <20260620015041.336288-1-bp@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 20.06.26 г. 4:50 ч., Borislav Petkov wrote: > From: "Borislav Petkov (AMD)" > > cpu_feature_enabled() is the one to use to test feature flags so hide > the static thing which doesn't pay attention to disabled mask bits > anyway. > > Use the following command to do the replacement: > > $ git grep --files-with-matches -w static_cpu_has -- ':(exclude)*cpufeature.h' \ > | xargs sed -i 's/static_cpu_has(/cpu_feature_enabled\(/g' > > There should be no functional changes resulting from this. > > Signed-off-by: Borislav Petkov (AMD) static_cpu_has is generally used in performance critical parts of the code. Your change basically adds a __builtin_constant_p() && DISABLED_MASK check which only evaluate during compile time so from a perf point of view this shouldn't bring any negative effects. Reviewed-by: Nikolay Borisov