mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: shao.mingyin@zte.com.cn, linusw@kernel.org, brgl@kernel.org,
	linux-gpio@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, andrew@codeconstruct.com.au,
	wbg@kernel.org, opendmb@gmail.com, florian.fainelli@broadcom.com,
	bcm-kernel-feedback-list@broadcom.com, jelonek.jonas@gmail.com
Subject: Re: [PATCH v2 1/4] gpio: aspeed-sgpio: propagate IRQ setup error in probe
Date: Mon, 16 Nov 2026 09:02:40 +0100	[thread overview]
Message-ID: <34da61f7-c1c9-4a40-8ce3-fde8c03d0199@kernel.org> (raw)
In-Reply-To: <20261110232903548MKw1ilhZfMJtzbTnK9nSv@zte.com.cn>

On 10/11/2026 16:29, shao.mingyin@zte.com.cn wrote:
> From: Shao Mingyin <shao.mingyin@zte.com.cn>
> 
> aspeed_sgpio_probe() ignores the return value of
> aspeed_sgpio_setup_irqs().  That function returns the result of
> platform_get_irq(), so on failure - in particular -EPROBE_DEFER while
> the parent interrupt controller is still probing - the driver carries on

How parent controller can defer probing?

This is on of many LLM slops this user sent (and then replied with LLM
replies, so we are talking with a meat proxy).

See https://lore.kernel.org/all/avibe0HG4ssUUuBX@gremlin/ and many others

> and registers the gpiochip with no interrupt support, and the deferred
> probe is never retried, leaving GPIO interrupts permanently broken.
> 
> The "interrupts" property is mandatory for this device, so propagate the
> error from probe.
> 
> Fixes: 7db47faae79b ("gpio: aspeed: Add SGPIO driver")
> Cc: stable@vger.kernel.org

Nothing for stable really.


Best regards,
Krzysztof

  reply	other threads:[~2026-11-16  8:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10 15:28 [PATCH v2 0/4] gpio: fix IRQ handling and probe error paths in four drivers shao.mingyin
2026-11-10 15:29 ` [PATCH v2 1/4] gpio: aspeed-sgpio: propagate IRQ setup error in probe shao.mingyin
2026-11-16  8:02   ` Krzysztof Kozlowski [this message]
2026-11-16  9:22     ` shao.mingyin
2026-11-16  9:44       ` Krzysztof Kozlowski
2026-11-10 15:29 ` [PATCH v2 2/4] gpio: 104-idi-48: fix max_register blocking the IRQ register shao.mingyin
2026-11-10 15:29 ` [PATCH v2 3/4] gpio: brcmstb: don't turn platform_get_irq errors into -ENOENT shao.mingyin
2026-11-10 15:29 ` [PATCH v2 4/4] gpio: line-mux: fix unsigned truncation of property count error shao.mingyin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=34da61f7-c1c9-4a40-8ce3-fde8c03d0199@kernel.org \
    --to=krzk@kernel.org \
    --cc=andrew@codeconstruct.com.au \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=brgl@kernel.org \
    --cc=florian.fainelli@broadcom.com \
    --cc=jelonek.jonas@gmail.com \
    --cc=linusw@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=opendmb@gmail.com \
    --cc=shao.mingyin@zte.com.cn \
    --cc=wbg@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®