From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755435AbdEFImP (ORCPT ); Sat, 6 May 2017 04:42:15 -0400 Received: from mout.web.de ([212.227.17.12]:49342 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753179AbdEFImF (ORCPT ); Sat, 6 May 2017 04:42:05 -0400 Subject: [PATCH 05/10] dlm: Improve a size determination in dlm_recover_waiters_pre() From: SF Markus Elfring To: cluster-devel@redhat.com, Christine Caulfield , David Teigland Cc: LKML , kernel-janitors@vger.kernel.org References: <4bd895d7-9448-928d-1e4c-42326ce20607@users.sourceforge.net> Message-ID: <34dae3fb-31e8-d8a9-7beb-77b40dc94388@users.sourceforge.net> Date: Sat, 6 May 2017 10:41:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: <4bd895d7-9448-928d-1e4c-42326ce20607@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:319/UVkkK3tEfewQlFlS9KvXnwoZiwABkJTxkh6dQ6wE/YRUPhI AgjWaPhzNPNc/QWA20SQE/7oHmqoqH4EHXbA/d/Q6hawe8QSS3cpwYBmTgVgtMH3laAfKpY U5h1+hsf8ppfbS9knVoaZyrHM4l6nsNa8GHxy89UQEqSIDa6KYNf7zSbM+EzawMw/ozAN+0 Q+pFbj8f+G6xzGb8yj7DQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:/+6hpxHWxUo=:RFA2nEnXLcnDhHnTt1xeqb bbp9ehLVHd/vsx9YebrHN2h8ZcZwEMzeOaHlxJmYLA+a91qhD3LNWRAbvQEYhu6/XOOFP21VT +36XkcwE0b32LuDaSq8i6alQt2lnZ7yYtzI9qIE7LkKkbQndfr54kQAWRGvFSy0mzpyeInuM0 ZVvUuNat1V5rO7AeO7IjrsSED4nF/q2TyJ4OYXAbGK1iHg8jIQZyvTpLq2J7z7LbLGqp/ywPv CTW4bRAaVdekD2YdnUSmQZZgRjGhLkyH6kb+pmjdfvdKS29r3+GwyNj0OQJ1BXTu57/TCAK+s 48t68zvKPaeRoprE2aFBHboS2/k6GIN4iutfQpKGPSteaNReia2Pa/miZGe+2GIPcGqTMMvwD pE2bn2IWmaoCgBzWXt2U+qiX84iueJpeLSm/q38tBqWuIDX+iHdtjQhOHjHMu2jMz4z2i63eX xEUbwT7NO9zwPhm8ze2W3G4L6NuvxnAkBcpRkMwyHPaLK4mJNmVOH0JzrOKUmUjxzW6Lbr0b1 ZC9SV8xupI1TdrgSbRaCCX0ai4OBYhT3y+W2+e4RmnXMUh5Qezjp2Fy0UihopqV2JIgFoRAyK VVwNwjW6FkAykxy4eBb0LpfnzmIQTyVh07BLMUiyt/zJGgQWPXht3sYN7queFgQ3PDIZI0FAD 6DBIMI9nQBpSmMUTdCl9rZVquyCGmoJmPPH2tZ2P3BQCb06gV6GMiaZXXRG854B6sRFB7xCqe mM9RZfMiQ6JROlOGLuEAxnXwCzPtE6YEOmOt+nWhuser36lZMk0Wisw0UK43mONxx/wOyPsw3 YK7SK8r Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 6 May 2017 08:48:29 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- fs/dlm/lock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c index fd6fe55bedae..ffadb817ad39 100644 --- a/fs/dlm/lock.c +++ b/fs/dlm/lock.c @@ -5119,7 +5119,7 @@ void dlm_recover_waiters_pre(struct dlm_ls *ls) int wait_type, stub_unlock_result, stub_cancel_result; int dir_nodeid; - ms_stub = kmalloc(sizeof(struct dlm_message), GFP_KERNEL); + ms_stub = kmalloc(sizeof(*ms_stub), GFP_KERNEL); if (!ms_stub) { log_error(ls, "dlm_recover_waiters_pre no mem"); return; -- 2.12.2