From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C9A534F498 for ; Sun, 22 Feb 2026 20:18:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.97.179.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771791538; cv=none; b=JeDNAnuBRa2WR5F7H//K7Mnw9gMCl9RvzjNQLlFdx+vh9HkBTK7UOeP1b1RNdqzrjnTjItnufH63Raj4kDjFqKz9dZAo4IrspW9/GsYSqgE+LBx2cSWBQwmMCtT2zcDLgDRu28Oo1G1p/dNRDFKHoK+uuix1M1duzv/qH3V6PTU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771791538; c=relaxed/simple; bh=yj4AAUbDAb3Bw0yOqabpMnaQTk3ie4Uz9HT+bp/NW+Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FduuD30PsjpdtnTMaNHSKb5YXrq+keWrrmbF/WaGr5R9LVK5UnFKpLKmYM0L17dWGh3P0TzHZ9MZjDMbOKUsbQ7oFZUriUimYicTkrrExuZRqiIkIRTU79ar5dJlM08GG1AgqGj10Eimh/baUjaMxUI3lnfcJVdSY1tTDICdttY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com; spf=pass smtp.mailfrom=igalia.com; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b=OnLGwVPh; arc=none smtp.client-ip=213.97.179.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=igalia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="OnLGwVPh" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=BYfTFIroNf85DTobS2svLK6WQ8ILiGnG36jHKS1GRiU=; b=OnLGwVPh2IU1P3Lug2trtYyxtR wuMVFjJTH5oqzqO5d8oNzwk9iRr5oOK3nfcBvvO16DKuYAQ5eFXmdtxR2WWeXzmkba4Se84EMYGCJ lUUieP7qyYWwjUMETk97/ww6lt++dagUNNL2P4G4aVJJHpQ3V2XzR2SyARl29VYR4bH/nfDdgWgWN doS9TpZfS2maFkLz3gIv9dn+HQvUiXVPrnWLG0sDVFIHAjb1aenO2ENQ0VQVIDEBN2B2ISXUdmXnO Xcuo5/NdPMzoCxg/oD9ESH0vQOPOiRQcsYJJ5W/GNa9P07Bj7HnZzcfFqS7MMXtVvybcgZZ/2Kr+j bywa5Hyg==; Received: from [177.83.214.207] (helo=[192.168.0.51]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1vuFuf-003xdj-5H; Sun, 22 Feb 2026 21:18:45 +0100 Message-ID: <34de3a3c-dc04-a9a8-d90f-afa4199e0168@igalia.com> Date: Sun, 22 Feb 2026 17:18:38 -0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 2/2] mm/memblock: Add reserve_mem debugfs info Content-Language: en-US To: Mike Rapoport Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, Andrew Morton , Steven Rostedt References: <20260217195816.861684-1-gpiccoli@igalia.com> <20260217195816.861684-3-gpiccoli@igalia.com> <20e28221-f9c7-47c0-43fa-72bb2e868386@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 22/02/2026 16:19, Mike Rapoport wrote: > [...] >> First of all, what should we do regarding patch 1? Should I resubmit as >> part of V2, even with no changes - or pick it now and I only submit >> patch 2 as V2, with changes? > > Please resend both patches together. > Hi Mike! OK, thanks. >> [...] >> Specifically here, by magic number you mean my choice of 16, right? What >> do you suggest me to pick? It's the length of the string carrying the >> size of reserved_mem, some number must be selected for this >> length...lemme know WDYT. > > sizeof(txtsz) should work :) > Ahh OK heh I thought you were not happy with 16 as the size (this is an arbitrary number itself), but it's just on the func argument - cool, will fix it! >>> [...] >> Very good suggestions here, but just let me clarify: so I could continue >> showing the "reserved_mem_param" inside the "/memblock" folder, >> just using a different function for that attribute? > > Yes, something like > > static int memblock_reserve_mem_show(struct seq_file *m, void *private) > { > ... > } > DEFINE_SHOW_ATTRIBUTE(memblock_reserve_mem); > >> I understood that, based on your (good) suggestion to hide the memblock >> folder if ARCH_KEEP_MEMBLOCK is not defined and there is no reserved_mem >> set ... just want to confirm to follow-up the implementation. > > Yes, that's what I meant. > Great, thanks a lot again! Cheers, Guilherme