From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 507E93D5241 for ; Wed, 4 Feb 2026 13:44:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770212674; cv=none; b=l2n3cpyXN6974Wb03Qn5WuwFPkam0ZQ+r275yyU8gHJoPJUuEIu7gGND/Knsc/yLBsRYLfvSRtJ+V57PffjXErmvF0C6/etmD6I15l2hBv3ISzXgGflhq8+Lgxw0H2zxSKv9WluvR7FoTf597d3I4vTSls8CJbT6fwcRY6k9W4Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770212674; c=relaxed/simple; bh=MQGHHPzVdGGY8D/fSv4Dv983HDVo+MObBMQyIa/vXbY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oDqeb7cCwH2XwLFaYj8iLoUEn0NBeApzDdjCdm/VB98KQvpscAhT4onkZwIxgCCQzFFmDiDW0YnInUdriUkwhrMkULRVKYwcO9jlVVGNToTaX80DusnYXF4Yyk5uLnySl6Ti5U3zOJvj3FMbcYC+j06faUbKDX2Wl9TCmdLIp60= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XwVGMDkA; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UYMISuU/; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XwVGMDkA"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UYMISuU/" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 614CIUAH675070 for ; Wed, 4 Feb 2026 13:44:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= dezn0ig7nH8Z2dFhym2GV0P5g5RLh6rh8CVm6EDr3Is=; b=XwVGMDkAK0hnFY49 ebDTS87FkRshlxWg75t6qHsl288iWXSYNSYdUGX+UwdPZK1cIaCa3Svc8VzgLbyh SmGdwobdS60SFhsVLdt+kamwLbBfd2sFZu9juvWnTji1g3yHk/pvFc67FsnWDyZ2 S6OnBcwNneYxl81TR7Mcdy36mTyiLElJsyM2sH29Ta0Gqo+xRfUN79Rt76X40Cqr QTw4yLzU76x4juBSVvKgPKkccWEFjc+pM9w3QCmcSBXL2sBfzHGicyVXySCSrdi7 e+MqVyVrQK8uoIYs0wmDTGLpfgcs8+hbg5v8E0F+9yN+uvsUUROmY+CbCYdCkLSz W5mupQ== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c3h07mgv2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 04 Feb 2026 13:44:33 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8ca3952cbb9so19900385a.1 for ; Wed, 04 Feb 2026 05:44:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770212672; x=1770817472; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dezn0ig7nH8Z2dFhym2GV0P5g5RLh6rh8CVm6EDr3Is=; b=UYMISuU/PNStnOaizRwNZVJingxfFnsKnybSQ8KcbFlZx/pgGlGDqwi29RAIYgB/pA 40Ms+UtwR2BrjoIdHbtUaPJPXf/Jvc3rVkX2pgaVX6gSb0SIS/ffiXQHoAA5CnTp7P0F /XZzSS3L+KZaszcTkjXBjllV+NRQbWPlJIwkQdxQ+6gmUMmd23LGSOteUXu4hwQahsUM xtgBhhWr4nXETc9Yr67/FJe0Y4QnjRKCtJnwVsOIZDlS7rCvu0xOHaxgKUEPvs5aZNiw FJ/LftkSuUiNjuZTuH/Gg248ALy4a0vRtPvgbggnpqvQruxLC6FxjiFugfc9SnFB3BE1 RmdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770212672; x=1770817472; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dezn0ig7nH8Z2dFhym2GV0P5g5RLh6rh8CVm6EDr3Is=; b=MooDQipErYvWVgn0RJTiPlnYEyzNEacccHzmpen9RPM7Ao7JQqburYILGfXboOSRpj iQQxOXKUrZa/x/1WdvqaaL7fll/J69brGngTDuOcAKpr/4BqrfMNRfAt09nKDKwut7O8 zvDXYCiIeawfkusSSW7xFSlIkvh9xBGi+QYSLfGoiVo4DKMCqVWPZ4bZ8/+T56Ac8ijh qn8Uish+cwcjy0HnlqCULPsIvFIoOr4TVRzfBV5Y/vWppWbZCDtHuihYzbnBIBMPz7KK 3lS0afOhSFnrrf3HAaNq5yrW6vJ5trRGHIiwJXJaj3CaUrh2TRLj57vr8THzsXog+MBQ cLcQ== X-Forwarded-Encrypted: i=1; AJvYcCX9581N5tFMAW0CWX4YSn+W8YImHkOPC7U3JldM9W+hyl30BRN01Ey0xx02Ux1hxIOqvtWSscAUI/lup2A=@vger.kernel.org X-Gm-Message-State: AOJu0YwmzXSwsajltkJ0UUUsdhq3ls3igf1m2yZJY0OcN/BFhoYrcq5E HO+dYlPy1DsMYn6RzDncRlQXlNKb4cSYf8VmX8uB+0q5amfv7zrWkFbCNI+wBWLvoUHvjTgzePW NN9TIOwKsfpRhfcmSvFZNcLSzdsN1peDOmx43UwEo6DChZo8Jn2+gRE+7UxP4hN6cbI0= X-Gm-Gg: AZuq6aJzO3E2S+rLE1OsMTd7WYzaR3eg6SY7CINOm5/lUlabV3QzCeNUS76jjwrMedV VYkZIwzsDrau8KZMwTxmErTPMmY0BPFN68cO4MryHBtxK731Q//OCZdIOZ0hsitwhRrsv6DoE5D hJmKsqNpLDHmisjTHd7t9HSu+QNI+G9r4z16ikQETXwokFmfbCy+mAFsTl096woHmaCl2Sp48VY COjvOC4SfELqxN2Pc2g3ayzXXB2JgE4+NQjscH2TwqyFgsuWvO5Tq6n1oHxSAQ0d5ygHTCnkIpz 3alTZ5WwtMzjDAKBveU3I2gtHq/caSoeXsRQhRnZgsn+0q+ECbWugkzg7X5XkOaXPjo/5fp41ni 0gY6EBigF/qZwfR0knDp6o+bpx/A4fwGdOl14pbSSG0NSIXEZyOsueLWT1+Q2IErRDqc= X-Received: by 2002:a05:620a:1a06:b0:8b2:6eba:c45d with SMTP id af79cd13be357-8ca2f826d11mr299990885a.2.1770212672478; Wed, 04 Feb 2026 05:44:32 -0800 (PST) X-Received: by 2002:a05:620a:1a06:b0:8b2:6eba:c45d with SMTP id af79cd13be357-8ca2f826d11mr299988785a.2.1770212671987; Wed, 04 Feb 2026 05:44:31 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8e9feeff94sm122877666b.35.2026.02.04.05.44.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Feb 2026 05:44:31 -0800 (PST) Message-ID: <34ecaa11-0d2c-4981-ba5d-4d3d46e41dbc@oss.qualcomm.com> Date: Wed, 4 Feb 2026 14:44:28 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 11/13] i2c: qcom-geni: Use resources helper APIs in runtime PM functions To: Praveen Talari , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mukesh Kumar Savaliya , Viken Dadhaniya , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com Cc: prasad.sodagudi@oss.qualcomm.com, quic_vtanuku@quicinc.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com References: <20260202180922.1692428-1-praveen.talari@oss.qualcomm.com> <20260202180922.1692428-12-praveen.talari@oss.qualcomm.com> <7733eac7-8158-40f8-8887-44e458d33e9b@oss.qualcomm.com> <3466212b-802c-4ea3-8661-794da34c6c3e@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <3466212b-802c-4ea3-8661-794da34c6c3e@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA0MDEwNCBTYWx0ZWRfX//SKbU1vU5ud 7NQkBpm2KBJnD8j9MV/QIOHD/5SLBlWcb3d9VgHC4DXahdFjkEohHG2kHPCo8jRvC5PTuO6MrGr kRg7m+as58/DRDGE59MMERl39gFgIaNTp1mv7rRitW8foc6t3GPrhRAweN8NWtAtaxaKqhoehom 6+NfrHvD+gZLB/Cik+Tb8m2RqtBDJ//v+q+TqMA7fX8aDjUFPyr4YmDGTgTeULKap7y4vNUyvpz ZzvZAWJOzwrLhf++2eahCrW8XrlUklAwPcJ5gYrZiXQm4BIDl3WT1yxq/ZNagXb+rHrBm7zENP4 U04XRx9ksHq7/7ETDyU1L2y+dw489rqh1hzHkyK7ktYGsvQG3F/oLzrKA7nP8I8PMAlnyh4ALmH YxqMe0pNKLBxr3WWlHltNhpdRKi/TMiHZd25p8ooD2aoRjhbeKiGWqE+9HdsqG/AyXn0JbwEcvU Uxjnuk+rqlGuu/ZcUYA== X-Authority-Analysis: v=2.4 cv=CMknnBrD c=1 sm=1 tr=0 ts=69834d41 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=KysUWGufpr5dDgJzMcwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-ORIG-GUID: hI_1wu-q9ZxDS3W5lcq8xwuvym5E7utB X-Proofpoint-GUID: hI_1wu-q9ZxDS3W5lcq8xwuvym5E7utB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-04_04,2026-02-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 spamscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602040104 On 2/4/26 6:06 AM, Praveen Talari wrote: > Hi Konrad, > > On 2/3/2026 6:18 PM, Konrad Dybcio wrote: >> On 2/2/26 7:09 PM, Praveen Talari wrote: >>> To manage GENI serial engine resources during runtime power management, >>> drivers currently need to call functions for ICC, clock, and >>> SE resource operations in both suspend and resume paths, resulting in >>> code duplication across drivers. >>> >>> The new geni_se_resources_activate() and geni_se_resources_deactivate() >>> helper APIs addresses this issue by providing a streamlined method to >>> enable or disable all resources based, thereby eliminating redundancy >>> across drivers. >>> >>> Acked-by: Viken Dadhaniya >>> Signed-off-by: Praveen Talari >>> --- >> >> [...] >> >> >>>       disable_irq(gi2c->irq); >>> -    ret = geni_se_resources_off(&gi2c->se); >>> + >>> +    ret = geni_se_resources_deactivate(&gi2c->se); >>>       if (ret) { >>>           enable_irq(gi2c->irq); >>>           return ret; >>> - >>> -    } else { >>> -        gi2c->suspended = 1; >>>       } >>>   -    clk_disable_unprepare(gi2c->core_clk); >> >> I believe you can give gi2c->core_clk and desc->has_core_clk the boot >> with this patch since they're no longer referenced anywhere > > Sorry i didn't get you. Please share more on this. I think you can remove these fields from i2c-qcom-geni.c as they seem unused now Konrad