Re: [PATCH] drm/bridge: ite-it6263: Support VESA input format

[Liu Ying <victor.liu@nxp.com>]

On 12/04/2024, Biju Das wrote:
> Hi Liu Ying,

Hi Biju,

> 
>> -----Original Message-----
>> From: Liu Ying <victor.liu@nxp.com>
>> Sent: 04 December 2024 03:34
>> To: tomm.merciai@gmail.com
>> Subject: Re: [PATCH] drm/bridge: ite-it6263: Support VESA input format
>>
>> On 12/04/2024, tomm.merciai@gmail.com wrote:
>>> From: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
>>>
>>> Introduce it6263_is_input_bus_fmt_valid() and refactor the
>>> it6263_bridge_atomic_get_input_bus_fmts() function to support VESA
>>> format by selecting the LVDS input format based on the LVDS data
>>> mapping and thereby support both JEIDA and VESA input formats.
>>
>> ite,it6263.yaml says IT6263 supports vesa-24 and vesa-30, while this patch actually only adds vesa-24
>> support.  So, to be more specific, the patch subject and commit message should reflect this rather
>> than claim "Support VESA input format".
>>
>>>
>>> Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
>>
>> Can you please send this patch with your Renesas email address instead of Gmail email address?
>> Otherwise, add a Signed-off-by tag with your Gmail email address.
> 
> If I am correct, you can clearly see the Renesas email address after subject.

Yes.

> So, the procedure followed by Tommaso is correct.

No, I think it's wrong. We don't know whether the person(s)
behind the two Email addresses are the same Tommaso.
Likely it's a person from two different domains - still kind
of two people.
AFAIK, sending other's patch needs to add sender's SoB tag.

> 
> You can use gmail account for send patch, but you just need to add From tag and SoB tag
> after subject with company address.

Again, we don't know sender and author are the same
person if their Email addresses are different.

> 
> Please shout if anyone think this procedure is wrong.
> 
> <snippet>
> Subject: Re: [PATCH] drm/bridge: ite-it6263: Support VESA input format
> 
> From: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
> 
> Introduce it6263_is_input_bus_fmt_valid() and refactor the
> </snippet>
> 
> 
> Cheers,
> Biju

-- 
Regards,
Liu Ying