From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753033AbdF3VIM (ORCPT ); Fri, 30 Jun 2017 17:08:12 -0400 Received: from mga14.intel.com ([192.55.52.115]:59877 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753008AbdF3VIL (ORCPT ); Fri, 30 Jun 2017 17:08:11 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,288,1496127600"; d="scan'208";a="873623168" Reply-To: sathyanarayanan.kuppuswamy@linux.intel.com Subject: Re: [PATCH 1/1] MAINTAINERS: Add entry for Whiskey Cove PMIC GPIO driver To: Andy Shevchenko Cc: Linus Walleij , "linux-kernel@vger.kernel.org" , Sathyanarayanan Kuppuswamy Natarajan References: <1498850415-160958-1-git-send-email-sathyanarayanan.kuppuswamy@linux.intel.com> From: sathyanarayanan kuppuswamy Organization: Intel Message-ID: <34f4ec54-6647-8b04-4c09-3b2fa16010e9@linux.intel.com> Date: Fri, 30 Jun 2017 14:08:02 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andy, On 06/30/2017 01:51 PM, Andy Shevchenko wrote: > If we are going to rename (which I personally consider as a good > idea), this should follow it, and not otherwise. I am having second thoughts about the rename. After going through the spec documents, I found that there are two main differences between CHT and BXT PMIC GPIO controllers. 1. BXT variant has 3 GPIO banks where as CHT variant has only 2 GPIO banks. 2. GPIO I/O control register and IRQ register mapping addresses are different in both BXT and CHT variants. Given above differences, I think we have a choice to use the current driver and pass the above data difference to driver via .driver_data or platform_data. This is a bit messy method because we are not getting the register address or info about number of gpio banks from BIOS. Other solution is to rename the existing driver to gpio-bxt-wcove.c and create a new one for CHT (if required). Let me know your comments. -- Sathyanarayanan Kuppuswamy Linux kernel developer