From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D99A523ABBD for ; Sat, 28 Feb 2026 09:35:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772271332; cv=none; b=gARt3tflk+nxSRR1XWh5OQAThDLVrYn/RAJI/dMYiMZhP2mDfpMTb0qcHV6XpU1k1Q35ms1uphzHPaj0rBCtuE7Fq34dbQc5I7R/NZBN5usSHAr674q8WYWD1pXE+pjPK7Gx/YvGCBQJJFr5gEN1bJNl2+nnnoVU8hYqT0Qdi1M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772271332; c=relaxed/simple; bh=LdmexdDlQSGHWR3cD618j9yNt1RrlvUQMYnisgXqgew=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cWXpJ+pUhHaafc92SJiL0NmmLeteo1o93tt71XKuLOmp2Z+PDAEwyf5ZiYLFJU95g42QcshX0Q2kM7wZb8VEXeDMwdH+3ChJUNA6wKWJzjs+pspM5o6l78ibOVsTaFT3OzW99ao8rOt7VggWkUFckroA6B1gkGLCrbcFnDWWinQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BCD4519F6; Sat, 28 Feb 2026 01:35:23 -0800 (PST) Received: from [10.163.135.253] (unknown [10.163.135.253]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5409D3F73B; Sat, 28 Feb 2026 01:35:13 -0800 (PST) Message-ID: <34ffaa1b-5812-47fe-ac35-491bd2f94b8f@arm.com> Date: Sat, 28 Feb 2026 15:05:10 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH mm-unstable v2 2/5] mm: introduce is_pmd_order helper To: Nico Pache , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: aarcange@redhat.com, akpm@linux-foundation.org, anshuman.khandual@arm.com, apopple@nvidia.com, baohua@kernel.org, baolin.wang@linux.alibaba.com, byungchul@sk.com, catalin.marinas@arm.com, cl@gentwo.org, corbet@lwn.net, dave.hansen@linux.intel.com, david@kernel.org, gourry@gourry.net, hannes@cmpxchg.org, hughd@google.com, jackmanb@google.com, jack@suse.cz, jannh@google.com, jglisse@google.com, joshua.hahnjy@gmail.com, kas@kernel.org, lance.yang@linux.dev, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, mathieu.desnoyers@efficios.com, matthew.brost@intel.com, mhiramat@kernel.org, mhocko@suse.com, peterx@redhat.com, pfalcato@suse.de, rakie.kim@sk.com, raquini@redhat.com, rdunlap@infradead.org, richard.weiyang@gmail.com, rientjes@google.com, rostedt@goodmis.org, rppt@kernel.org, ryan.roberts@arm.com, shivankg@amd.com, sunnanyong@huawei.com, surenb@google.com, thomas.hellstrom@linux.intel.com, tiwai@suse.de, usamaarif642@gmail.com, vbabka@suse.cz, vishal.moola@gmail.com, wangkefeng.wang@huawei.com, will@kernel.org, willy@infradead.org, yang@os.amperecomputing.com, ying.huang@linux.alibaba.com, ziy@nvidia.com, zokeefe@google.com References: <20260226012929.169479-1-npache@redhat.com> <20260226012929.169479-3-npache@redhat.com> Content-Language: en-US From: Dev Jain In-Reply-To: <20260226012929.169479-3-npache@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 26/02/26 6:59 am, Nico Pache wrote: > In order to add mTHP support to khugepaged, we will often be checking if a > given order is (or is not) a PMD order. Some places in the kernel already > use this check, so lets create a simple helper function to keep the code > clean and readable. > > Acked-by: David Hildenbrand (Arm) > Reviewed-by: Wei Yang > Reviewed-by: Lance Yang > Reviewed-by: Barry Song > Reviewed-by: Zi Yan > Reviewed-by: Pedro Falcato > Reviewed-by: Lorenzo Stoakes > Suggested-by: Lorenzo Stoakes > Signed-off-by: Nico Pache > --- Reviewed-by: Dev Jain > include/linux/huge_mm.h | 5 +++++ > mm/huge_memory.c | 2 +- > mm/khugepaged.c | 6 +++--- > mm/memory.c | 2 +- > mm/mempolicy.c | 2 +- > mm/page_alloc.c | 4 ++-- > mm/shmem.c | 3 +-- > 7 files changed, 14 insertions(+), 10 deletions(-) > > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > index a4d9f964dfde..bd7f0e1d8094 100644 > --- a/include/linux/huge_mm.h > +++ b/include/linux/huge_mm.h > @@ -771,6 +771,11 @@ static inline bool pmd_is_huge(pmd_t pmd) > } > #endif /* CONFIG_TRANSPARENT_HUGEPAGE */ > > +static inline bool is_pmd_order(unsigned int order) > +{ > + return order == HPAGE_PMD_ORDER; > +} > + > static inline int split_folio_to_list_to_order(struct folio *folio, > struct list_head *list, int new_order) > { > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 8003d3a49822..a688d5ff806e 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -4100,7 +4100,7 @@ static int __folio_split(struct folio *folio, unsigned int new_order, > i_mmap_unlock_read(mapping); > out: > xas_destroy(&xas); > - if (old_order == HPAGE_PMD_ORDER) > + if (is_pmd_order(old_order)) > count_vm_event(!ret ? THP_SPLIT_PAGE : THP_SPLIT_PAGE_FAILED); > count_mthp_stat(old_order, !ret ? MTHP_STAT_SPLIT : MTHP_STAT_SPLIT_FAILED); > return ret; > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index c85d7381adb5..2ef4b972470b 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -1533,7 +1533,7 @@ static enum scan_result try_collapse_pte_mapped_thp(struct mm_struct *mm, unsign > if (IS_ERR(folio)) > return SCAN_PAGE_NULL; > > - if (folio_order(folio) != HPAGE_PMD_ORDER) { > + if (!is_pmd_order(folio_order(folio))) { > result = SCAN_PAGE_COMPOUND; > goto drop_folio; > } > @@ -2016,7 +2016,7 @@ static enum scan_result collapse_file(struct mm_struct *mm, unsigned long addr, > * we locked the first folio, then a THP might be there already. > * This will be discovered on the first iteration. > */ > - if (folio_order(folio) == HPAGE_PMD_ORDER && > + if (is_pmd_order(folio_order(folio)) && > folio->index == start) { > /* Maybe PMD-mapped */ > result = SCAN_PTE_MAPPED_HUGEPAGE; > @@ -2346,7 +2346,7 @@ static enum scan_result hpage_collapse_scan_file(struct mm_struct *mm, > continue; > } > > - if (folio_order(folio) == HPAGE_PMD_ORDER && > + if (is_pmd_order(folio_order(folio)) && > folio->index == start) { > /* Maybe PMD-mapped */ > result = SCAN_PTE_MAPPED_HUGEPAGE; > diff --git a/mm/memory.c b/mm/memory.c > index a1a364e1fdcd..cb76fa182eab 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -5427,7 +5427,7 @@ vm_fault_t do_set_pmd(struct vm_fault *vmf, struct folio *folio, struct page *pa > if (!thp_vma_suitable_order(vma, haddr, PMD_ORDER)) > return ret; > > - if (folio_order(folio) != HPAGE_PMD_ORDER) > + if (!is_pmd_order(folio_order(folio))) > return ret; > page = &folio->page; > > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index 0e5175f1c767..e5528c35bbb8 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -2449,7 +2449,7 @@ static struct page *alloc_pages_mpol(gfp_t gfp, unsigned int order, > > if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE) && > /* filter "hugepage" allocation, unless from alloc_pages() */ > - order == HPAGE_PMD_ORDER && ilx != NO_INTERLEAVE_INDEX) { > + is_pmd_order(order) && ilx != NO_INTERLEAVE_INDEX) { > /* > * For hugepage allocation and non-interleave policy which > * allows the current node (or other explicitly preferred > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index d88c8c67ac0b..96ffb47bcfee 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -687,7 +687,7 @@ static inline unsigned int order_to_pindex(int migratetype, int order) > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > bool movable; > if (order > PAGE_ALLOC_COSTLY_ORDER) { > - VM_BUG_ON(order != HPAGE_PMD_ORDER); > + VM_BUG_ON(!is_pmd_order(order)); > > movable = migratetype == MIGRATE_MOVABLE; > > @@ -719,7 +719,7 @@ static inline bool pcp_allowed_order(unsigned int order) > if (order <= PAGE_ALLOC_COSTLY_ORDER) > return true; > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > - if (order == HPAGE_PMD_ORDER) > + if (is_pmd_order(order)) > return true; > #endif > return false; > diff --git a/mm/shmem.c b/mm/shmem.c > index cfed6c3ff853..ba74803c7518 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -5558,8 +5558,7 @@ static ssize_t thpsize_shmem_enabled_store(struct kobject *kobj, > spin_unlock(&huge_shmem_orders_lock); > } else if (sysfs_streq(buf, "inherit")) { > /* Do not override huge allocation policy with non-PMD sized mTHP */ > - if (shmem_huge == SHMEM_HUGE_FORCE && > - order != HPAGE_PMD_ORDER) > + if (shmem_huge == SHMEM_HUGE_FORCE && !is_pmd_order(order)) > return -EINVAL; > > spin_lock(&huge_shmem_orders_lock);