From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752643AbbKYV0j (ORCPT ); Wed, 25 Nov 2015 16:26:39 -0500 Received: from mout.kundenserver.de ([212.227.17.10]:61618 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750919AbbKYV0h (ORCPT ); Wed, 25 Nov 2015 16:26:37 -0500 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Stephen Boyd , Eric Miao , Michael Turquette , linux-kernel@vger.kernel.org, Haojian Zhuang , Chao Xie , Mike Turquette , linux-clk@vger.kernel.org Subject: Re: [PATCH 1/7] clk: mmp: stop using platform headers Date: Wed, 25 Nov 2015 22:26:01 +0100 Message-ID: <3508030.Q62gfHvXvx@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20151125192114.GB11298@codeaurora.org> References: <1448465875-435039-1-git-send-email-arnd@arndb.de> <1448465875-435039-2-git-send-email-arnd@arndb.de> <20151125192114.GB11298@codeaurora.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:ADibKxG6Yb9krEuP4XmQHunNcz7OsGv9Verom31U9lLsE3jAO/Z Xua4Fb4VBz8XBdh22mxxHQM8betBGJM6edhjQFATtPVduFYL7fVfbXKLkox1YG59XokBS0w LViI1YT9WQPqwtl19Q31oWfte8+Nu6aTvrE97TmhWREEGisAfzw6POUZEoEUrTg2xTl5NzK Lrxm8f65GGaqEnrA6KzzQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:dm+QLpYX0VI=:TQKRLI/aJY9rxBoovX1u78 8lPufOMYgorSe6vyocpfijtiofxAWPPaLwdyQraRiM09smNJEv0f+OjozZIst7vNOkAFfu6C7 T1oa4eel+P++Q3F6IOS5cc2pt/VtlOedRb5NBJOUE4zKz0CkzUcpBasmuQBmgZVAVHdPqeTvZ 6VysXLS5aSKl/VQw6yrm1x+ww1KAOMnHguAqHyeAmzt5rb5Ol8Rp3J7gKOo7uAhjTxhKKz+Rq 8c3BT9TUjECCvUJgWRpZyw4Hq2n5j69hiooT0EOg+bcUfXtchl1uNGn9LRKqiSJuamGu3PYfA 6yQxVYMcZUCyCUVKCMnpnVDh7xdcGvgznzxG2UYhUUCvfz/SwfEyNziFU/14411C7MsyhT5AD 4KvyU6tkLSf5tOBSZrXXvWfFlox4xGQruV99Mn5oVuO01/MkYqhC8pjnb83S4jX7ANNfkrqSu /vSsggnf02Lh3SkKvf3VTQ5hLGgbiEyNRZV5UOxuCejEwcMPA2CXjQ4fkBfK8FNC1eArra1cK L6O09oQeSueR2/DYuh/3dvgnEMybngQG0m4QkoiqsDdW4ZVWZIAshy2oziAS8t84wECaG1v14 FUCOxHvt4VLWThNsKiJcWvkZjlGx81HjvT/DIeOeRygr/SXw/4gLhnBw2keQVWW5pPimZazBI cmW6vDxJTGpizLJDYaJUas7x530uE8fbplrowfHXkt37SPRq88e0X6+5l4tbkCdwKPwpzfAcA Jn6HR/9/vvBLGQC1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 25 November 2015 11:21:14 Stephen Boyd wrote: > On 11/25, Arnd Bergmann wrote: > > diff --git a/drivers/clk/mmp/clk-mmp2.c b/drivers/clk/mmp/clk-mmp2.c > > index 09d2832fbd78..38931dbd1eff 100644 > > --- a/drivers/clk/mmp/clk-mmp2.c > > +++ b/drivers/clk/mmp/clk-mmp2.c > > @@ -9,6 +9,7 @@ > > * warranty of any kind, whether express or implied. > > */ > > > > +#include > > Why are we adding this include? I don't see any clk consumer API > usage being added. Without these #includes, I get a build error: drivers/clk/mmp/clk-mmp2.c: In function 'mmp2_clk_init': drivers/clk/mmp/clk-mmp2.c:192:2: error: implicit declaration of function 'clk_set_rate' [-Werror=implicit-function-declaration] clk_set_rate(clk, 14745600); ^ drivers/clk/mmp/clk-mmp2.c:251:2: error: implicit declaration of function 'clk_set_parent' [-Werror=implicit-function-declaration] clk_set_parent(clk, vctcxo); ^ drivers/clk/mmp/clk-pxa168.c: In function 'pxa168_clk_init': drivers/clk/mmp/clk-pxa168.c:161:2: error: implicit declaration of function 'clk_set_rate' [-Werror=implicit-function-declaration] clk_set_rate(uart_pll, 14745600); ^ drivers/clk/mmp/clk-pxa168.c:204:2: error: implicit declaration of function 'clk_set_parent' [-Werror=implicit-function-declaration] clk_set_parent(clk, uart_pll); ^ drivers/clk/mmp/clk-pxa910.c: In function 'pxa910_clk_init': drivers/clk/mmp/clk-pxa910.c:166:2: error: implicit declaration of function 'clk_set_rate' [-Werror=implicit-function-declaration] clk_set_rate(uart_pll, 14745600); ^ drivers/clk/mmp/clk-pxa910.c:209:2: error: implicit declaration of function 'clk_set_parent' [-Werror=implicit-function-declaration] clk_set_parent(clk, uart_pll); ^ Is there anything I need to change here? Arnd