mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Himadri Pandya <himadri18.07@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: fbtft: fix alignment should match open parenthesis
Date: Wed, 10 Apr 2019 16:20:11 +0530	[thread overview]
Message-ID: <3509afac-e460-8b68-22b4-98b91600d9a1@gmail.com> (raw)
In-Reply-To: <20190410104240.GG6095@kadam>


On 10/04/19 4:12 PM, Dan Carpenter wrote:
> On Wed, Apr 10, 2019 at 03:30:22PM +0530, Himadri Pandya wrote:
>> Fix checkpatch warning "Alignment should match open parenthesis".
>>
>> Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
>> ---
>>   drivers/staging/fbtft/fb_tinylcd.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/fbtft/fb_tinylcd.c b/drivers/staging/fbtft/fb_tinylcd.c
>> index 9469248f2c50..60cda57bcb33 100644
>> --- a/drivers/staging/fbtft/fb_tinylcd.c
>> +++ b/drivers/staging/fbtft/fb_tinylcd.c
>> @@ -38,7 +38,7 @@ static int init_display(struct fbtft_par *par)
>>   	write_reg(par, 0xE5, 0x00);
>>   	write_reg(par, 0xF0, 0x36, 0xA5, 0x53);
>>   	write_reg(par, 0xE0, 0x00, 0x35, 0x33, 0x00, 0x00, 0x00,
>> -		       0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
>> +		  0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
> The original code was written that way deliberately.  I don't know
> why it's broken up like that but it probably means something to people
> who have read the hardware spec.  I would leave it as-is.
>
> regards,
> dan carpenter

Okay. Thank you for reviewing it.

- Himadri


  reply	other threads:[~2019-04-10 10:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-10 10:00 Himadri Pandya
2019-04-10 10:42 ` Dan Carpenter
2019-04-10 10:50   ` Himadri Pandya [this message]
2022-06-26  2:00 David Reaver
2022-06-26  2:50 ` Joe Perches
2022-06-26  2:52   ` David Reaver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3509afac-e460-8b68-22b4-98b91600d9a1@gmail.com \
    --to=himadri18.07@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome