From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753031AbdHQOdp (ORCPT ); Thu, 17 Aug 2017 10:33:45 -0400 Received: from mout.web.de ([212.227.17.12]:63246 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751684AbdHQOdn (ORCPT ); Thu, 17 Aug 2017 10:33:43 -0400 Subject: [PATCH 1/2] lockd: Delete an error message for a failed memory allocation in reclaimer() From: SF Markus Elfring To: linux-nfs@vger.kernel.org, Anna Schumaker , Benjamin Coddington , Christoph Hellwig , Colin Ian King , "J. Bruce Fields" , Jeff Layton , Trond Myklebust Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: <350de6ea-41ff-1b86-ff50-26c677447f00@users.sourceforge.net> Date: Thu, 17 Aug 2017 16:33:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:dpg6HglmP30isBJk75oWur0LIeDoiR8jcNUSl04G0xZayrCKF1Y EZoneYv4Bb9d6GfO+8fHoIGmQNbaZpuCCv9upZ/3jGs1yFP8ICEVzGaEH6knvX80Jkmq96Y IJmeb6qY5i/u/nyPeVH2sWep7+EmCQcL1rG/GGJKkbtsGPJQbwC/50xDqaPp2Tc/wAma+Qd CF+ttRSi3lussiRi/uUZQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:ZMoQkHpIWHk=:BY2h7hhurgxXk3HBdvfw1n eLSJA2rDoO1wzibTlISg3OvgDklpqbmTB2TIURsNKr+xQrn6B5FHNqcD1Yjgc/VAh2F5VoVGN MAOibStdNfBa7+VxLvw6FcFfI7P2/avwDEDdJG5zD6GjEVYp7CyZXTaq2q2/c7XHBB01uZH6F ti1W+4VoJ7OqFNj7uAjRtlDbwrKg6QoEKj8rorrk9jrOOHWVBXKNrhFTpUo+OZLYYrWD7dxM6 1tfXpl75f13nJBYU9uix+XV3cz3vi/a28OeoODtZBcCuCsQnmKfifwD6DcEJj7n0PuN5IAx01 QIcMLUW+dvi5BEmZNiBqst3h3a2+TQJOJxXWP5FswW5RSCqD0kd9zzLQEHJUeex4HzhhsH1LS IitfButY8/Xctgg+2f0Jv+7/5qcl2Vh3BQkSMfvUIW3JyYGv0JY5/RApIHTfids1Xes3bH+yI JmhoX3dsWRobIYOmf4TA86VqxNw190OvNIGLrtdn6DBTcLz6wNnBr2rYMxzzrjXtiJCpfivOQ V72BJWJlsYgjYxmy3kR6oqgN3QWXejedL50nNzGLQ72cB8HOzT12L2VwYmgNa1AuAvnwXliCD 9eH9GZ4g+wMYFy5R97eHB+xC3UiRFajxdOzq4iBo3EL1GbOf2ZhPsEzJ6zk+iaL6nuUPdSO/V jNGZ5U6ZzIe+xOoYNG3n07DfXO0sInptMm1G7gWlGeGFBbEOzgcOc4V1X+056jdkqbSsogKYx AOBmlg7eoIi4oZRKcrfzrBmjV1Jo79EXsR6np8ASHCipRGvh+qo14cMfNmZ/bhUIt7pqBK6Lk Z14HWJA3B+VdmT2DZHyJ+Xmmebyj+mKg0pi5x4l3m0CcG9VM6w= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 16 Aug 2017 22:35:24 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- fs/lockd/clntlock.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/fs/lockd/clntlock.c b/fs/lockd/clntlock.c index 27d577dbe51a..96c1d14c18f1 100644 --- a/fs/lockd/clntlock.c +++ b/fs/lockd/clntlock.c @@ -235,12 +235,8 @@ reclaimer(void *ptr) struct net *net = host->net; req = kmalloc(sizeof(*req), GFP_KERNEL); - if (!req) { - printk(KERN_ERR "lockd: reclaimer unable to alloc memory." - " Locks for %s won't be reclaimed!\n", - host->h_name); + if (!req) return 0; - } allow_signal(SIGKILL); -- 2.14.0