From: Jens Axboe <axboe@kernel.dk>
To: Dongli Zhang <dongli.zhang@oracle.com>, linux-block@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH for-next 1/1] null_blk: force complete for timeout request
Date: Fri, 29 May 2020 11:42:21 -0600 [thread overview]
Message-ID: <351116db-56b6-4865-efe8-fab4fec2f010@kernel.dk> (raw)
In-Reply-To: <20200529173108.25198-1-dongli.zhang@oracle.com>
On 5/29/20 11:31 AM, Dongli Zhang wrote:
> The commit 7b11eab041da ("blk-mq: blk-mq: provide forced completion
> method") exports new API to force a request to complete without error
> injection.
>
> There should be no error injection when completing a request by timeout
> handler.
>
> Otherwise, the below would hang because timeout handler is failed.
>
> echo 100 > /sys/kernel/debug/fail_io_timeout/probability
> echo 1000 > /sys/kernel/debug/fail_io_timeout/times
> echo 1 > /sys/block/nullb0/io-timeout-fail
> dd if=/dev/zero of=/dev/nullb0 bs=512 count=1 oflag=direct
>
> With this patch, the timeout handler is able to complete the IO.
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2020-05-29 17:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 17:31 Dongli Zhang
2020-05-29 17:42 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=351116db-56b6-4865-efe8-fab4fec2f010@kernel.dk \
--to=axboe@kernel.dk \
--cc=dongli.zhang@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome