From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 323D9427F8F for ; Tue, 13 Oct 2026 10:28:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.149.25 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791887316; cv=fail; b=ie6tOYxfwRjnOknyKZK/egZ+W12FOl/mDPEhoyoV1+dW3RCeKwcGVMq0rwhwMPftdhyyQKZmproFkX4clqBPkf+3zSP7EjSuzwIbsNsQw9o9HUdVkHx62TZEGQltHXnKVrBipoE+8cMh7L1Y7TCcgnDhY/2YCJ4zx/cW5YTGz+o= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791887316; c=relaxed/simple; bh=ABbY0K0S31yqqrovIo+c2mZK7maBO34Yuz1R+Mf/BkI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fxB3gKVlXM7phSbUmOvLkyr44XN7/1Zg62Fqtd08+E9yFiY1kz3JrkE6wrk+maFVZ9MSxzq8TfgnWqhGMCJTIGh/KBYdIXS6ljr3YbJ/VK2/QclGJCtWDHDW9CT56iocjuIN2289LcO5o+loP7MJ7KuDQLxPV9RTElFIyTFFZ6A= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=lM+Vvv8u; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=JtNRgpxQ; arc=fail smtp.client-ip=67.231.149.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="lM+Vvv8u"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="JtNRgpxQ" Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69DA60Ik2265598; Tue, 13 Oct 2026 05:28:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=PSV9pj3B05oe03Xn1nOgf1w6nUIG2Jqi7MYKw9vSddY=; b= lM+Vvv8uMRxFFm3y9SA8vo1MroiChJq/5Qfs6Ts7Gmka+dl3bvNu6l8INBxLFcY/ Zy99zjBYH1q1ZLiOFqo0Gs+2qU/4joHzNZC7Wh96aWS1iB4V0RjNiuaaewvzqyAm FVOs9KxrPuPCCACkMEMUt3XK+pfsfHXjxajp6iZhV3JmV/VY0eCADt+o4kewwv66 qA0yBQcEvRO/f4JACJP3vUsz5JFdZb3POQFQ6RR9MT7VntUagRJ0U7bGH5DhanlQ EwIQhC3KsXR1HvL9vOJyNkpuR19aINMBv0DbfNBJztERx3uBI6C5XlLLqKxjNWj4 5d2aq7H9wb154JzNBgSFQw== Received: from ch1pr05cu001.outbound.protection.outlook.com (mail-northcentralusazon11020133.outbound.protection.outlook.com [52.101.193.133]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 4h7jrxbh73-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 13 Oct 2026 05:28:25 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LGWUu9W4Za2zSVaZ2rEiwvF0rbQ0wyCcoyK2FfTC0V9gFvjvw0rvNf+FFe5xHyBgugiKjaRxxJXvwLXTaoQ31VmDYXgODa+PGk/HhjCbGIWcCStnmbstAx/GogAJzDEMU/nOySRtj1FM6NIUPgvHaO4rZ2V4vOlYyYlFy5e1fATmJ1L2iqIMop6ZsDzRiElpv6kxHJQd85RDdZOdhRZ9Jhs2UgesO11XeT8kzPx13JFveMwT+y2CtiB8bgL1JxYjSIJhUUoirvJjNj+neAKTIg0LYc8RmzwpzrExDBysbzlpJlHoqe0/srnzPviVMpF7ks0v+UodT8WNGlnNzzy8Ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PSV9pj3B05oe03Xn1nOgf1w6nUIG2Jqi7MYKw9vSddY=; b=AG1Wa5JHB6qZTknffsJ3cJ09z91UK617Myq253Px6WjsDEmEhgs31hk0l5BeRjnUEtUWAdaFDRDtfs4Gvp3YGfsBXb1k0aA1vbke1XzrNc74iGiS/FAJAdiBwTJWzGy4fa6F4h4+rUlbTYVfwRqJAC9a32A0GcK5oNEsvxwBXUOQOTBnXi/H1EJAWj2kmDGGwMB6TIFBzw4UFh+gEE+QXicuHeoXkHII187DRVqLkVglJpisQyzY/hZ/pM3oKMoJeSD6bK6MFdbTpOQ+RArC+6uxb6Rf6Cyl8Y7Z35iB/KOAI1JeD8DRch2pAc1zHOLyWQC8S9o0J2Lkl9X6d0ZVWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 84.19.233.75) smtp.rcpttodomain=alsa-project.org smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PSV9pj3B05oe03Xn1nOgf1w6nUIG2Jqi7MYKw9vSddY=; b=JtNRgpxQ8ZLMhDcBn3w5UwG765fYU8BDYnAwy82DjNoRNsy0vhksOVUaXAbfWua+HzIXCfWn6Y7mGRzXKE+IZVJbc6StuRkiidjqHA3BCjzgY7Tv4WNU43izTBcVdgBY3uh7lT+OOTKATtUJtCAcKTB4Ezs/FIX/LuXLVJ3J9XQ= Received: from CH0PR04CA0107.namprd04.prod.outlook.com (2603:10b6:610:75::22) by SJ2PR19MB8027.namprd19.prod.outlook.com (2603:10b6:a03:541::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.17; Tue, 13 Oct 2026 10:28:21 +0000 Received: from CH3PEPF00000010.namprd04.prod.outlook.com (2603:10b6:610:75:cafe::5c) by CH0PR04CA0107.outlook.office365.com (2603:10b6:610:75::22) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.496.5 via Frontend Transport; Tue, 13 Oct 2026 10:28:21 +0000 X-MS-Exchange-Authentication-Results: mx.microsoft.com 1; spf=softfail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning opensource.cirrus.com discourages use of 84.19.233.75 as permitted sender) Received: from edirelay1.ad.cirrus.com (84.19.233.75) by CH3PEPF00000010.mail.protection.outlook.com (10.167.244.41) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.522.6 via Frontend Transport; Tue, 13 Oct 2026 10:28:19 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id EE144406544; Tue, 13 Oct 2026 10:28:18 +0000 (UTC) Received: from [198.90.208.11] (ediswws06.ad.cirrus.com [198.90.208.11]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id DD50F82024B; Tue, 13 Oct 2026 10:28:18 +0000 (UTC) Message-ID: <35192938-660d-4682-8963-92f53e118ef4@opensource.cirrus.com> Date: Tue, 13 Oct 2026 11:28:18 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] firmware: cs_dsp: clear dsp->running on the cs_dsp_run() error path To: Mingxuan Guo , Simon Trimmer , Charles Keepax Cc: Mark Brown , patches@opensource.cirrus.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org References: Content-Language: en-GB From: Richard Fitzgerald In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF00000010:EE_|SJ2PR19MB8027:EE_ X-MS-Office365-Filtering-Correlation-Id: ce9819f9-a7dd-48a3-1b23-08df2914b3bd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|61400799027|82310400026|36860700016|23010399003|56012099006|11063799006|16102099003|10067099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: eHTJbUlLmv/6RZIRqFXCVj5yfKjIvm0omVDSh/Bvk01REGSvMrrVJv+ewW67seSEQ6keq2xe6/8l21dVfIWdJXmfTiUxAUe817DfB6CUZUV2owL166z8vRXcQ/FllpzguSzdPGfPC6C2WxPvrv44q8gHSYijbp9E+qCpO0Cd6vBastomBsCKkpiEzRA7RJgSDoHe5Q1YceTKWz/2jHcOMLZJAhJFV5DcXvfJZjqEtzkaSk12+PxS7z7MYwVqVZhbly0aLdwthO9GMLiVgosr3Q8Y1gLIQEiXWqwbNKFzhhL3w44FNLQXRbMj4+YjsJqxU7xvxhGmibSSuFOOGdjPXroalLf876bAkY76ijdf3p1KfssQC6nhhuzMPKQe4pmmb81Ay5CqVBTsoW44MKR6adqaz31JFYIzkyaPW0XJ9FLCDAhJVURW9/LEH7fFvxNHkfI1GO3FooKp4nCbkMqLpL80+oY+GXEx7jvzt6s913UEieE261L4KlRdPikSP9Np5v2WRPnMuU+NrYPvd+rwGcJoBRXK2JRIaI0hbcR3CSN4ul9n4W5rU+nnFHiKGzTX0rPlfj3b9Pwe4kA77Bu4Miz68QG6meQ1WYj2QrW8obYV4c5DlmriPl1IKKUiq9fYi4QSuG4Xh663zR7Q60YAH7d1UawynKxr9U4FnBt55af6h1P/m0QfVTHShQlKvHaQLkX4ftWIGHew7+ERS/xL/Q== X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(61400799027)(82310400026)(36860700016)(23010399003)(56012099006)(11063799006)(16102099003)(10067099003)(18002099003)(22082099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: CFzZXrvJnVEaGd1gXkdGrOkCXNu3AxkABZFTPN5sm/jTf5rcbyPHO/GTxTo8BE3qyMB84YAEC6UEpE54AKP1E09eEB89a0s7KR6PLSJBaExkpGKsNEn9H+Esrg9ih9jPqVunJ8ouRNk1B3lK5UCILZt6cI0R+xTV9eFzaXnsOozGKR9KDelZsNkjuoDdU6j1OdKU8gX+jn+UC4QQ/xSoGCUU67urs+Nsjh4Vs/xMkf7Esyw+vBOIEoZxZqflNYglfmQ/CZJGt6RanSv2/kwSYQZNo3kiVECDiFyHhaGQBc/4QLxJjzLLMqlJCM4P0te+eiuXh7yuRY9bwXyfMCH5nxtyWdLA31yqtULvezltXoa1qJftqvIBZ4sbXZ/AOmu2hJWcTEsJugnRS0o8XjWodfWGJedoT4OOnkFNXq6k5MRC6zeD1pWhYqdMg2jlDztM X-Exchange-RoutingPolicyChecked: 3FyTV0RWcBcrmu8t6ktcGX1BUeqA45Nx/lYHDWHAxK71vvXhrCFBP+xudUM4hsCwNNTTKqBs86o3jYNoBf6oj2wq7UKmQc9XSNzkrWfzb/wwlIKHlIXRVOeTgheqpdeKivwvMOK9btryyb3J1DMFvP33CMtkZdy+NQSOxnmK6H1dcWEmjrfLzLn+XOX2sny7BHOyXN6wIENkhVKe/hlFnPBf0Xmzaqcryutozlur9mRkZ4zzGN+/CVzccsueV8duptHF2dHc53rCL+n/FqOEzo9n2BYq1WlS56vEZPrnS1nlrIAdblm0jNQom8l9GC2wFrzptnTgNqM4iKgMwRTS3A== X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2026 10:28:19.9221 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ce9819f9-a7dd-48a3-1b23-08df2914b3bd X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-CH3PEPF00000010.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR19MB8027 X-Authority-Analysis: v=2.4 cv=A/n5rKWG c=1 sm=1 tr=0 ts=6ace07c9 cx=c_pps a=OkMMD3sknCYbbSSSOfdz/w==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=VkNPw1HP01LnGYTKEx00:22 a=iX4cTi3TZMoOKdANLEfx:22 a=Dj2-6B8FqX4mGL0U3gbX:22 a=w1d2syhTAAAA:8 a=6KqoQpt3PVVccOLwCHsA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-GUID: Z7SZ7lOVJliCQPw6kw4tNp1inUox4OoV X-Proofpoint-Spam-Info: AW1haW4tMjYxMDEzMDA0MSBTYWx0ZWRfX9lgWXlGizOgu 2SC9Pqi0yMob6qH+Ao13Yj4mS1N0iRPNoOi0hEPdNn96pdGv91+n3j3RFUnJVyIUR9/NPAiktfe T4xn5G6oJN6GLakDJ6WY/hNe/2UFr4M= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDEzMDA0MSBTYWx0ZWRfX1/CQUtGxBP6K NFVoRpjxwjuJOuWE1OtJU6AJvQanZ9j2m2GAhKCNHiiiqsoNjiP+VmABhrsbXvHPVKlwu7DZvOO Fx/H2Wv7vVEqLVuzouiUuJxHPFmEuSRFiMi45/BQ295g+9W59JSOLTMcO9eQNwQrAFzkOXeefoC s2TOpcYkWeGXOzhAYRYK6ESm3o5+lGvyvrhXhPbd8TBa/DM0BJdruXkyrlLpd1LYsC4d9Xa/DRh Xa5uN+3eVnyMqOlkSUIFSTy7o3EUjVjtY1u1PlfS3xH4rYareJRC0jbuPBcfVsCwkFhuZn42TN1 XyxIe+PxSo3HDgxhqCV3/g+te4N6WhG5qtvVbR50JiHrvk4lgdcwQNXnNbv8auFGIluDBkgzwH+ /f7kL1Ycz/5a8J7phGD41uWcTTZtLY4pINNJlv1T3UIJYiBtPbXbgmqocmUx2WWIZup7xi60eJz ywRsfdvNv2VAeguZhaA== X-Proofpoint-ORIG-GUID: Z7SZ7lOVJliCQPw6kw4tNp1inUox4OoV X-Proofpoint-Spam-Reason: safe On 13/10/2026 11:23 am, Mingxuan Guo wrote: > cs_dsp_run() sets dsp->running = true once the core has been started, but > the error path below it only stops and disables the core, leaving the flag > set. The first thing that can fail after that point is the post_run client > hook, and it is reachable in mainline: wm_adsp registers > wm_adsp_event_post_run(), which can fail in wm_adsp_buffer_init(). Reviewed-by: Richard Fitzgerald