From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5766938D012 for ; Fri, 13 Mar 2026 10:19:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773397180; cv=none; b=byda07z5Ni1/6+OYHufpPRzGOHe5eAnR87rPUXx0/pcQwd3VKq2/1WX2cLNufRDjjZApYj1hr3pW0h1XvegJ/0bX3PpQ6lLtdRNQSTOF0ozpjeossdIc02oKhtoA7mgIr5K7K0vIqrl0eVyKIj23h9N9xSlwCsD5SvdGDKr6RkU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773397180; c=relaxed/simple; bh=1F8Wfguj6DdcYhkAt1RTnNhn+M3z6GesUqLesvs+S6k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PJXhWUUW84E2arQtx6qEUg8ElIqcB+QOlyHj3Mb6oR+VMVmoL3jDv6JiOAwP6l6LQpQ0S0t6sfKujN8Ns4x/UEvd8G9oi3Gd/rU6oW+mZvtIGidPA3uaX65Hk4NIl1Ir7ayKDAEpsPBK7cbhKvYOVf9sxijLZZvoBnx5FPur0lg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hIosWTDY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YCrVqYYT; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hIosWTDY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YCrVqYYT" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62D7JKJD237571 for ; Fri, 13 Mar 2026 10:19:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= LFJr93g+gvzJomEerwFbGRLs36qbntliWexUDx+bAtg=; b=hIosWTDY0aM6amfz aMTQjkO/31Q8KLzkUqubCKC0NTDF90ia28DAxSKccLEJS17kTqR3NFXFEUfoUEZ/ Q12plSPBzIeBRV4TqZOM/kiyakCN8keI7vg1mHj7ndujd0BxcRBXusXqCvj/NmEa E3Wzyi22JaN8FU0SqtuiL+oCyHBZJGDhPhnq+US2mzU9Q5R9rD9CFXYxgeDI6/uE NgL7hV77aZUVlJwOPiapuy/5virWkla3xz7TueawhOyf7VDc8Ve32t7mXpOtado3 L0eVq8+FuzjEvRPMKmzCPinAcQZzJM4VonzXJBXoQXTlOekzJa9A7QrH2gzgI45G tDMI4g== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cve3d8n5n-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 13 Mar 2026 10:19:34 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-89a012f8ab7so11485346d6.2 for ; Fri, 13 Mar 2026 03:19:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773397173; x=1774001973; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=LFJr93g+gvzJomEerwFbGRLs36qbntliWexUDx+bAtg=; b=YCrVqYYTZGybE++39LOvXCg4TJYj6rSey0ICXhExw4vYPTHpBIFoN14XrO9KKnLECv 9DXQ3pRVfrfluzkDx55K4jpJwDEfNryUsMhJCH0q7eeU4KJ/IHvIUbDJwptEEmto4z4i 9WDl82N7OUuxAekN6lgXZ4BeKftyxHvmpKZg7stmXjxcuGBHceB02UijsuVw/Dsy6ocR sO570lKWr54aVZpAbFFvm1Av5piW62vlo6Mp0znvEF/JzT4UMkzY5FMT91NEPp4QzS8+ RzfJE5OzkkAFy5QMCBoZJYT9nt+8WD26Go1c0FxoguEWv/4VCyRWsijdVVMyw4eUJ1di Argw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773397173; x=1774001973; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LFJr93g+gvzJomEerwFbGRLs36qbntliWexUDx+bAtg=; b=FMoFzfqG+TuW6RREvMsImbMAw0gEKZrNMwZ9cIgSO5Lu/7bANW4lKH6gPaVqv508Ni iss1NZaSLrfT0cgA++6pKZiuAMD7KLVlORk9cezl2jc9lPMouwzQzq3e0x6L8ST4Qrgv tMJgPZsYd72/fSj0Oh7JHBt0RHs1fZ1PvS3uJhOJi6eOmdR/FVj5PZ4dEowBVwzf6IpH f3kZEJJyt2q2UbRxyFHddfIg3rrmS5UAq3DL+qKZKM4TRgpmw2yhfp+yMQHMyRmr/+sM 666dy1a/hjeTltb/5Wmi+f8GKBVUxhkizM2t5MNYVPSEGMYUdMYYG6bPjiUhIsF70SHW dNkg== X-Forwarded-Encrypted: i=1; AJvYcCVuXQhp83M/v038dEFTrKoKj9kKTMDnVK3Nwhk8S2iT1ogP8dMIK85yGGuV2Z1LA8wabdlfQ2QFMGp6VTA=@vger.kernel.org X-Gm-Message-State: AOJu0YzPdVU+moigp+LNHlpHYYFUHWH2ibwfQmkmTa4n5upNB6P9873S rJCj+fWFehd2B5ybf7+m7DmSfxlLj+qWZ7NwXVykO6QiiWDHnyDv3E2veEgI6FTnfnP0rRpVqJE k3nEiHThdf6reblg8b1xUSNxjRjvGHmOCEC3GrEdRqHAZ+frFUWB5VIAgOqQ/Nh8WD5w= X-Gm-Gg: ATEYQzzsDdqLut1uv7u6Zc9kRPGeF4KFs+661MV6yYXZNr8QyInQDJadHBywidAmuF3 YdfkZigLToveSYHUGA+VUoVZjwijV+Yh6IvAVaE6xWoymLpRB9cETWweluepOq2/Ydipr3iyPRF d7iRwUL5XeC73kGGe4CCKyUU/9PNpxpekByuktoD8TQH7GWeDy7DLWpi6KPq81wAgn9JbgXmTdK qIgzMOaDAniuqfgZbgaN3HlpZ7QhocUEZJWr9r9vql6J7bBrWDtE2nJGHvTjlw6HiqWNNEq2nuV Q9zbUHKwz0gOI90j3XwQpTm6iHSMrlWuvMa0yQsI5VkslahS3Kyq2iRPUD2dDJblW01XbUDvFFB MPhOZNIkvC+eyBzlSzwtPOYbrT6Jp/9YUT5hLuuL3DtRnpzduRPmrluZ32VTx0PJsTcIW8eZ6zf Riqoo= X-Received: by 2002:a05:6214:4e01:b0:89a:595c:b805 with SMTP id 6a1803df08f44-89a820986afmr27955036d6.6.1773397173299; Fri, 13 Mar 2026 03:19:33 -0700 (PDT) X-Received: by 2002:a05:6214:4e01:b0:89a:595c:b805 with SMTP id 6a1803df08f44-89a820986afmr27954796d6.6.1773397172874; Fri, 13 Mar 2026 03:19:32 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b97756e59b6sm16300466b.10.2026.03.13.03.19.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Mar 2026 03:19:31 -0700 (PDT) Message-ID: <351bd44a-3570-4490-a471-0d31750befaf@oss.qualcomm.com> Date: Fri, 13 Mar 2026 11:19:29 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 04/27] soc: qcom: ubwc: add helper controlling AMSBC enablement To: Dmitry Baryshkov , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> <20260312-ubwc-rework-v3-4-b7e8f800176a@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260312-ubwc-rework-v3-4-b7e8f800176a@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 1NcNhUk9RW_bJTPd5-8dJb8aoPq2G0Kl X-Authority-Analysis: v=2.4 cv=FLwWBuos c=1 sm=1 tr=0 ts=69b3e4b6 cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=ofppVGNrExDXTkBWrYEA:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEzMDA4MCBTYWx0ZWRfX8NkF8ld+HdhV hk12AUoKTPkvbMLZKX1FljDoTFvXLBrtzVN50mQXB85M6+rp45Nzj4MClkLULUvOfx5NZ0VPPLr JkamRKpwzKZHXyeBvHmpX/CwH2FFY1N1NSe7/s1MaQtoudJI90NEwBS5Zqy3IXqw/6HNzqGCngE T2OcI8Nvb10TWbVCMomMe+y49JmYuaaj9w6CWrVmOeKSw53fqdu2kZji6YLLnQ9gmRgMJUiw5f1 dbD0zEm83IB5MQnkwAzXDQlzpFjREKFFfb16F41LZfsrOitGyUUitZbLJOp2dqamUERhO+5zzYg w0EEz6hzzeLjJP55gjsRW+7omOyoHd8ku1sbQAIaXrqN7gqJ3+fqAtj3PH/3NyvQEPXKCj0VULu vJsQ+Gqa9h0is30pyGr1POzxw1dPW24sryRQwGZO/kTQEIJ6S627pOCCLZZfC0LZUoQQ/YQfwuO dSECMHK5/GveC0ewviA== X-Proofpoint-GUID: 1NcNhUk9RW_bJTPd5-8dJb8aoPq2G0Kl X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-13_02,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 bulkscore=0 malwarescore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 adultscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603130080 On 3/12/26 2:29 PM, Dmitry Baryshkov wrote: > Adreno and MDSS drivers need to know whether to enable AMSBC. Add > separate helper, describing that feature. > > Signed-off-by: Dmitry Baryshkov > --- > include/linux/soc/qcom/ubwc.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/include/linux/soc/qcom/ubwc.h b/include/linux/soc/qcom/ubwc.h > index 8355ffe40f88..83d2c2a7116c 100644 > --- a/include/linux/soc/qcom/ubwc.h > +++ b/include/linux/soc/qcom/ubwc.h > @@ -116,4 +116,9 @@ static inline u32 qcom_ubwc_version_tag(const struct qcom_ubwc_cfg_data *cfg) > return 0; > } > > +static inline bool qcom_ubwc_enable_amsbc(const struct qcom_ubwc_cfg_data *cfg) > +{ > + return cfg->ubwc_enc_version >= UBWC_3_0; Note KGSL doesn't enable AMSBC for UBWC_6_0 and A8xx (but does for A8xx+ UBWC3..5) The initial commit adding A6xx support to KGSL has this hunk: + case KGSL_UBWC_3_0: + mode = 0; + amsbc = 1; /* Only valid for A640 and A680 */ + break; That was in a time where A640/680 (8150/8180 respectively, with UBWC3_x) may have still been under heavy development - this initial driver was targeting A630/SDM845 (UBWC2), so perhaps that's not really meaningful Konrad