From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751462AbdJRPWu (ORCPT ); Wed, 18 Oct 2017 11:22:50 -0400 Received: from mout.web.de ([212.227.17.12]:51125 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750751AbdJRPWs (ORCPT ); Wed, 18 Oct 2017 11:22:48 -0400 Subject: Re: char/tpm: Improve a size determination in nine functions To: Jarkko Sakkinen , linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Cc: Mimi Zohar , Julia Lawall , Alexander Steffen , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Andy Shevchenko , Benjamin Herrenschmidt , Corentin Labbe , Jason Gunthorpe , Jerry Snitselaar , Kenneth Goldman , Michael Ellerman , Nayna Jain , Paul Mackerras , =?UTF-8?Q?Peter_H=c3=bcwe?= , Stefan Berger References: <1d3516a2-a8e6-9e95-d438-f115fac84c7f@users.sourceforge.net> <83a166af-aecc-649d-dfe3-a72245345209@users.sourceforge.net> <1508238182.16112.475.camel@linux.intel.com> <1508244757.4234.60.camel@linux.vnet.ibm.com> <1508253453.4234.81.camel@linux.vnet.ibm.com> <9689f036-ba9f-d23b-cf89-c289bc308771@users.sourceforge.net> <20171018145735.lpzwakatsty7emlw@linux.intel.com> From: SF Markus Elfring Message-ID: <351cf78a-14f6-c6e7-2902-048e7dc57a14@users.sourceforge.net> Date: Wed, 18 Oct 2017 17:22:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171018145735.lpzwakatsty7emlw@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:uj72r7mWSRM/4rv5thraP042PyjkUdtJIcqtJwAph/Ln5SlAd8J tw0d2zNjcI/Wf5ZYgY06ftw2FRoSzC0ykyhKlSIBoc/usr8yOOJuVDiENbeCpMk1TbIJBK7 VJzFq3s/C7f6mM6aimpD3KdJOe39SJ3gKtp8PLLJBlX6yNmL0txSilbTgSVPnUAMqe01e9x 3ffykSMmfS60x9NxJsB5A== X-UI-Out-Filterresults: notjunk:1;V01:K0:Iu1RVdfPmOQ=:N9CT4eNRyuVaYxnBA1Utzw wJLRjR/AWTCrk8eYDcp4yGI0bHTpZLTwUdOjXW+HM2o+3UZFlntu03B0w5hRM+JdSYLFJMyHe 25cSJ/M4MUVpbS1GcFzBKLuEuSj1xoztOQ9Y1qwhLiVoiGjeYBMynktCQy/NJNPZcmWk1pC91 abBIxd0fRtfuU4jWVgRPX6Rp5CRLnZuToH/2WITMgv0VBrTVHnJsKEpr0f8F7W9SLhoY3BQyk f5Wmv/lkBI/cSW6+46uNEvO0XWvfmViucvuRH61UTM3D6HBMRJAgg1U7XEve5CsPneX39x0rd 5LY0O2cLNSBf0B6lporeO0iDbvYJwZ1lvwa7SiYKxfYm5xOSoNUjGiHTEcK7Z98tyDv7rI+E/ PZ5lTsfVpkaPOHWqffp57oCU8uCwmVrNvFyRJ8/XYVujYJ9rwSwguPYjTDPc+khQBKh2TCHuT mhOxxLiU5D95vEXLmGb6ZPnBL8qKt3hV58sDux5qbhqha9p7FUdREJLhjol2AAZiT9Jmt6aGV yU1bXoI6OoSYPz4q6teYonDY6/vKtqFIS6kCIlz7c6fq/K1KloMgFLVFCx/f17yRAjaGCBpUN 19Lltf2/LW9waqGJAP0YgKpy1mv6lIsR3j7sPYZ7aAJJCaOvgP5vwUmPIvrJBg7d0gHBE4p9n 87qfRkn9wr44UdjgGMZ64O5eOVuHH7ypdG6HgUyk1NpoDIdYxrjIHmsQFizlcFNwcyj8j8Juh V32MnsYApoOgJDSuq6sPWt7wfhWVlb0y6YySulQGpW8M/qYBMwLO95BIyVK9uPbp3SGDyKRnx vRDBoFvokWoHfe/2hskphRSI6h6KlNK0cmSdPKUYJqHUTfef3I= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> Do you find my wording “This issue was detected by using the >> Coccinelle software.” insufficient? > > This is fine for cover letter, not for the commits. I guess that there are more opinions available by other contributors for this aspect. > After your analysis software finds an issue you should manually analyze > what is wrong This view is generally fine. > and document that to the commit message. I tried it in a single paragraph so far (besides the reference for the tool). > This applies to sparse, coccinelle or any other tool. I find that further possibilities can be considered. > Tool-based commit messages are bad for commit history I disagree to this view. > where as clean description gives idea what was done > (if you have to maintain a GIT tree). How do you think about to offer any wording for an alternative which you would find better? > In my opinion tool is doing all the work but the part > that you should do is absent. Really? Regards, Markus