From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f54.google.com (mail-dl1-f54.google.com [74.125.82.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2FF62DA75C for ; Tue, 17 Mar 2026 15:59:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773763185; cv=none; b=E1pCPkV98GxW6COykLdy2AICe/DHW/y7M5UoGkDoUnvrV1PKTjLa1KvMtz1gM38FdQoiolqPTjgPXa8gRzgTxBwKb2Zp3epuxbPwuxeGxa5zQJMkNBBQXK4c9xha/Wu7vlN7PtfGj4xlx+52V40gizzWG7hDYbie+tMW+a3I514= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773763185; c=relaxed/simple; bh=rhfyqxH0aD0+p3Dpg2vsvaa7zDV0kR6JjfIqK+30h9Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=N6V+qCesKyO+pwsw8zorM6SSGYeHNImJO7vmQ1aU6E7Ij9WIg9rN5olfKyWDZsN2WtjMXZWldOPpMIVIP8PhnsghrS0GXpmsN6VjuCcouDpdMtZSpmuXmqxHw70/TtDXv5Y6yp2PB5ohW+hFl/HNqZJGtXYxCy5O7bVhH/oS8Tg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BTJUnI07; arc=none smtp.client-ip=74.125.82.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BTJUnI07" Received: by mail-dl1-f54.google.com with SMTP id a92af1059eb24-1273349c56bso8905306c88.0 for ; Tue, 17 Mar 2026 08:59:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773763184; x=1774367984; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=qStIndcPGw+JcPKLiWKmJZ3dJRcw/C0qeNG09MqJaTo=; b=BTJUnI07Ig1TLRJUdNAoARb+Z2uKhqlcdfd3nDrqmiWutbADOx4WmMlpabQfnFymla tP/9D9c59Ih48EVjsIybtttehOkCWb/5OZXbkbkbWGJpLM2RJsaijBxLfRNgz43P/rS+ ARrk2g1u2WoBZJz7nA/l3th4DoMGf0L7UdmgcAlEkFpfFwum9XGDxJGg1gDCD2svgIaR MpEttFVmQO7Ri4ofKghaPtVH6kjDcLl79LF+IIDgzsS4EJM3UaGz0jqxksRrkTnAlGP+ gOBrK1qvHUQ7re803B/nszktl6PC3yS2XK5Jc7GxLZ7eFCZ4MhXPsSW6It6iC+RyLOMt ClEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773763184; x=1774367984; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=qStIndcPGw+JcPKLiWKmJZ3dJRcw/C0qeNG09MqJaTo=; b=rvpzNvFIz1cUfXkHPtMLuRqO/LCUYqhUV80frzmtCq+8eYZiGcFwLY+08WiLdgBj8e nx+6qoBmCYu+s3Rj23sbVBhe4iO4OkQ9HL4FzXAiA8SRIbsxhGV0e5TRF3o3/26Wy0qe UNBJ+R4bzMtJN4JwBbK7PuJafwRBZRRi7scvnr0etxa+iOYzDd7QZfsAPtWKf5zyzVKT UaNQQZtmAYoh/S49O1U+peUiEev8E2dfgfDeTwHPPrqIeEpyIC6nlhSbnAUm5FW2yUTK ThNtL1i2YIxz86DzMo9TsXJGWGBWa9h/XV2e/fc9uCum9VmEy2CV2ST/KZ+agu9Gf70f L3OA== X-Forwarded-Encrypted: i=1; AJvYcCVj3pjA3sijrjiQoGw1nvYhhf2vJo9GmZLqrirLlSd6sKyGcL+Jd5fd5x16Lg3GOGwnCZU9Khzmr0B5zc0=@vger.kernel.org X-Gm-Message-State: AOJu0YxWgt9uy0BP2pXkHH0btCtYi+ZA2Lnc1FPfpcAS1yWadxXMgpdN upu+wFFnZzCqwS+IhaJGwZJd9fj0dsBWbTkCtn/7/O1MeRB/E/3umrrNeIJepQ== X-Gm-Gg: ATEYQzx0Giyd1y+1CzEuc905gJhJZtmuOnoixsMkw1mP5OA3luvtvDaqDeeie9JjOwn Y6ul2sQ5oECi+uCSbSkg1xrVjY07x7O3PItY8Oha+tMOicqR+MieXjW/YjIcN1LW216iEPw+Acs sz4/ozdavM2SOajW4L/yRymoP0oYl88ZtoKAcmGflULkaXwXJ46uanquyvfhnXj8SylBveSuPOe d9Fs3zMXhazmvj77OM1TWi+0Hguin8htolPu0mGfBKoRUB6tA4gsJ+s5uh82tWqid03X8noGues gIURlRoFXMyLQGYoBW9JgM9lhldwRu6qrgcsZ2T7TsCcr4cqRrRywtduxZaIn7ROS+yvwTfkm7G UNaM3MLN+Xy95GIGGqsTFskTc6P+dpJIv4/5+gvvNqHOEyT+fTgLIUVNma4aD2aPrLfMw120FbJ emhDUODD/l2+w41Hvgv7MCQ6PMbatrZAlAYohc X-Received: by 2002:a05:7022:4387:b0:119:e569:f609 with SMTP id a92af1059eb24-1299ba1cb97mr18072c88.2.1773763183880; Tue, 17 Mar 2026 08:59:43 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-128f62991c7sm16442227c88.5.2026.03.17.08.59.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 08:59:38 -0700 (PDT) Sender: Guenter Roeck Date: Tue, 17 Mar 2026 08:59:36 -0700 From: Guenter Roeck To: Billy Tsai Cc: Joel Stanley , Andrew Jeffery , Philipp Zabel , linux-hwmon@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] hwmon: (aspeed-g6-pwm-tach): remove redundant driver remove callback Message-ID: <351decf2-0a11-4f4c-a332-d5ae28c4c13f@roeck-us.net> References: <20260309-pwm_fixes-v2-1-ca9768e70470@aspeedtech.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260309-pwm_fixes-v2-1-ca9768e70470@aspeedtech.com> On Mon, Mar 09, 2026 at 10:33:24AM +0800, Billy Tsai wrote: > Drops the remove callback as it only asserts reset and the probe already > registers a devres action (devm_add_action_or_reset()) to call > aspeed_pwm_tach_reset_assert(). > > Fixes: 7e1449cd15d1 ("hwmon: (aspeed-g6-pwm-tacho): Support for ASPEED g6 PWM/Fan tach") > Signed-off-by: Billy Tsai Applied. Thanks, Guenter