From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753863AbaEHLRV (ORCPT ); Thu, 8 May 2014 07:17:21 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:58069 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753056AbaEHLRT (ORCPT ); Thu, 8 May 2014 07:17:19 -0400 From: "Rafael J. Wysocki" To: Geert Uytterhoeven Cc: Stratos Karafotis , Viresh Kumar , "linux-pm@vger.kernel.org" , LKML Subject: Re: [PATCH] cpufreq: Fix build error on some platforms that use cpufreq_for_each_* Date: Thu, 08 May 2014 13:33:59 +0200 Message-ID: <3521459.jky0yxFEoL@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/3.14.0-rc7+; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <536A605D.6030009@semaphore.gr> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, May 08, 2014 10:27:15 AM Geert Uytterhoeven wrote: > Hi Stratos, > > On Wed, May 7, 2014 at 6:33 PM, Stratos Karafotis wrote: > > On platforms that use cpufreq_for_each_* macros, build fails if > > CONFIG_CPU_FREQ=n, e.g. ARM/shmobile/koelsch/non-multiplatform: > > > > drivers/built-in.o: In function `clk_round_parent': > > clkdev.c:(.text+0xcf168): undefined reference to `cpufreq_next_valid' > > drivers/built-in.o: In function `clk_rate_table_find': > > clkdev.c:(.text+0xcf820): undefined reference to `cpufreq_next_valid' > > make[3]: *** [vmlinux] Error 1 > > > > Fix this making cpufreq_next_valid function inline and move it to > > cpufreq.h. > > Thanks! > > > Reported-by: Geert Uytterhoeven > > Signed-off-by: Stratos Karafotis > > Tested-by: Geert Uytterhoeven > Applied, thanks! -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.